Uploaded image for project: 'Causeway'
  1. Causeway
  2. CAUSEWAY-2195

Performance optimisation: short-circuit searching for actions if possible

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 2.0.0-M3
    • None
    • None

    Description

      If explicit actions are configured (isis.reflector.explicit-annotions.action=true) then any method that does not have @Action annotation by definition is not an action.  We should therefore check for this early on when introspecting a domain type's method, to avoid searching more deeply than we would otherwise care.

      We should also avoid looking at a method's parameters and return types until we've decided that the method is an action (either explicitly or implicitly).

      The side-effect of not doing this is that we end up with types that otherwise don't need to be in the metamodel, meaning that startup takes longer.

       

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            danhaywood Daniel Keir Haywood
            danhaywood Daniel Keir Haywood
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment