[CAUSEWAY-2118] Don't redundantly add additional DisabledFacet when disabled at class-level (also fixed in "v1 maintenance")

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.17.0
• Fix Version/s: v1 maintenance, 2.0.0-M3
• Assignee: Daniel Keir Haywood
• Reporter: Daniel Keir Haywood
• Created: 14/May/19 14:29
• Updated: 19/Mar/20 10:56
• Resolved: 14/May/19 14:31

Description

using the ISIS-2015 mixin, I see the following for kitchensink's ReferenceObject when annotated as @DomainObject(editing=DISABLED)

            <mml:prop id="otherName">
                <mml:facets>
                    ...
                    <mml:facet id="org.apache.isis.core.metamodel.facets.members.disabled.DisabledFacet" fqcn="org.apache.isis.core.metamodel.facets.properties.disabled.fromimmutable.DisabledFacetOnPropertyDerivedFromImmutable">
                        <mml:attr name="disabling">true</mml:attr>
                        <mml:attr name="inverted">false</mml:attr>
                        <mml:attr name="semantics">DISABLED</mml:attr>
                        <mml:attr name="when">ALWAYS</mml:attr>
                        <mml:attr name="where">ANYWHERE</mml:attr>
                    </mml:facet>
                    ...
                    <mml:facet id="org.apache.isis.core.metamodel.facets.object.immutable.ImmutableFacet" fqcn="org.apache.isis.core.metamodel.facets.object.domainobject.editing.ImmutableFacetForDomainObjectAnnotation">
                        <mml:attr name="disabling">true</mml:attr>
                        <mml:attr name="reason">Disabled</mml:attr>
                        <mml:attr name="when">ALWAYS</mml:attr>
                    </mml:facet>

The ImmutableFacet isn't required, because the DisabledFacetOnPropertyDerivedFromImmutable should suffice.