Uploaded image for project: 'Isis'
  1. Isis
  2. ISIS-2118

Don't redundantly add additional DisabledFacet when disabled at class-level.

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.17.0
    • Fix Version/s: 1.18.0
    • Component/s: None
    • Labels:
      None

      Description

      using the ISIS-2015 mixin, I see the following for kitchensink's ReferenceObject when annotated as @DomainObject(editing=DISABLED)

                  <mml:prop id="otherName">
                      <mml:facets>
                          ...
                          <mml:facet id="org.apache.isis.core.metamodel.facets.members.disabled.DisabledFacet" fqcn="org.apache.isis.core.metamodel.facets.properties.disabled.fromimmutable.DisabledFacetOnPropertyDerivedFromImmutable">
                              <mml:attr name="disabling">true</mml:attr>
                              <mml:attr name="inverted">false</mml:attr>
                              <mml:attr name="semantics">DISABLED</mml:attr>
                              <mml:attr name="when">ALWAYS</mml:attr>
                              <mml:attr name="where">ANYWHERE</mml:attr>
                          </mml:facet>
                          ...
                          <mml:facet id="org.apache.isis.core.metamodel.facets.object.immutable.ImmutableFacet" fqcn="org.apache.isis.core.metamodel.facets.object.domainobject.editing.ImmutableFacetForDomainObjectAnnotation">
                              <mml:attr name="disabling">true</mml:attr>
                              <mml:attr name="reason">Disabled</mml:attr>
                              <mml:attr name="when">ALWAYS</mml:attr>
                          </mml:facet>
      

      The ImmutableFacet isn't required, because the DisabledFacetOnPropertyDerivedFromImmutable should suffice.

        Attachments

          Activity

            People

            • Assignee:
              danhaywood Daniel Keir Haywood
              Reporter:
              danhaywood Daniel Keir Haywood
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: