[CAUSEWAY-207] Improve the message given when a field is too long (exceeds its @MaxLength value)

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.2.0-incubating, core-1.0.0
• Fix Version/s: core-1.1.0
• Component/s: Core
• Assignee: Unassigned
• Reporter: Robert Charles Matthews
• Created: 17/Feb/12 21:37
• Updated: 31/Jan/13 14:05
• Resolved: 25/Jan/13 18:35

Description

The value is repeated stating it is too long. This is particularly bad for a long entry, and the value itself is probably not needed anyway.

Problem is in MaxLengthFacetAbstract.java in the return statement.

@Override
public String invalidates(final ValidityContext<? extends ValidityEvent> context) {
if (!(context instanceof ProposedHolder))

{ return null; }
final ProposedHolder proposedHolder = (ProposedHolder) context;
final ObjectAdapter proposedArgument = proposedHolder.getProposed();
if (!exceeds(proposedArgument)) { return null; }

return "Proposed value '" + proposedArgument.titleString() + "' exceeds the maximum length of " + value();
}