[CAUSEWAY-1914] Remove the ability to add additional services to an AppManifest or Module

• Type: Question
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0.0-M3
• Component/s: Core
• Assignee: Unassigned
• Reporter: Andi Huber
• Created: 13/Mar/18 15:24
• Updated: 19/Mar/20 15:22
• Resolved: 19/Mar/20 15:22

Description

Instead, should work only at the Module level.

~~~

this is prompted by Andi's original reason for raising this ticket, where he noted:

 

Adding a Service outside of the scope of configured modules fails with

java.lang.AssertionError: Metamodel is invalid: 
Domain objects discovered in package 'x.x.x' are not in the set of modules obtained from the AppManifest's top-level module 'y.y.y.MyModule'.  Classes are: x.x.x.MyService

Source:

public abstract class DomainAppIntegTestAbstract extends IntegrationTestAbstract3 {

    public DomainAppIntegTestAbstract() {
        super(new MyModule()
        	.withAdditionalServices(MyService.class)
				
		...
				
		;
    }

}

If this behavior is intended, than what is the point of adding additional services?

 

~~~

^^^ which is a fair point.  So, we ought to just get rid of that capability to add adhoc services, and instead require only that the user specifies additional modules (which they already can do) and pick up any services within those modules.