Uploaded image for project: 'Isis'
  1. Isis
  2. ISIS-1719

QueryResultsCache should be disable when running fixture scripts.

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.15.0
    • Fix Version/s: 1.15.1
    • Component/s: None
    • Labels:
      None

      Description

      This is currently done if invoked via the FixtureScripts menu service, but not automatically for integration tests.

      Suggest that this can be disabled, in case it starts breaking tests for folk.

      see (IsisSessionFactory):

       @Programmatic
          public void constructServices() {
      
                  ...
      
                  //
                  // installFixturesIfRequired
                  //
                  final FixturesInstallerFromConfiguration fixtureInstaller =
                          new FixturesInstallerFromConfiguration(this);
                  fixtureInstaller.installFixtures();
      
      			...
      			
      }
      

      and (in FixtureScriptsDefault):

          public List<FixtureResult> runFixtureScript(
                  final FixtureScript fixtureScript,
                  @ParameterLayout(
                      named = "Parameters",
                      describedAs =
                              "Script-specific parameters (if any).  The format depends on the script implementation (eg key=value, CSV, JSON, XML etc)",
                      multiLine = 10)
                  @Parameter(optionality = Optionality.OPTIONAL)
                  final String parameters) {
              try {
                  eventBusService.post(new FixturesInstallingEvent(this));
                  return super.runFixtureScript(fixtureScript, parameters);
              } finally {
                  eventBusService.post(new FixturesInstalledEvent(this));
              }
          }
      
      

        Activity

        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit bf056704a3b4d839887750a2a6073db76ad741dc in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=bf05670 ]

        ISIS-1719: fires events while installing fixtures

        (for QueryResultsCache to listen to).

        Show
        jira-bot ASF subversion and git services added a comment - Commit bf056704a3b4d839887750a2a6073db76ad741dc in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=bf05670 ] ISIS-1719 : fires events while installing fixtures (for QueryResultsCache to listen to).

          People

          • Assignee:
            danhaywood Dan Haywood
            Reporter:
            danhaywood Dan Haywood
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development