Uploaded image for project: 'Isis'
  1. Isis
  2. ISIS-1715

Service priority as defined by @DomainServiceLayout#menuOrder or @DomainService#menuOrder not honored.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.15.0
    • Fix Version/s: 1.15.1
    • Component/s: Core
    • Labels:
      None

      Description

      It seems menu contributing service's will not always produce submenus ordered correctly:

      I found a case, where menuOrder was not honored while 2 menu-services were both contributing to the same menu. The member sequence for each group was correct, but the order of the groups was wrong.

      @DomainService(nature = NatureOfService.VIEW_MENU_ONLY)
      @DomainServiceLayout(named="TODO", menuOrder="30.2")
      public class A {
      
          @Action
          @MemberOrder(sequence = "1.1")
          public void getAProperty() {
              
          }
      
      }
      
      @DomainService(nature=NatureOfService.VIEW_MENU_ONLY)
      @DomainServiceLayout(named="TODO", menuOrder="30.1")
      public class B {
      
          @Action
          @MemberOrder(sequence = "1.1")
          public void getBProperty() {
              
          }
      
      }
      

      Menu group B should be positioned above group A, but it sometimes is not.

        Activity

        Hide
        hobrom Andi Huber added a comment -

        It seems that @DomainServiceLayout#menuOrder and @DomainService#menuOrder do not honor Dewey Decimal format.

        Possible fix provided: PR #84
        https://github.com/apache/isis/pull/84

        Show
        hobrom Andi Huber added a comment - It seems that @DomainServiceLayout#menuOrder and @DomainService#menuOrder do not honor Dewey Decimal format . Possible fix provided: PR #84 https://github.com/apache/isis/pull/84
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 312ac31b770308a4dd14b115f30fcfc1cf2d45b4 in isis's branch refs/heads/pr-84 from Andi Huber
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=312ac31 ]

        Fix ISIS-1715 menuOrder not honored

        Show
        jira-bot ASF subversion and git services added a comment - Commit 312ac31b770308a4dd14b115f30fcfc1cf2d45b4 in isis's branch refs/heads/pr-84 from Andi Huber [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=312ac31 ] Fix ISIS-1715 menuOrder not honored
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1b60ce18f28e7369364e5712c546f6da32099c6a in isis's branch refs/heads/pr-84 from Andi Huber
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=1b60ce1 ]

        Fix ISIS-1715 menuOrder Dewey Decimal format not honored

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1b60ce18f28e7369364e5712c546f6da32099c6a in isis's branch refs/heads/pr-84 from Andi Huber [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=1b60ce1 ] Fix ISIS-1715 menuOrder Dewey Decimal format not honored
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 40107995b25b05d1bc9d72a65cf5512290a7165d in isis's branch refs/heads/pr-84 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=4010799 ]

        Merge branch 'ISIS-1715_pr-84'

        Show
        jira-bot ASF subversion and git services added a comment - Commit 40107995b25b05d1bc9d72a65cf5512290a7165d in isis's branch refs/heads/pr-84 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=4010799 ] Merge branch ' ISIS-1715 _pr-84'
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 4de5824f98c8092c32a4a84ce3b0f691b65dc5b4 in isis's branch refs/heads/pr-84 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=4de5824 ]

        ISIS-1715: adds unit test, removes commented out code.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 4de5824f98c8092c32a4a84ce3b0f691b65dc5b4 in isis's branch refs/heads/pr-84 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=4de5824 ] ISIS-1715 : adds unit test, removes commented out code.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 312ac31b770308a4dd14b115f30fcfc1cf2d45b4 in isis's branch refs/heads/master from Andi Huber
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=312ac31 ]

        Fix ISIS-1715 menuOrder not honored

        Show
        jira-bot ASF subversion and git services added a comment - Commit 312ac31b770308a4dd14b115f30fcfc1cf2d45b4 in isis's branch refs/heads/master from Andi Huber [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=312ac31 ] Fix ISIS-1715 menuOrder not honored
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1b60ce18f28e7369364e5712c546f6da32099c6a in isis's branch refs/heads/master from Andi Huber
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=1b60ce1 ]

        Fix ISIS-1715 menuOrder Dewey Decimal format not honored

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1b60ce18f28e7369364e5712c546f6da32099c6a in isis's branch refs/heads/master from Andi Huber [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=1b60ce1 ] Fix ISIS-1715 menuOrder Dewey Decimal format not honored
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 40107995b25b05d1bc9d72a65cf5512290a7165d in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=4010799 ]

        Merge branch 'ISIS-1715_pr-84'

        Show
        jira-bot ASF subversion and git services added a comment - Commit 40107995b25b05d1bc9d72a65cf5512290a7165d in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=4010799 ] Merge branch ' ISIS-1715 _pr-84'
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 4de5824f98c8092c32a4a84ce3b0f691b65dc5b4 in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=4de5824 ]

        ISIS-1715: adds unit test, removes commented out code.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 4de5824f98c8092c32a4a84ce3b0f691b65dc5b4 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=4de5824 ] ISIS-1715 : adds unit test, removes commented out code.

          People

          • Assignee:
            danhaywood Dan Haywood
            Reporter:
            hobrom Andi Huber
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development