Uploaded image for project: 'Isis'
  1. Isis
  2. ISIS-1706

Add 'username' config parameter to email service

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.15.1
    • Component/s: Core
    • Labels:
      None

      Description

      Currently the EmailService requires two configuration parameters:

      isis.service.email.sender.address
      isis.service.email.sender.password

      with three optional:

      isis.service.email.sender.hostname
      isis.service.email.port
      isis.service.email.tls.enabled

      Another optional one is needed:

      isis.service.email.sender.username

      Currently when logging on to an email server the isis.service.email.sender.address value is used as an account username, in addition to also being used as the 'sent-by' email address, if you don't have a choice as to the username this is problematic, such as with Amazon Simple Email Service (SES).

      With the additional config parameter, when present this value should override the isis.service.email.sender.address value as the account username, when not present the present arrangement should be used.

        Activity

        Hide
        steve cameron Steve Cameron added a comment -

        See changes in attached file

        Show
        steve cameron Steve Cameron added a comment - See changes in attached file
        Hide
        steve cameron Steve Cameron added a comment -

        See attachment.

        {I need to learn how to get my fork on Github up to current}
        Show
        steve cameron Steve Cameron added a comment - See attachment. {I need to learn how to get my fork on Github up to current}
        Hide
        danhaywood Dan Haywood added a comment -

        to get your fork up to current .... assuming you don't care about any local changes ...

        git checkout master
        git fetch
        git reset --hard origin/master
        
        Show
        danhaywood Dan Haywood added a comment - to get your fork up to current .... assuming you don't care about any local changes ... git checkout master git fetch git reset --hard origin/master
        Hide
        danhaywood Dan Haywood added a comment -

        Also... I noticed this ticket in the "resolved/done" state, so almost slipped by without the change being applied. Please make sure stays in the "to do" column so I know it's there to be looked at.

        thx

        Show
        danhaywood Dan Haywood added a comment - Also... I noticed this ticket in the "resolved/done" state, so almost slipped by without the change being applied. Please make sure stays in the "to do" column so I know it's there to be looked at. thx
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 7d06ccc50a5857ecfe95f1dedf98b8310e335783 in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=7d06ccc ]

        ISIS-1706: adds support to use a different username than the sender address when authenticating with the Email SMTP service

        Show
        jira-bot ASF subversion and git services added a comment - Commit 7d06ccc50a5857ecfe95f1dedf98b8310e335783 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=7d06ccc ] ISIS-1706 : adds support to use a different username than the sender address when authenticating with the Email SMTP service
        Hide
        steve cameron Steve Cameron added a comment -

        I found that this works, in my local clone of my github apache isis fork do:

        git remote add upstream https://github.com/apache/isis.git
        git fetch upstream
        git merge upstream/master
        git push origin master

        Show
        steve cameron Steve Cameron added a comment - I found that this works, in my local clone of my github apache isis fork do: git remote add upstream https://github.com/apache/isis.git git fetch upstream git merge upstream/master git push origin master

          People

          • Assignee:
            danhaywood Dan Haywood
            Reporter:
            steve cameron Steve Cameron
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development