Uploaded image for project: 'Isis'
  1. Isis
  2. ISIS-1668

INLINE_AS_IF_EDIT actions do not honour hidden or disabled facets.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.15.0
    • Component/s: None
    • Labels:
      None

      Description

      If an action is hidden but also INLINE_AS_IF_EDIT, then the action prompt can still be opened (by clicking on the associated property's field). Moreover, the action can be executed.

      If an action is disabled but also INLINE_AS_IF_EDIT, then the action prompt can still be opened (by clicking on the associated property's field). Attempting to execute the action will result in a confusing NOT_AUTHORISED error.

        Activity

        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 05a6624d797e4b4236e672500e0a5f45cca7f852 in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=05a6624 ]

        ISIS-1668: only enables prompt if the associated action is visible and enabled.

        Note that this still leaves ISIS-1670 (view is not dynamic)... but since ISIS-1670 was a problem even for regular editable properties, decided that the fix in this commit addresses ISIS-1668 sufficiently.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 05a6624d797e4b4236e672500e0a5f45cca7f852 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=05a6624 ] ISIS-1668 : only enables prompt if the associated action is visible and enabled. Note that this still leaves ISIS-1670 (view is not dynamic)... but since ISIS-1670 was a problem even for regular editable properties, decided that the fix in this commit addresses ISIS-1668 sufficiently.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 05a6624d797e4b4236e672500e0a5f45cca7f852 in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=05a6624 ]

        ISIS-1668: only enables prompt if the associated action is visible and enabled.

        Note that this still leaves ISIS-1670 (view is not dynamic)... but since ISIS-1670 was a problem even for regular editable properties, decided that the fix in this commit addresses ISIS-1668 sufficiently.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 05a6624d797e4b4236e672500e0a5f45cca7f852 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=05a6624 ] ISIS-1668 : only enables prompt if the associated action is visible and enabled. Note that this still leaves ISIS-1670 (view is not dynamic)... but since ISIS-1670 was a problem even for regular editable properties, decided that the fix in this commit addresses ISIS-1668 sufficiently.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 0c6c16d06ec4bd907b045e7d116556b510c7a43d in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=0c6c16d ]

        ISIS-1668: prevents any action annotated as INLINE_AS_IF_EDIT to be shown as a button.

        Previously if the property was itself editable, then the action would be shown as a button. This changes the behaviour so that the action is never rendered as an button.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 0c6c16d06ec4bd907b045e7d116556b510c7a43d in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=0c6c16d ] ISIS-1668 : prevents any action annotated as INLINE_AS_IF_EDIT to be shown as a button. Previously if the property was itself editable, then the action would be shown as a button. This changes the behaviour so that the action is never rendered as an button.

          People

          • Assignee:
            danhaywood Dan Haywood
            Reporter:
            danhaywood Dan Haywood
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development