Uploaded image for project: 'Isis'
  1. Isis
  2. ISIS-1667

Rework ActionParametersPanel so that only rendered if there is a N-arg action ... it isn't used to implicitly invoke an action for a no-arg action.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 1.14.0
    • Fix Version/s: 1.15.0
    • Component/s: Core: Viewer: Wicket
    • Labels:
      None

      Description

      This change required because the previous design was found to be incompatible with Wicket 7.8.0 (investigating with martin-g).

      Note that the upgrade to Wicket 7.8.0 itself has been moved to a different ticket, ISIS-1671, to minimize risk.

        Activity

        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit c12bd95b0aeb0ab6183538d5468f5321eb866295 in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=c12bd95 ]

        ISIS-1667: fixes issue whereby invoking an action twice that had a default would only cause the prompt to appear on the first invocation

        eg downloadMetaModel.

        Issue is this redundant concept of an ActionModel's "mode", either PARAMETERS or RESULTS. This was being set to a stale value. Can simply remove.

        Also:

        • factored out getAction() as a helper.
        Show
        jira-bot ASF subversion and git services added a comment - Commit c12bd95b0aeb0ab6183538d5468f5321eb866295 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=c12bd95 ] ISIS-1667 : fixes issue whereby invoking an action twice that had a default would only cause the prompt to appear on the first invocation eg downloadMetaModel. Issue is this redundant concept of an ActionModel's "mode", either PARAMETERS or RESULTS. This was being set to a stale value. Can simply remove. Also: factored out getAction() as a helper.

          People

          • Assignee:
            danhaywood Dan Haywood
            Reporter:
            danhaywood Dan Haywood
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development