Uploaded image for project: 'Isis'
  1. Isis
  2. ISIS-1654

per-arg validation not fired for enum (ValueChoicesSelect2Panel)

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.15.0
    • Component/s: Core: Viewer: Wicket
    • Labels:
      None

      Activity

      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 07b996759598b9561aae909d188e0f9e1995c4cb in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=07b9967 ]

      ISIS-1654: installs a validator for ValueChoicesSelect2Panel, for per-arg validation. Also...

      also:

      • enables setRequired(...) for same; this is configured in a new addStandardSemantics method (following pattern of other subclasses of SelectPanelAbstract2)
      • enables "closeOnSelect" for a better user experience
      Show
      jira-bot ASF subversion and git services added a comment - Commit 07b996759598b9561aae909d188e0f9e1995c4cb in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=07b9967 ] ISIS-1654 : installs a validator for ValueChoicesSelect2Panel, for per-arg validation. Also... also: enables setRequired(...) for same; this is configured in a new addStandardSemantics method (following pattern of other subclasses of SelectPanelAbstract2) enables "closeOnSelect" for a better user experience
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit d6ec036192d7ad8dcc6b11ea438150b3c44470e9 in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d6ec036 ]

      ISIS-1654: installs a validator for ReferencePanel, for per-arg validation (using select2)...

      and removes the validator that had been there for entityLink.

      Also:

      • added delegate to Select2#add(IValidator) for consistency with other delegate methods
      Show
      jira-bot ASF subversion and git services added a comment - Commit d6ec036192d7ad8dcc6b11ea438150b3c44470e9 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d6ec036 ] ISIS-1654 : installs a validator for ReferencePanel, for per-arg validation (using select2)... and removes the validator that had been there for entityLink. Also: added delegate to Select2#add(IValidator) for consistency with other delegate methods
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 841a0316b32704dacb8ad25e1102d678270cc917 in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=841a031 ]

      ISIS-1654: fixes issue with select2 validator, was not coping with collection parameters (see Select2Validator, inner class of ScalarPanelSelect2Abstract). Also...

      Also:

      • factored out some duplicated code in ReferencePanel and ValueChoicesSelect2Panel, moving up to their superclass (ScalarPanelSelect2Abstract)
      Show
      jira-bot ASF subversion and git services added a comment - Commit 841a0316b32704dacb8ad25e1102d678270cc917 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=841a031 ] ISIS-1654 : fixes issue with select2 validator, was not coping with collection parameters (see Select2Validator, inner class of ScalarPanelSelect2Abstract). Also... Also: factored out some duplicated code in ReferencePanel and ValueChoicesSelect2Panel, moving up to their superclass (ScalarPanelSelect2Abstract)
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 979333f8d1262fb836289133e8a15daccdaac5b5 in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=979333f ]

      ISIS-1654: configures closeOnSelect for collection parameters (SelectMultiChoiceExt), same as for scalar parameters done previously (SelectChoiceExt)

      Show
      jira-bot ASF subversion and git services added a comment - Commit 979333f8d1262fb836289133e8a15daccdaac5b5 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=979333f ] ISIS-1654 : configures closeOnSelect for collection parameters (SelectMultiChoiceExt), same as for scalar parameters done previously (SelectChoiceExt)
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit c94a2400749c155909648aaf28a939a5ab5cb79d in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=c94a240 ]

      ISIS-1654: improves implementation of ObjectAdapterMementoProviderFor... so that they return a simple ArrayList rather than a guava internal class

      This change was made as an initial attempt to fix the validator stack trace (which was eventually fixed by way of the implementation in Select2Validator); but have decided to keep in these changes, since makes code more consistent.

      Show
      jira-bot ASF subversion and git services added a comment - Commit c94a2400749c155909648aaf28a939a5ab5cb79d in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=c94a240 ] ISIS-1654 : improves implementation of ObjectAdapterMementoProviderFor... so that they return a simple ArrayList rather than a guava internal class This change was made as an initial attempt to fix the validator stack trace (which was eventually fixed by way of the implementation in Select2Validator); but have decided to keep in these changes, since makes code more consistent.

        People

        • Assignee:
          danhaywood Dan Haywood
          Reporter:
          danhaywood Dan Haywood
        • Votes:
          0 Vote for this issue
          Watchers:
          2 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development