Uploaded image for project: 'Isis'
  1. Isis
  2. ISIS-1647

Hitting escape twice for modal dialogs causes a stack trace

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.15.0
    • Component/s: Core: Viewer: Wicket
    • Labels:
      None

      Description

      introduced as a problem during the inline edit stuff

        Activity

        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit d3f77018bcfcf1e37d7d6a645c2f15f90c543713 in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d3f7701 ]

        ISIS-1647: bumps to wicket 7.8.0

        nb: fix to compile issue ... wicketstuff not quite backwardly compatible

        Show
        jira-bot ASF subversion and git services added a comment - Commit d3f77018bcfcf1e37d7d6a645c2f15f90c543713 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d3f7701 ] ISIS-1647 : bumps to wicket 7.8.0 nb: fix to compile issue ... wicketstuff not quite backwardly compatible
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 75cac4fe5a9972a7e09372eb65204661b184ede7 in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=75cac4f ]

        ISIS-1647: fixes the issue by making derivation of promptStyle for an action model more intelligent (recognise if modal by virtue of its owner).

        Show
        jira-bot ASF subversion and git services added a comment - Commit 75cac4fe5a9972a7e09372eb65204661b184ede7 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=75cac4f ] ISIS-1647 : fixes the issue by making derivation of promptStyle for an action model more intelligent (recognise if modal by virtue of its owner).
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit be101631474062e1b02960febb0d9e478920a3c6 in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=be10163 ]

        ISIS-1647: just renames PromptStyleFacetFallback to PromptStyleFacetFallbackToInline so easier to reason about

        Show
        jira-bot ASF subversion and git services added a comment - Commit be101631474062e1b02960febb0d9e478920a3c6 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=be10163 ] ISIS-1647 : just renames PromptStyleFacetFallback to PromptStyleFacetFallbackToInline so easier to reason about
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 97d2152b21fff9c6b1621177980b79d109aa3731 in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=97d2152 ]

        ISIS-1647: cosmetic - use fade-in for modal dialogs, looks a bit prettier

        Show
        jira-bot ASF subversion and git services added a comment - Commit 97d2152b21fff9c6b1621177980b79d109aa3731 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=97d2152 ] ISIS-1647 : cosmetic - use fade-in for modal dialogs, looks a bit prettier
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit c3cc2db64ac40641f10f877f04e3bc645f69dce0 in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=c3cc2db ]

        ISIS-1647: reverts the use of fade-in for modal dialogs (because breaks the javascript to automatically put the focus on the first parameter of the dialog)

        Show
        jira-bot ASF subversion and git services added a comment - Commit c3cc2db64ac40641f10f877f04e3bc645f69dce0 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=c3cc2db ] ISIS-1647 : reverts the use of fade-in for modal dialogs (because breaks the javascript to automatically put the focus on the first parameter of the dialog)
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 333a209eb41a20f1313a4ac989efce433c60c102 in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=333a209 ]

        Revert "ISIS-1647: bumps to wicket 7.8.0"

        This reverts commit d3f77018bcfcf1e37d7d6a645c2f15f90c543713.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 333a209eb41a20f1313a4ac989efce433c60c102 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=333a209 ] Revert " ISIS-1647 : bumps to wicket 7.8.0" This reverts commit d3f77018bcfcf1e37d7d6a645c2f15f90c543713.
        Hide
        mgrigorov Martin Grigorov added a comment -

        What is the issue with Wicket(Stuff) 7.8.0 ?
        I saw that you replaced JSONWriter with JSONStringer. Are there other problems ?

        Show
        mgrigorov Martin Grigorov added a comment - What is the issue with Wicket(Stuff) 7.8.0 ? I saw that you replaced JSONWriter with JSONStringer. Are there other problems ?
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 8acad81404d420814e1c7f15da77d396952e2d84 in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=8acad81 ]

        Revert "Revert "Revert "ISIS-1647: bumps to wicket 7.8.0"""

        This reverts commit 86e87403fa15212d7dfd0b70bc8618959ce0b8f4.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 8acad81404d420814e1c7f15da77d396952e2d84 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=8acad81 ] Revert "Revert "Revert " ISIS-1647 : bumps to wicket 7.8.0""" This reverts commit 86e87403fa15212d7dfd0b70bc8618959ce0b8f4.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 76c92a47270c139c15481177e94207ae7e56c9ff in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=76c92a4 ]

        ISIS-1647: bumps to wicket 7.8.0

        nb: fix to compile issue ... wicketstuff not quite backwardly compatible

        Show
        jira-bot ASF subversion and git services added a comment - Commit 76c92a47270c139c15481177e94207ae7e56c9ff in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=76c92a4 ] ISIS-1647 : bumps to wicket 7.8.0 nb: fix to compile issue ... wicketstuff not quite backwardly compatible

          People

          • Assignee:
            danhaywood Dan Haywood
            Reporter:
            danhaywood Dan Haywood
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development