[ISIS-1637] [WON'T FIX] Non-JAXB view models do not support editable properties

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Won't Fix
• Affects Version/s: 1.14.0
• Fix Version/s: 1.17.0
• Assignee: Unassigned
• Reporter: Daniel Keir Haywood
• Created: 16/Jun/17 05:59
• Updated: 06/Jan/19 12:10
• Resolved: 06/Jan/19 12:10

Description

this is the case irrespective of whether editing is disabled globally using the isis.objects.editing=false)

background:

see https://stackoverflow.com/questions/44569302/apache-isis-propertyediting-editing-enabled-doesnt-work-for-viewmodels

analysis:

@Property(editing=ENABLED)
this installs:
DisabledFacetForPropertyAnnotationInvertedSemantics[interaction=Disabling,type=DisabledFacet,when=Always; where =Everywhere]

then see @DomainObject(nature=VIEW_MODEL)
DisabledFacetOnPropertyDerivedFromRecreatableObject[interaction=Disabling,type=DisabledFacet,when=Always; where =Anywhere]
this overwrites:

final Facet existingFacet = getFacet(facetType);
if (existingFacet == null || existingFacet.isNoop())

{ facetsByClass.put(facetType, facet); return; }

if (!facet.alwaysReplace())

{ return; }

if (facet.isDerived() && !existingFacet.isDerived())

{ << doesn't return here, for example return; }

facet.setUnderlyingFacet(existingFacet);
facetsByClass.put(facetType, facet);

then at the class level earlier would also have installed ImmutableFacet because of configuration property (if global property to disable editing)
because of that, see:
DisabledFacetOnPropertyDerivedFromImmutable[interaction=Disabling,type=DisabledFacet,when=Always; where =Anywhere]
this overwrites once more.