Uploaded image for project: 'Isis'
  1. Isis
  2. ISIS-1630

view models with inline prompts don't show which fields are mandatory or not.

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.15.0
    • Component/s: Core: Viewer: Wicket
    • Labels:
      None

      Activity

      Hide
      danhaywood Dan Haywood added a comment -

      hmm, this might've been fixed by now...

      Show
      danhaywood Dan Haywood added a comment - hmm, this might've been fixed by now...
      Hide
      danhaywood Dan Haywood added a comment -

      it wasn't.

      Show
      danhaywood Dan Haywood added a comment - it wasn't.
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 1eda9bd40ba02b938b4f82cf340ba8dad5d7dd73 in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=1eda9bd ]

      ISIS-1630: no longer installs DN/JDO facets on view models (or rather, any object that isn't an entity).

      The issue as originally described was the result of the MandatoryFromJdoColumnAnnotationFacetFactory being installed, with the MandatoryFacet with inverted semantics (due to absence of @Column) trashing the original MandatoryFacetDefault that was already there. The fix is to simply ignore the facet factory for

      The other facet factories pertaining only to DN entities have also been updated in same way.

      Show
      jira-bot ASF subversion and git services added a comment - Commit 1eda9bd40ba02b938b4f82cf340ba8dad5d7dd73 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=1eda9bd ] ISIS-1630 : no longer installs DN/JDO facets on view models (or rather, any object that isn't an entity). The issue as originally described was the result of the MandatoryFromJdoColumnAnnotationFacetFactory being installed, with the MandatoryFacet with inverted semantics (due to absence of @Column) trashing the original MandatoryFacetDefault that was already there. The fix is to simply ignore the facet factory for The other facet factories pertaining only to DN entities have also been updated in same way.
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit d68fe2e2a8909a805c53e63c02103082601cccd3 in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d68fe2e ]

      ISIS-1630: fixes up unit tests

      Show
      jira-bot ASF subversion and git services added a comment - Commit d68fe2e2a8909a805c53e63c02103082601cccd3 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d68fe2e ] ISIS-1630 : fixes up unit tests

        People

        • Assignee:
          danhaywood Dan Haywood
          Reporter:
          danhaywood Dan Haywood
        • Votes:
          0 Vote for this issue
          Watchers:
          2 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development