Uploaded image for project: 'Isis'
  1. Isis
  2. ISIS-1626

Confirmation Dialog not shown on no-parameter Menu Actions

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.14.0
    • Fix Version/s: 1.15.0
    • Component/s: Core: Viewer: Wicket
    • Labels:
      None

      Description

      No-Parameter Menu Actions annotated with any of the 'ARE_YOU_SURE' semantics will not produce the expected confirmation dialog when you click on the corresponding menu item.

      SimpleObjectMenu.java
      @Action(semantics = SemanticsOf.NON_IDEMPOTENT_ARE_YOU_SURE) 
      public List<SimpleObject> test() {
              return simpleObjectRepository.listAll();
      }
      

      Steps to reproduce:
      Take the simple-app artifact 1.14 and add the test snipped from above to the SimpleObjectMenu.

        Activity

        Hide
        hobrom Andi Huber added a comment - - edited
        Show
        hobrom Andi Huber added a comment - - edited Fixed with PR #81 https://github.com/apache/isis/pull/81
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit ba2d4ed7edf8a091281dced77b6044b93c2fc4e2 in isis's branch refs/heads/master from Andi Huber
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=ba2d4ed ]

        Patchset to fix

        • ISIS-1625, tooltips for menu actions
        • ISIS-1626, confirmation dialog for no-parameter menu actions
        Show
        jira-bot ASF subversion and git services added a comment - Commit ba2d4ed7edf8a091281dced77b6044b93c2fc4e2 in isis's branch refs/heads/master from Andi Huber [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=ba2d4ed ] Patchset to fix ISIS-1625 , tooltips for menu actions ISIS-1626 , confirmation dialog for no-parameter menu actions
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1429ef7a19c2dcd6ce4032e3dc6983b9dec45080 in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=1429ef7 ]

        Merge branch 'master' of https://github.com/hobrom/isis into ISIS-1626_pr-81

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1429ef7a19c2dcd6ce4032e3dc6983b9dec45080 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=1429ef7 ] Merge branch 'master' of https://github.com/hobrom/isis into ISIS-1626 _pr-81
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 6a87cd40d626a27e9db21c97af9b69aed5e020d2 in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=6a87cd4 ]

        Merge branch 'ISIS-1626_pr-81'

        Show
        jira-bot ASF subversion and git services added a comment - Commit 6a87cd40d626a27e9db21c97af9b69aed5e020d2 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=6a87cd4 ] Merge branch ' ISIS-1626 _pr-81'

          People

          • Assignee:
            danhaywood Dan Haywood
            Reporter:
            hobrom Andi Huber
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development