Uploaded image for project: 'Isis'
  1. Isis
  2. ISIS-1613

On action invoke/property edit, don't reload page, just repaint changed components (and allow unchanged components to opt out).

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.14.0
    • Fix Version/s: 1.15.0
    • Component/s: Core, Core: Viewer: Wicket
    • Labels:
      None

      Activity

      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 6284eaae3073968a1f1c72748c19d938bb3de3fe in isis's branch refs/heads/ISIS-1613 from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=6284eaa ]

      ISIS-1613: stuff

      Show
      jira-bot ASF subversion and git services added a comment - Commit 6284eaae3073968a1f1c72748c19d938bb3de3fe in isis's branch refs/heads/ ISIS-1613 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=6284eaa ] ISIS-1613 : stuff
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 054e07c0b217fc81a41360a6964868cf30ad245e in isis's branch refs/heads/ISIS-1613 from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=054e07c ]

      ISIS-1613: stuff

      Show
      jira-bot ASF subversion and git services added a comment - Commit 054e07c0b217fc81a41360a6964868cf30ad245e in isis's branch refs/heads/ ISIS-1613 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=054e07c ] ISIS-1613 : stuff
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 199428bc1f00476fe04f2b32a643a50df475560e in isis's branch refs/heads/ISIS-1613 from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=199428b ]

      ISIS-1613: refactors to reuse EntityModel so far as possible

      • ActionModel accepts an EntityModel rather than an underlying ObjectAdapter
      • HomePage updated to construct ActionModel passing an EntityModel for the target
      • ScalarModel accepts an EntityModel rather than an ObjectAdapterMemento, and exposes parentEntityModel rather than parentObjectAdapterMemento
      • to obtain the adapter (eg for disable checks), can use getParentEntityModel().load(...) rather than getParentObjectAdapterMemento().getObjectAdapter(ConcurrencyChecking.CHECK, ..., ...)
      • ActionLinkFactory's API simplified, no longer need to pass in an ObjectAdapterMemento
      • instead subclasses of ActionLinkFactoryAbstract now holds the entityModel as a field
      • ServiceActionLinkFactory is now stateful rather than a singleton, an instance wraps each service item exposed in UI (same design as for domain entities, ie EntityActionLinkFactory)
      • CssMenuItem no longer passes through adapterMemento when calling newLink
      • and some refactorings in it and ServiceActionUtil to simplify
      • renamed ServiceActionUtil.LogicalServiceAction to ServiceAndAction, made top-level class
      • StandaloneCollectionPanel ditto no longer passes null through for the entity model to its (Bulk)ActionLinkFactory
      • LinkAndLabelUtil reuses the scalarModel's parent EntityModel rather than creating a new one
      • PropertyEditPanel uses ScalarModel#getParentEntityModel where possible
      • ditto PropertyEditPromptHeaderPanel
      • ditto ScalarPanelAbstract
      • ditto ScalarPanelAbstract2
      Show
      jira-bot ASF subversion and git services added a comment - Commit 199428bc1f00476fe04f2b32a643a50df475560e in isis's branch refs/heads/ ISIS-1613 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=199428b ] ISIS-1613 : refactors to reuse EntityModel so far as possible ActionModel accepts an EntityModel rather than an underlying ObjectAdapter HomePage updated to construct ActionModel passing an EntityModel for the target ScalarModel accepts an EntityModel rather than an ObjectAdapterMemento, and exposes parentEntityModel rather than parentObjectAdapterMemento to obtain the adapter (eg for disable checks), can use getParentEntityModel().load(...) rather than getParentObjectAdapterMemento().getObjectAdapter(ConcurrencyChecking.CHECK, ..., ...) ActionLinkFactory's API simplified, no longer need to pass in an ObjectAdapterMemento instead subclasses of ActionLinkFactoryAbstract now holds the entityModel as a field ServiceActionLinkFactory is now stateful rather than a singleton, an instance wraps each service item exposed in UI (same design as for domain entities, ie EntityActionLinkFactory) CssMenuItem no longer passes through adapterMemento when calling newLink and some refactorings in it and ServiceActionUtil to simplify renamed ServiceActionUtil.LogicalServiceAction to ServiceAndAction, made top-level class StandaloneCollectionPanel ditto no longer passes null through for the entity model to its (Bulk)ActionLinkFactory LinkAndLabelUtil reuses the scalarModel's parent EntityModel rather than creating a new one PropertyEditPanel uses ScalarModel#getParentEntityModel where possible ditto PropertyEditPromptHeaderPanel ditto ScalarPanelAbstract ditto ScalarPanelAbstract2
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit a5c8f286964839f920826af16d57f786e56d922b in isis's branch refs/heads/ISIS-1613 from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=a5c8f28 ]

      ISIS-1613: updates ScalarPanelAbstract2 to move the initialization into onInitialize rather than onBeforeRender.

      Also renames the hooks

      Show
      jira-bot ASF subversion and git services added a comment - Commit a5c8f286964839f920826af16d57f786e56d922b in isis's branch refs/heads/ ISIS-1613 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=a5c8f28 ] ISIS-1613 : updates ScalarPanelAbstract2 to move the initialization into onInitialize rather than onBeforeRender. Also renames the hooks
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 7cad26fd376501c882e2f5cc93b71c15c4a2b57f in isis's branch refs/heads/ISIS-1613 from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=7cad26f ]

      ISIS-1613: removes the commented out code for disabling concurrency checking that lives in ScalarPanelAbstract2's onInitialize

      Show
      jira-bot ASF subversion and git services added a comment - Commit 7cad26fd376501c882e2f5cc93b71c15c4a2b57f in isis's branch refs/heads/ ISIS-1613 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=7cad26f ] ISIS-1613 : removes the commented out code for disabling concurrency checking that lives in ScalarPanelAbstract2's onInitialize
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 00cb22833e945ac9340170d009a940984357ecf7 in isis's branch refs/heads/ISIS-1613 from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=00cb228 ]

      ISIS-1613: comments out debug statements

      Show
      jira-bot ASF subversion and git services added a comment - Commit 00cb22833e945ac9340170d009a940984357ecf7 in isis's branch refs/heads/ ISIS-1613 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=00cb228 ] ISIS-1613 : comments out debug statements
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 0d81e11abe981a71d86caa9cb6228bce82edac81 in isis's branch refs/heads/ISIS-1613 from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=0d81e11 ]

      ISIS-1613: refactors the ActionParameters and PropertyEdit forms and panels

      • moves FormExecutorAbstract to panels package (out of a package specific to property)
      • moves PromptFormAbstract (renamed from FormAbstract) out of PromptFormPanelAbstract
      • moves ActionParametersForm and PropertyEditForm to top-level classes
      • move addConfirmationDialogIfAreYouSureSemantics to a static utility method in PanelUtil so can be reused
      • renames ActionPanelFactory to ActionInfoPanelFactory
      • removes some unused code from ScalarPanelAbstract
      Show
      jira-bot ASF subversion and git services added a comment - Commit 0d81e11abe981a71d86caa9cb6228bce82edac81 in isis's branch refs/heads/ ISIS-1613 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=0d81e11 ] ISIS-1613 : refactors the ActionParameters and PropertyEdit forms and panels moves FormExecutorAbstract to panels package (out of a package specific to property) moves PromptFormAbstract (renamed from FormAbstract) out of PromptFormPanelAbstract moves ActionParametersForm and PropertyEditForm to top-level classes move addConfirmationDialogIfAreYouSureSemantics to a static utility method in PanelUtil so can be reused renames ActionPanelFactory to ActionInfoPanelFactory removes some unused code from ScalarPanelAbstract
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 82ad34ba3d4409a67358af24f0a4fcfe91688703 in isis's branch refs/heads/ISIS-1613 from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=82ad34b ]

      ISIS-1613: removes use of MessageBroker, use MessageService instead.

      Show
      jira-bot ASF subversion and git services added a comment - Commit 82ad34ba3d4409a67358af24f0a4fcfe91688703 in isis's branch refs/heads/ ISIS-1613 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=82ad34b ] ISIS-1613 : removes use of MessageBroker, use MessageService instead.
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit feb44ca9d17ec9798e00085ded0c649070a18f84 in isis's branch refs/heads/ISIS-1613 from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=feb44ca ]

      ISIS-1613: adds missing import for previous commit

      Show
      jira-bot ASF subversion and git services added a comment - Commit feb44ca9d17ec9798e00085ded0c649070a18f84 in isis's branch refs/heads/ ISIS-1613 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=feb44ca ] ISIS-1613 : adds missing import for previous commit
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit c1323ca51453fd51507b0a52057ef3b8071facd4 in isis's branch refs/heads/ISIS-1613 from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=c1323ca ]

      ISIS-1613: removes need to pass a MarkupContainer (panel) through to FormExecutor(Abstract)

      Show
      jira-bot ASF subversion and git services added a comment - Commit c1323ca51453fd51507b0a52057ef3b8071facd4 in isis's branch refs/heads/ ISIS-1613 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=c1323ca ] ISIS-1613 : removes need to pass a MarkupContainer (panel) through to FormExecutor(Abstract)
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit cfb206716b353234c3d5d4c7888e472456f6d794 in isis's branch refs/heads/ISIS-1613 from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=cfb2067 ]

      ISIS-1613: ensures that ScalarModel and ActionModel have a FormExecutor assigned to them as soon as created.

      Also removes commented out code from previous commit.

      Show
      jira-bot ASF subversion and git services added a comment - Commit cfb206716b353234c3d5d4c7888e472456f6d794 in isis's branch refs/heads/ ISIS-1613 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=cfb2067 ] ISIS-1613 : ensures that ScalarModel and ActionModel have a FormExecutor assigned to them as soon as created. Also removes commented out code from previous commit.
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 3ff8f7a82a579024b72f1bcaead6708424ae4e33 in isis's branch refs/heads/ISIS-1613 from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=3ff8f7a ]

      ISIS-1613: concurrency handling now seems to be working, more or less. More testing required.

      • backs out the DisableConcurrencyCheckingOnRenderListener from IsisWicketApplication
      • instead use EntityPage on {Before/After}

        Render hooks

      • use EntityModel#resetPropertyModels to reset version
      • no longer clear propertyScalarModels on detach, so can iterate over
      • do this in FormExecutorAbstract, rather than PromptFormAbstract
      • EntityModelWithLayoutHints introduced as wrapper around EntityModel, to avoid aliasing issues with resetting version on the "main" EntityModel
      • use model.getParentEntityModel for action models in a couple of further places (ActionPromptHeaderPanel, ActionParametersPanel)
      • similarly, reuse EntityModel in EntityLinkSimplePanel rather than create its own EntityModel

      also:

      • change PageAbstract#getUiHintContainerIfAny(), return a UiHintContainer once more (rather than EntityModel) since no need to return the more specific class
      Show
      jira-bot ASF subversion and git services added a comment - Commit 3ff8f7a82a579024b72f1bcaead6708424ae4e33 in isis's branch refs/heads/ ISIS-1613 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=3ff8f7a ] ISIS-1613 : concurrency handling now seems to be working, more or less. More testing required. backs out the DisableConcurrencyCheckingOnRenderListener from IsisWicketApplication instead use EntityPage on {Before/After} Render hooks use EntityModel#resetPropertyModels to reset version no longer clear propertyScalarModels on detach, so can iterate over do this in FormExecutorAbstract, rather than PromptFormAbstract EntityModelWithLayoutHints introduced as wrapper around EntityModel, to avoid aliasing issues with resetting version on the "main" EntityModel use model.getParentEntityModel for action models in a couple of further places (ActionPromptHeaderPanel, ActionParametersPanel) similarly, reuse EntityModel in EntityLinkSimplePanel rather than create its own EntityModel also: change PageAbstract#getUiHintContainerIfAny(), return a UiHintContainer once more (rather than EntityModel) since no need to return the more specific class
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 9841680edee73869dc77f6b664c1a5d7dc1f9be7 in isis's branch refs/heads/ISIS-1613 from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=9841680 ]

      ISIS-1613: deletes commented-out code

      Show
      jira-bot ASF subversion and git services added a comment - Commit 9841680edee73869dc77f6b664c1a5d7dc1f9be7 in isis's branch refs/heads/ ISIS-1613 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=9841680 ] ISIS-1613 : deletes commented-out code
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 5733809b08d57a02be1b3aa54552b393122ad6fe in isis's branch refs/heads/ISIS-1613 from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=5733809 ]

      ISIS-1613: introduces new setting 'isis.viewer.wicket.redirectEvenIfSameObject'

      so can revert to previous behaviour if required.

      Show
      jira-bot ASF subversion and git services added a comment - Commit 5733809b08d57a02be1b3aa54552b393122ad6fe in isis's branch refs/heads/ ISIS-1613 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=5733809 ] ISIS-1613 : introduces new setting 'isis.viewer.wicket.redirectEvenIfSameObject' so can revert to previous behaviour if required.
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 0d79db9706c16ff6ba28a0e6279ba0ca2b00b2a7 in isis's branch refs/heads/ISIS-1613 from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=0d79db9 ]

      ISIS-1613: fixes boolean inline link text when modified

      Show
      jira-bot ASF subversion and git services added a comment - Commit 0d79db9706c16ff6ba28a0e6279ba0ca2b00b2a7 in isis's branch refs/heads/ ISIS-1613 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=0d79db9 ] ISIS-1613 : fixes boolean inline link text when modified
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 0da818bb6bdd701ed29da53d7c8506b81d7d1044 in isis's branch refs/heads/ISIS-1613 from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=0da818b ]

      ISIS-1613: fixes no-arg actions, was hitting an NPE

      ... as the result of attempting to infer the current page from feedbackForm (that was null when no prompt).

      Instead, have the FormExecutor ask for the page via its method (executeAndProcessResults).

      This in turn requires building ActionParametersPanel's GUI using onInitialize() rather than constructor, so able to get hold of the panel's owning page so can pass down to the FormExecutor

      Show
      jira-bot ASF subversion and git services added a comment - Commit 0da818bb6bdd701ed29da53d7c8506b81d7d1044 in isis's branch refs/heads/ ISIS-1613 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=0da818b ] ISIS-1613 : fixes no-arg actions, was hitting an NPE ... as the result of attempting to infer the current page from feedbackForm (that was null when no prompt). Instead, have the FormExecutor ask for the page via its method (executeAndProcessResults). This in turn requires building ActionParametersPanel's GUI using onInitialize() rather than constructor, so able to get hold of the panel's owning page so can pass down to the FormExecutor
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 295e67f4d31425cb1af98a10716b206948cd3cc0 in isis's branch refs/heads/ISIS-1613 from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=295e67f ]

      ISIS-1613: fixes NPE with bulk actions

      which was resulting from the actionModel hint, which holds the action to invoke to recreate the list of domain objects, was caching its results and so was returning a list of stale pojos that were implicitly detached and therefore mapped as transient.

      Fix was simply to invalidate this cached return result by invalidating the actionModel.

      Show
      jira-bot ASF subversion and git services added a comment - Commit 295e67f4d31425cb1af98a10716b206948cd3cc0 in isis's branch refs/heads/ ISIS-1613 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=295e67f ] ISIS-1613 : fixes NPE with bulk actions which was resulting from the actionModel hint, which holds the action to invoke to recreate the list of domain objects, was caching its results and so was returning a list of stale pojos that were implicitly detached and therefore mapped as transient. Fix was simply to invalidate this cached return result by invalidating the actionModel.
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit de39ef6c66e8461c0fa1e827e8553578d3b8cefd in isis's branch refs/heads/ISIS-1613 from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=de39ef6 ]

      ISIS-1613: workaround for fact that blobs/clobs do not correctly repaint.

      For these, force a redraw by just forwarding to page

      Show
      jira-bot ASF subversion and git services added a comment - Commit de39ef6c66e8461c0fa1e827e8553578d3b8cefd in isis's branch refs/heads/ ISIS-1613 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=de39ef6 ] ISIS-1613 : workaround for fact that blobs/clobs do not correctly repaint. For these, force a redraw by just forwarding to page
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 221047c7db332affbabbfee34e06a86e4bd39243 in isis's branch refs/heads/ISIS-1613 from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=221047c ]

      ISIS-1613: comment out call to isisShowVeil...

      ... throwing a Javascript error, and may not be needed anyway with the new design

      Show
      jira-bot ASF subversion and git services added a comment - Commit 221047c7db332affbabbfee34e06a86e4bd39243 in isis's branch refs/heads/ ISIS-1613 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=221047c ] ISIS-1613 : comment out call to isisShowVeil... ... throwing a Javascript error, and may not be needed anyway with the new design
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 5a3e972363d1ecb7328c18559cfa0d7bb4de5b8a in isis's branch refs/heads/ISIS-1613 from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=5a3e972 ]

      ISIS-1613: fixes all-arg validation for actions.

      If the all-args validation failed for an action, the error was not being shown (ie validateSomeAction vs validate0SomeAction).

      Show
      jira-bot ASF subversion and git services added a comment - Commit 5a3e972363d1ecb7328c18559cfa0d7bb4de5b8a in isis's branch refs/heads/ ISIS-1613 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=5a3e972 ] ISIS-1613 : fixes all-arg validation for actions. If the all-args validation failed for an action, the error was not being shown (ie validateSomeAction vs validate0SomeAction).
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit fa9cfbdf34bbdea9a390411d4cea39ca258562ca in isis's branch refs/heads/ISIS-1613 from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=fa9cfbd ]

      ISIS-1613: fixes bug whereby action prompt (for dialog) was being hidden even if there was an N-arg validation error

      Also refactors code slightly, make it easier to follow

      Show
      jira-bot ASF subversion and git services added a comment - Commit fa9cfbdf34bbdea9a390411d4cea39ca258562ca in isis's branch refs/heads/ ISIS-1613 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=fa9cfbd ] ISIS-1613 : fixes bug whereby action prompt (for dialog) was being hidden even if there was an N-arg validation error Also refactors code slightly, make it easier to follow
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 6c3be0976c4df56defa5230cecb9b2c41658759e in isis's branch refs/heads/ISIS-1613 from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=6c3be09 ]

      ISIS-1613: minor fixes to CSS, remove the heavy focus indicator that had been introduced while debugging tabbing

      Show
      jira-bot ASF subversion and git services added a comment - Commit 6c3be0976c4df56defa5230cecb9b2c41658759e in isis's branch refs/heads/ ISIS-1613 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=6c3be09 ] ISIS-1613 : minor fixes to CSS, remove the heavy focus indicator that had been introduced while debugging tabbing
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 0b15b14c73c15ab7f66d19601eede90f7a430c46 in isis's branch refs/heads/ISIS-1613 from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=0b15b14 ]

      ISIS-1613: attempts to (though fails) to prevent XmlPartialPageUpdate from emitting lots of WARN messages to log

      Show
      jira-bot ASF subversion and git services added a comment - Commit 0b15b14c73c15ab7f66d19601eede90f7a430c46 in isis's branch refs/heads/ ISIS-1613 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=0b15b14 ] ISIS-1613 : attempts to (though fails) to prevent XmlPartialPageUpdate from emitting lots of WARN messages to log
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 5a3e972363d1ecb7328c18559cfa0d7bb4de5b8a in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=5a3e972 ]

      ISIS-1613: fixes all-arg validation for actions.

      If the all-args validation failed for an action, the error was not being shown (ie validateSomeAction vs validate0SomeAction).

      Show
      jira-bot ASF subversion and git services added a comment - Commit 5a3e972363d1ecb7328c18559cfa0d7bb4de5b8a in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=5a3e972 ] ISIS-1613 : fixes all-arg validation for actions. If the all-args validation failed for an action, the error was not being shown (ie validateSomeAction vs validate0SomeAction).
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit fa9cfbdf34bbdea9a390411d4cea39ca258562ca in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=fa9cfbd ]

      ISIS-1613: fixes bug whereby action prompt (for dialog) was being hidden even if there was an N-arg validation error

      Also refactors code slightly, make it easier to follow

      Show
      jira-bot ASF subversion and git services added a comment - Commit fa9cfbdf34bbdea9a390411d4cea39ca258562ca in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=fa9cfbd ] ISIS-1613 : fixes bug whereby action prompt (for dialog) was being hidden even if there was an N-arg validation error Also refactors code slightly, make it easier to follow
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 0b15b14c73c15ab7f66d19601eede90f7a430c46 in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=0b15b14 ]

      ISIS-1613: attempts to (though fails) to prevent XmlPartialPageUpdate from emitting lots of WARN messages to log

      Show
      jira-bot ASF subversion and git services added a comment - Commit 0b15b14c73c15ab7f66d19601eede90f7a430c46 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=0b15b14 ] ISIS-1613 : attempts to (though fails) to prevent XmlPartialPageUpdate from emitting lots of WARN messages to log
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit dc88eea66f6b20c2c2d49f53fda6274dff774a37 in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=dc88eea ]

      Merge branch 'ISIS-1613'

      Show
      jira-bot ASF subversion and git services added a comment - Commit dc88eea66f6b20c2c2d49f53fda6274dff774a37 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=dc88eea ] Merge branch ' ISIS-1613 '
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 9f30498186e3628bbc9df18d335e94a00138d4e0 in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=9f30498 ]

      ISIS-1613: simplifies EntityModel w.r.t layout metadata

      Hitting aliasing issues/inconsistency within ActionModel for getTargetAdapter vs getParentEntityModel().load(...). The ActionModel was referencing an EntityModelWithLayoutHints, and think that there are aliasing issues (this wrapper has its own cache of pojo adapters, and was out of sync with the underlying).

      Seems to have sorted out the issue....

      Show
      jira-bot ASF subversion and git services added a comment - Commit 9f30498186e3628bbc9df18d335e94a00138d4e0 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=9f30498 ] ISIS-1613 : simplifies EntityModel w.r.t layout metadata Hitting aliasing issues/inconsistency within ActionModel for getTargetAdapter vs getParentEntityModel().load(...). The ActionModel was referencing an EntityModelWithLayoutHints, and think that there are aliasing issues (this wrapper has its own cache of pojo adapters, and was out of sync with the underlying). Seems to have sorted out the issue....
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 3b85e88f178fc7ca2b21b2f0f687285bc59c919c in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=3b85e88 ]

      ISIS-1613: ensures changes applied correctly for view models (if reusing page)

      Also:

      • ensure that the date fields always show the correct value (make the model live, not a snapshot)
      • similar change for button's disabled text, though only partly implemented.
      Show
      jira-bot ASF subversion and git services added a comment - Commit 3b85e88f178fc7ca2b21b2f0f687285bc59c919c in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=3b85e88 ] ISIS-1613 : ensures changes applied correctly for view models (if reusing page) Also: ensure that the date fields always show the correct value (make the model live, not a snapshot) similar change for button's disabled text, though only partly implemented.
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 34f7b37c99a57c891036a81c48fd6e001cb94bcf in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=34f7b37 ]

      ISIS-1613: refactors LinkAndLabel, with new ActionLink implementation of AjaxLink to dynamically evaluate action disablement

      Show
      jira-bot ASF subversion and git services added a comment - Commit 34f7b37c99a57c891036a81c48fd6e001cb94bcf in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=34f7b37 ] ISIS-1613 : refactors LinkAndLabel, with new ActionLink implementation of AjaxLink to dynamically evaluate action disablement
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 81b017e6711cbfbe80a5e3d1ad6e30ed17d52d1b in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=81b017e ]

      ISIS-1613: handles invoking an action that returns a deleted object

      Show
      jira-bot ASF subversion and git services added a comment - Commit 81b017e6711cbfbe80a5e3d1ad6e30ed17d52d1b in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=81b017e ] ISIS-1613 : handles invoking an action that returns a deleted object
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit fd769b2d4977aaee4a9638fbcaaf90123ac16f4e in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=fd769b2 ]

      ISIS-1613: fixes issue whereby non-editable references were being rendered as editable.

      Also:

      • made the debug(...) method be a logged call
      • removed some unused code
      Show
      jira-bot ASF subversion and git services added a comment - Commit fd769b2d4977aaee4a9638fbcaaf90123ac16f4e in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=fd769b2 ] ISIS-1613 : fixes issue whereby non-editable references were being rendered as editable. Also: made the debug(...) method be a logged call removed some unused code
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 320d5530d937116bbde5b30e5eef5facde1a1eb2 in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=320d553 ]

      ISIS-1613: refactors the way that errors are caught and handled

      Show
      jira-bot ASF subversion and git services added a comment - Commit 320d5530d937116bbde5b30e5eef5facde1a1eb2 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=320d553 ] ISIS-1613 : refactors the way that errors are caught and handled
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 337182119979eebfdc01e44562a1de63a6bc7d92 in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=3371821 ]

      ISIS-1613: tidies up/simplifies some of the exception handling code, and improves the detection of concurrency exceptions.

      Show
      jira-bot ASF subversion and git services added a comment - Commit 337182119979eebfdc01e44562a1de63a6bc7d92 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=3371821 ] ISIS-1613 : tidies up/simplifies some of the exception handling code, and improves the detection of concurrency exceptions.
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 375021d7ee0567e5ecd3593edbd23acd9759f6cd in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=375021d ]

      ISIS-1613: fixes algorithm for showing inline prompt for reference panels when editable vs not editable.

      Show
      jira-bot ASF subversion and git services added a comment - Commit 375021d7ee0567e5ecd3593edbd23acd9759f6cd in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=375021d ] ISIS-1613 : fixes algorithm for showing inline prompt for reference panels when editable vs not editable.
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 9ae905857df9009d8eb63e972e8ae6153545cc33 in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=9ae9058 ]

      ISIS-1613: changes which element 'form-control input-sm' CSS classes are applied on the inline prompt link

      for MultiLineString (a > textarea) vs others (a > span). This allows the tabbing highlighter to be correctly shown.

      Show
      jira-bot ASF subversion and git services added a comment - Commit 9ae905857df9009d8eb63e972e8ae6153545cc33 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=9ae9058 ] ISIS-1613 : changes which element 'form-control input-sm' CSS classes are applied on the inline prompt link for MultiLineString (a > textarea) vs others (a > span). This allows the tabbing highlighter to be correctly shown.
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 6d826cebb8a5d95362ce939edf472cab04f62860 in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=6d826ce ]

      ISIS-1613: makes the inline prompt model for BigDecimal panel (ie numeric) fields dynamic

      So that they are updated whenever the domain object is updated

      Show
      jira-bot ASF subversion and git services added a comment - Commit 6d826cebb8a5d95362ce939edf472cab04f62860 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=6d826ce ] ISIS-1613 : makes the inline prompt model for BigDecimal panel (ie numeric) fields dynamic So that they are updated whenever the domain object is updated
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 46557889f5b6a066425d8e1f2c97bf5fed4dff80 in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=4655788 ]

      ISIS-1613: action buttons visibility is now dynamic.

      To support this requires a minor adjustment to CSS, because the button's outer <li> element is always rendered, even if the content is then invisible.

      Also moved some responsibilities from ActionLinkFactoryAbstract directly into ActionLink (the determination as to whether an action is deferred or not).

      Show
      jira-bot ASF subversion and git services added a comment - Commit 46557889f5b6a066425d8e1f2c97bf5fed4dff80 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=4655788 ] ISIS-1613 : action buttons visibility is now dynamic. To support this requires a minor adjustment to CSS, because the button's outer <li> element is always rendered, even if the content is then invisible. Also moved some responsibilities from ActionLinkFactoryAbstract directly into ActionLink (the determination as to whether an action is deferred or not).
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit ae41acb491c0a6e7a1bc4a57b426ccd0477a0fa8 in isis's branch refs/heads/ISIS-1613a from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=ae41acb ]

      ISIS-1613: suppresses rendering of (none) for reference panel when null and is inline prompt

      Show
      jira-bot ASF subversion and git services added a comment - Commit ae41acb491c0a6e7a1bc4a57b426ccd0477a0fa8 in isis's branch refs/heads/ ISIS-1613 a from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=ae41acb ] ISIS-1613 : suppresses rendering of (none) for reference panel when null and is inline prompt
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 0848bda621e1142930e3ad2c3797fc2039e53fe4 in isis's branch refs/heads/ISIS-1613a from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=0848bda ]

      ISIS-1613: introduces ObjectAdapterModel as a simplified 'live' model for EntityIconAndTitlePanel

      Show
      jira-bot ASF subversion and git services added a comment - Commit 0848bda621e1142930e3ad2c3797fc2039e53fe4 in isis's branch refs/heads/ ISIS-1613 a from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=0848bda ] ISIS-1613 : introduces ObjectAdapterModel as a simplified 'live' model for EntityIconAndTitlePanel
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 564246e042864e4b4c549c0f3a3b69506949b602 in isis's branch refs/heads/ISIS-1613a from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=564246e ]

      ISIS-1613: inverts nested if statements in ReferencePanel

      to simplify the flow.

      This is around the area where we obtain the EntityIconAndTitle panel

      Show
      jira-bot ASF subversion and git services added a comment - Commit 564246e042864e4b4c549c0f3a3b69506949b602 in isis's branch refs/heads/ ISIS-1613 a from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=564246e ] ISIS-1613 : inverts nested if statements in ReferencePanel to simplify the flow. This is around the area where we obtain the EntityIconAndTitle panel
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit ecad997b1abd4bfbf3f927a086ab6c5d9db2b553 in isis's branch refs/heads/ISIS-1613a from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=ecad997 ]

      ISIS-1613: now seems to correctly toggle visibility of the icon for reference panel (via the EntityIconAndTitlePanel)

      Show
      jira-bot ASF subversion and git services added a comment - Commit ecad997b1abd4bfbf3f927a086ab6c5d9db2b553 in isis's branch refs/heads/ ISIS-1613 a from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=ecad997 ] ISIS-1613 : now seems to correctly toggle visibility of the icon for reference panel (via the EntityIconAndTitlePanel)
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 09735d0549c2e0c0489e2a055a3bcf65dff12700 in isis's branch refs/heads/ISIS-1613a from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=09735d0 ]

      ISIS-1613: tweaking CSS for drop down menus, font awesome icons

      Show
      jira-bot ASF subversion and git services added a comment - Commit 09735d0549c2e0c0489e2a055a3bcf65dff12700 in isis's branch refs/heads/ ISIS-1613 a from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=09735d0 ] ISIS-1613 : tweaking CSS for drop down menus, font awesome icons
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit f607a3e0d6443e133aa047b17066aeb8082dc264 in isis's branch refs/heads/ISIS-1613a from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=f607a3e ]

      ISIS-1613: work in progress, to get icons dynamic

      Show
      jira-bot ASF subversion and git services added a comment - Commit f607a3e0d6443e133aa047b17066aeb8082dc264 in isis's branch refs/heads/ ISIS-1613 a from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=f607a3e ] ISIS-1613 : work in progress, to get icons dynamic
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 62c23f00a66dca3d7679e8f61f43cdb1894410c6 in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=62c23f0 ]

      ISIS-1613: fixes concurrency issue with entity icon and title panel

      Show
      jira-bot ASF subversion and git services added a comment - Commit 62c23f00a66dca3d7679e8f61f43cdb1894410c6 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=62c23f0 ] ISIS-1613 : fixes concurrency issue with entity icon and title panel
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 8640a03e15a8b2beb0172ce0df85833ae7fc5af3 in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=8640a03 ]

      ISIS-1613: small CSS fix to introduce a gap for value panel when have actions to the right

      Show
      jira-bot ASF subversion and git services added a comment - Commit 8640a03e15a8b2beb0172ce0df85833ae7fc5af3 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=8640a03 ] ISIS-1613 : small CSS fix to introduce a gap for value panel when have actions to the right
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 90e2bc04517d304f91ec141daa174f0c172a832e in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=90e2bc0 ]

      ISIS-1613: suppresses rendering of (none) for reference panel when null and is inline prompt

      Show
      jira-bot ASF subversion and git services added a comment - Commit 90e2bc04517d304f91ec141daa174f0c172a832e in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=90e2bc0 ] ISIS-1613 : suppresses rendering of (none) for reference panel when null and is inline prompt
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit d3d44731d6c674fa7578655eb273c89768e35624 in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d3d4473 ]

      ISIS-1613: introduces ObjectAdapterModel as a simplified 'live' model for EntityIconAndTitlePanel

      Show
      jira-bot ASF subversion and git services added a comment - Commit d3d44731d6c674fa7578655eb273c89768e35624 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d3d4473 ] ISIS-1613 : introduces ObjectAdapterModel as a simplified 'live' model for EntityIconAndTitlePanel
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit ae8a6bcc83b54cd49b7f0d99dc686bd37619d2c8 in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=ae8a6bc ]

      ISIS-1613: inverts nested if statements in ReferencePanel

      to simplify the flow.

      This is around the area where we obtain the EntityIconAndTitle panel

      Show
      jira-bot ASF subversion and git services added a comment - Commit ae8a6bcc83b54cd49b7f0d99dc686bd37619d2c8 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=ae8a6bc ] ISIS-1613 : inverts nested if statements in ReferencePanel to simplify the flow. This is around the area where we obtain the EntityIconAndTitle panel
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 86ee79385a4b6b107eec54b5ee42cd4007e42c16 in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=86ee793 ]

      ISIS-1613: now seems to correctly toggle visibility of the icon for reference panel (via the EntityIconAndTitlePanel)

      Show
      jira-bot ASF subversion and git services added a comment - Commit 86ee79385a4b6b107eec54b5ee42cd4007e42c16 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=86ee793 ] ISIS-1613 : now seems to correctly toggle visibility of the icon for reference panel (via the EntityIconAndTitlePanel)
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 2c55b2b25e3b660fea9c707bb021ea8b16ef971c in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=2c55b2b ]

      ISIS-1613: tweaking CSS for drop down menus, font awesome icons

      Show
      jira-bot ASF subversion and git services added a comment - Commit 2c55b2b25e3b660fea9c707bb021ea8b16ef971c in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=2c55b2b ] ISIS-1613 : tweaking CSS for drop down menus, font awesome icons
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 05783aa37a939950f260a3a2ccf47b6c7ec987c3 in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=05783aa ]

      ISIS-1613: work in progress, to get icons dynamic

      Show
      jira-bot ASF subversion and git services added a comment - Commit 05783aa37a939950f260a3a2ccf47b6c7ec987c3 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=05783aa ] ISIS-1613 : work in progress, to get icons dynamic
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 259284e75f47f6a2118c77112fcf5f898fb2a42c in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=259284e ]

      ISIS-1613: ok, dynamic icon and also reference working, I think.

      Was throwing an exception when cleared reference, resultant from pending value in the ScalarModel. Call clearPending on detach (for ScalarModel) to fix this.

      Also, rather than EntityIconAndLinkPanel overriding isVisible(), instead use that for its immediate child, the 'entityLink' component

      Show
      jira-bot ASF subversion and git services added a comment - Commit 259284e75f47f6a2118c77112fcf5f898fb2a42c in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=259284e ] ISIS-1613 : ok, dynamic icon and also reference working, I think. Was throwing an exception when cleared reference, resultant from pending value in the ScalarModel. Call clearPending on detach (for ScalarModel) to fix this. Also, rather than EntityIconAndLinkPanel overriding isVisible(), instead use that for its immediate child, the 'entityLink' component
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 6f39447d7e463b007cc42a5007c164dd074f3f43 in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=6f39447 ]

      ISIS-1613: standardizes the 'mandatory' CSS for fields by various types (move up to ScalarPanelAbstract2 superclass)

      Show
      jira-bot ASF subversion and git services added a comment - Commit 6f39447d7e463b007cc42a5007c164dd074f3f43 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=6f39447 ] ISIS-1613 : standardizes the 'mandatory' CSS for fields by various types (move up to ScalarPanelAbstract2 superclass)
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 72bab93897364d54758211efa3ef819c9007c671 in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=72bab93 ]

      ISIS-1613: uses small checkboxes for table view (large for regular form view)

      Show
      jira-bot ASF subversion and git services added a comment - Commit 72bab93897364d54758211efa3ef819c9007c671 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=72bab93 ] ISIS-1613 : uses small checkboxes for table view (large for regular form view)
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 6fe0008340553c99d0d4f566a4ae642688751431 in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=6fe0008 ]

      ISIS-1613: action defaults are now honoured for inline prompts

      Show
      jira-bot ASF subversion and git services added a comment - Commit 6fe0008340553c99d0d4f566a4ae642688751431 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=6fe0008 ] ISIS-1613 : action defaults are now honoured for inline prompts
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 76896f8cb10fe500e73daf1cc8f55dbfe819e7ed in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=76896f8 ]

      ISIS-1613: no-arg actions no longer prompt (if inline)

      Show
      jira-bot ASF subversion and git services added a comment - Commit 76896f8cb10fe500e73daf1cc8f55dbfe819e7ed in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=76896f8 ] ISIS-1613 : no-arg actions no longer prompt (if inline)
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 07e3653ba7718a85802b87c51edd5fec8aeefc78 in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=07e3653 ]

      ISIS-1613: fixes for CSS of dropdowns

      Show
      jira-bot ASF subversion and git services added a comment - Commit 07e3653ba7718a85802b87c51edd5fec8aeefc78 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=07e3653 ] ISIS-1613 : fixes for CSS of dropdowns
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit a39a987ee0d1d2cd986e3391e45e6b63022aca37 in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=a39a987 ]

      ISIS-1613: fixes for prompt style when .layout.json is used

      Show
      jira-bot ASF subversion and git services added a comment - Commit a39a987ee0d1d2cd986e3391e45e6b63022aca37 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=a39a987 ] ISIS-1613 : fixes for prompt style when .layout.json is used
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 3aca4593ae5f7c95af8db50f9664afdbfb2613bd in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=3aca459 ]

      ISIS-1613: tweaks rendering of inline prompts, don't suggest that they are hyperlinks.

      Show
      jira-bot ASF subversion and git services added a comment - Commit 3aca4593ae5f7c95af8db50f9664afdbfb2613bd in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=3aca459 ] ISIS-1613 : tweaks rendering of inline prompts, don't suggest that they are hyperlinks.

        People

        • Assignee:
          danhaywood Dan Haywood
          Reporter:
          danhaywood Dan Haywood
        • Votes:
          0 Vote for this issue
          Watchers:
          2 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development