Uploaded image for project: 'Isis'
  1. Isis
  2. ISIS-1609

@Property(editing=ENABLED) not working for some JAXB view model properties.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.14.0
    • Fix Version/s: 1.15.0
    • Component/s: Core
    • Labels:
      None

      Description

      Tracked down the issue to RecreatableObjectFacetForXmlRootElementAnnotation being installed, and then DisabledFacetOn

      {Property|Collection}

      DerivedFromRecreatableObject being installed even if the RecreatableObjectFacet sometimes returns null (for JAXB elements, and if implements ViewModelFacet.Cloneable).

      Solution: rather than rely on ViewModelFacet#isCloneable(Object), which works at the object level, instead introduce a new ViewModelFacet#inferImmutable(), which acts at the class level, and from this be able to figure out if the DisabledFacet thus installed has inverted semantics.

        Activity

        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit bd11d5f2c5eba27d89d5f724b781c010d1fb8436 in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=bd11d5f ]

        ISIS-1609: fix for facet factories @Property(editing=ENABLED) for JAXB.

        Show
        jira-bot ASF subversion and git services added a comment - Commit bd11d5f2c5eba27d89d5f724b781c010d1fb8436 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=bd11d5f ] ISIS-1609 : fix for facet factories @Property(editing=ENABLED) for JAXB.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 6b5f14298ee73fb986bd4d647efc00bfe360977d in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=6b5f142 ]

        ISIS-1609: switching swagger-ui to simply use the files in the dist folder (with tiny adjustments) rather than webjars

        ... was having path issues (403 error) so this way is much simpler (and its only a developer utility after all.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 6b5f14298ee73fb986bd4d647efc00bfe360977d in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=6b5f142 ] ISIS-1609 : switching swagger-ui to simply use the files in the dist folder (with tiny adjustments) rather than webjars ... was having path issues (403 error) so this way is much simpler (and its only a developer utility after all.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 3f2728d091c878a30aa4692c4673d764088ee8a0 in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=3f2728d ]

        ISIS-1609: removes hack to swagger-ui index

        Show
        jira-bot ASF subversion and git services added a comment - Commit 3f2728d091c878a30aa4692c4673d764088ee8a0 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=3f2728d ] ISIS-1609 : removes hack to swagger-ui index

          People

          • Assignee:
            danhaywood Dan Haywood
            Reporter:
            danhaywood Dan Haywood
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development