Uploaded image for project: 'Isis'
  1. Isis
  2. ISIS-1595

Configuration property for JDOQL VARIABLES clause mismatch

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.14.0
    • Fix Version/s: 1.15.0
    • Component/s: None
    • Labels:
      None

      Description

      The migration notes for 1.14.0 states that the configuration property to check for JDOQL VARIABLES class name validity is:

      isis.reflector.validator.jdoqlVariablesClause

      However, the corresponding facet factory defines the property differently:

      public static final String ISIS_REFLECTOR_VALIDATOR_JDOQL_VARIABLES_CLAUSE_KEY = "isis.reflector.validator.variablesFromClause";

      I would argue that the documentation's version is better, since the factory version is rather ambiguous with respect to the property that defines JDOQL FROM clause validation. I will raise a PR that changes the constant to match the documentation.

        Activity

        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 6572e389f82e009b911e85a37fd19e773d49279d in isis's branch refs/heads/master from Sander Ginn
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=6572e38 ]

        ISIS-1595: updated configuration property for JDOQL VARIABLES validation

        Show
        jira-bot ASF subversion and git services added a comment - Commit 6572e389f82e009b911e85a37fd19e773d49279d in isis's branch refs/heads/master from Sander Ginn [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=6572e38 ] ISIS-1595 : updated configuration property for JDOQL VARIABLES validation
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit bfca3eeedeed3a4e7c597c50d4e1197b8be1e2ef in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=bfca3ee ]

        Merge branch 'ISIS-1595-jdoql-validation' of https://github.com/sanderginn/isis into ISIS-1595_pr-70

        Show
        jira-bot ASF subversion and git services added a comment - Commit bfca3eeedeed3a4e7c597c50d4e1197b8be1e2ef in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=bfca3ee ] Merge branch ' ISIS-1595 -jdoql-validation' of https://github.com/sanderginn/isis into ISIS-1595 _pr-70
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit bfca3eeedeed3a4e7c597c50d4e1197b8be1e2ef in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=bfca3ee ]

        Merge branch 'ISIS-1595-jdoql-validation' of https://github.com/sanderginn/isis into ISIS-1595_pr-70

        Show
        jira-bot ASF subversion and git services added a comment - Commit bfca3eeedeed3a4e7c597c50d4e1197b8be1e2ef in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=bfca3ee ] Merge branch ' ISIS-1595 -jdoql-validation' of https://github.com/sanderginn/isis into ISIS-1595 _pr-70
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 2ad80528326e0534bfc221ed576c466c81d19691 in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=2ad8052 ]

        Merge branch 'ISIS-1595_pr-70'

        Show
        jira-bot ASF subversion and git services added a comment - Commit 2ad80528326e0534bfc221ed576c466c81d19691 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=2ad8052 ] Merge branch ' ISIS-1595 _pr-70'
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 21baee141058fdad42836544570a227dc4443547 in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=21baee1 ]

        ISIS-1595: updates migration notes

        Show
        jira-bot ASF subversion and git services added a comment - Commit 21baee141058fdad42836544570a227dc4443547 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=21baee1 ] ISIS-1595 : updates migration notes

          People

          • Assignee:
            danhaywood Dan Haywood
            Reporter:
            sginn Sander Ginn
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development