Uploaded image for project: 'Isis'
  1. Isis
  2. ISIS-1579

Asciidoc Template/Stylesheet issues

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.15.0
    • Component/s: Website and Docs
    • Labels:
      None

      Description

      Couple of things I noticed

      1. When viewing the ISIS website on a mobile device (or browser with narrow width) the "nav" items collapse to be replaced by the 3 horizontal lines icon. This is presumably intended to then show a dropdown of the "nav" items. But it doesn't do anything seemingly.
      My experience of asciidoc templates is very limited so can't tell you what is wrong (though was investigating writing a DN variant and hit the same problem, so would be interested in the solution!), and you seem to have used Deltaspike as a starting point for yours (theirs also has the same problem). A site that does give the three horizontal lines, and subsequent dropdown is http://vertx.io/docs/vertx-core/java/ in case its of use.

      2. Table headings are shown with white text on a light grey background, hence virtually unreadable. For example
      https://isis.apache.org/guides/rgcfg.html#2.-deployment-types
      Setting th.tableblock background-color and color should fix that.

        Activity

        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 2db1920b507b5bfb63b332f87f1bc59d218522fa in isis's branch refs/heads/ISIS-1613 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=2db1920 ]

        ISIS-1579: adds the doc being referenced in the search results

        Also reference javadoc.io in the menu bar

        Show
        jira-bot ASF subversion and git services added a comment - Commit 2db1920b507b5bfb63b332f87f1bc59d218522fa in isis's branch refs/heads/ ISIS-1613 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=2db1920 ] ISIS-1579 : adds the doc being referenced in the search results Also reference javadoc.io in the menu bar
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 56544cb9bb3f107ff13294af1fc9be096187d908 in isis's branch refs/heads/ISIS-1613 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=56544cb ]

        ISIS-1579: tweaks underlining style

        Show
        jira-bot ASF subversion and git services added a comment - Commit 56544cb9bb3f107ff13294af1fc9be096187d908 in isis's branch refs/heads/ ISIS-1613 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=56544cb ] ISIS-1579 : tweaks underlining style
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 2db1920b507b5bfb63b332f87f1bc59d218522fa in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=2db1920 ]

        ISIS-1579: adds the doc being referenced in the search results

        Also reference javadoc.io in the menu bar

        Show
        jira-bot ASF subversion and git services added a comment - Commit 2db1920b507b5bfb63b332f87f1bc59d218522fa in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=2db1920 ] ISIS-1579 : adds the doc being referenced in the search results Also reference javadoc.io in the menu bar
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 56544cb9bb3f107ff13294af1fc9be096187d908 in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=56544cb ]

        ISIS-1579: tweaks underlining style

        Show
        jira-bot ASF subversion and git services added a comment - Commit 56544cb9bb3f107ff13294af1fc9be096187d908 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=56544cb ] ISIS-1579 : tweaks underlining style
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit bd53b304d53c78331fec12c321c8f3176fac2b42 in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=bd53b30 ]

        ISIS-1579: fixes positioning of search results when there is a table of contents along the side

        Show
        jira-bot ASF subversion and git services added a comment - Commit bd53b304d53c78331fec12c321c8f3176fac2b42 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=bd53b30 ] ISIS-1579 : fixes positioning of search results when there is a table of contents along the side
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit b2404a50dc21cd714acc00c5eedb2988acdc161f in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=b2404a5 ]

        ISIS-1579: fixes minor typo on index.html

        Show
        jira-bot ASF subversion and git services added a comment - Commit b2404a50dc21cd714acc00c5eedb2988acdc161f in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=b2404a5 ] ISIS-1579 : fixes minor typo on index.html
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 59cc2ffc8d5b3507afa54e8d0ce025a4ec5ced88 in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=59cc2ff ]

        ISIS-1579: hide TOC when small

        Show
        jira-bot ASF subversion and git services added a comment - Commit 59cc2ffc8d5b3507afa54e8d0ce025a4ec5ced88 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=59cc2ff ] ISIS-1579 : hide TOC when small
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 90bc6a201d7b031adf9a5dc36017121a769358f2 in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=90bc6a2 ]

        ISIS-1579: further improvements to responsive layout

        Show
        jira-bot ASF subversion and git services added a comment - Commit 90bc6a201d7b031adf9a5dc36017121a769358f2 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=90bc6a2 ] ISIS-1579 : further improvements to responsive layout
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 02629ed68116963ec92e1754e0592d1847adcb03 in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=02629ed ]

        ISIS-1579: makes the doc layout more responsive (especially index.html)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 02629ed68116963ec92e1754e0592d1847adcb03 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=02629ed ] ISIS-1579 : makes the doc layout more responsive (especially index.html)
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit ec3b31290159fd4acb97f8fc55db9864b3a69406 in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=ec3b312 ]

        ISIS-1579: fixes scrolling and bad links in menu

        Show
        jira-bot ASF subversion and git services added a comment - Commit ec3b31290159fd4acb97f8fc55db9864b3a69406 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=ec3b312 ] ISIS-1579 : fixes scrolling and bad links in menu
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 4422d2e6bb1cd7f0402dedf3136cec4dcbbca209 in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=4422d2e ]

        ISIS-1579: deletes unused CSS and JS for reworked website

        Show
        jira-bot ASF subversion and git services added a comment - Commit 4422d2e6bb1cd7f0402dedf3136cec4dcbbca209 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=4422d2e ] ISIS-1579 : deletes unused CSS and JS for reworked website
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 27c715da08bbf6b24a751c5c868abdcdf080f351 in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=27c715d ]

        ISIS-1579: tidying up

        Show
        jira-bot ASF subversion and git services added a comment - Commit 27c715da08bbf6b24a751c5c868abdcdf080f351 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=27c715d ] ISIS-1579 : tidying up
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 99068b2bb10790f0d1291837e0f36278ac5b04cb in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=99068b2 ]

        ISIS-1579: front page converted to bootstrap

        Show
        jira-bot ASF subversion and git services added a comment - Commit 99068b2bb10790f0d1291837e0f36278ac5b04cb in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=99068b2 ] ISIS-1579 : front page converted to bootstrap
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit f89684452364adf6e2137bec8d673988b33ccfc3 in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=f896844 ]

        ISIS-1579: comment out the datanucleus theme, header-links, documentation table

        Show
        jira-bot ASF subversion and git services added a comment - Commit f89684452364adf6e2137bec8d673988b33ccfc3 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=f896844 ] ISIS-1579 : comment out the datanucleus theme, header-links, documentation table
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit c9e1890e5e333ea56c680d97598c8d5be6c86261 in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=c9e1890 ]

        ISIS-1579: menu bar

        Show
        jira-bot ASF subversion and git services added a comment - Commit c9e1890e5e333ea56c680d97598c8d5be6c86261 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=c9e1890 ] ISIS-1579 : menu bar
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 88f538a808097495679eb982ee246221add9b605 in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=88f538a ]

        ISIS-1579: improving the search bar

        Show
        jira-bot ASF subversion and git services added a comment - Commit 88f538a808097495679eb982ee246221add9b605 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=88f538a ] ISIS-1579 : improving the search bar
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 02629ed68116963ec92e1754e0592d1847adcb03 in isis's branch refs/heads/ISIS-1579 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=02629ed ]

        ISIS-1579: makes the doc layout more responsive (especially index.html)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 02629ed68116963ec92e1754e0592d1847adcb03 in isis's branch refs/heads/ ISIS-1579 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=02629ed ] ISIS-1579 : makes the doc layout more responsive (especially index.html)
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit ec3b31290159fd4acb97f8fc55db9864b3a69406 in isis's branch refs/heads/ISIS-1579 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=ec3b312 ]

        ISIS-1579: fixes scrolling and bad links in menu

        Show
        jira-bot ASF subversion and git services added a comment - Commit ec3b31290159fd4acb97f8fc55db9864b3a69406 in isis's branch refs/heads/ ISIS-1579 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=ec3b312 ] ISIS-1579 : fixes scrolling and bad links in menu
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 4422d2e6bb1cd7f0402dedf3136cec4dcbbca209 in isis's branch refs/heads/ISIS-1579 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=4422d2e ]

        ISIS-1579: deletes unused CSS and JS for reworked website

        Show
        jira-bot ASF subversion and git services added a comment - Commit 4422d2e6bb1cd7f0402dedf3136cec4dcbbca209 in isis's branch refs/heads/ ISIS-1579 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=4422d2e ] ISIS-1579 : deletes unused CSS and JS for reworked website
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 27c715da08bbf6b24a751c5c868abdcdf080f351 in isis's branch refs/heads/ISIS-1579 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=27c715d ]

        ISIS-1579: tidying up

        Show
        jira-bot ASF subversion and git services added a comment - Commit 27c715da08bbf6b24a751c5c868abdcdf080f351 in isis's branch refs/heads/ ISIS-1579 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=27c715d ] ISIS-1579 : tidying up
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 99068b2bb10790f0d1291837e0f36278ac5b04cb in isis's branch refs/heads/ISIS-1579 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=99068b2 ]

        ISIS-1579: front page converted to bootstrap

        Show
        jira-bot ASF subversion and git services added a comment - Commit 99068b2bb10790f0d1291837e0f36278ac5b04cb in isis's branch refs/heads/ ISIS-1579 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=99068b2 ] ISIS-1579 : front page converted to bootstrap
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit f89684452364adf6e2137bec8d673988b33ccfc3 in isis's branch refs/heads/ISIS-1579 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=f896844 ]

        ISIS-1579: comment out the datanucleus theme, header-links, documentation table

        Show
        jira-bot ASF subversion and git services added a comment - Commit f89684452364adf6e2137bec8d673988b33ccfc3 in isis's branch refs/heads/ ISIS-1579 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=f896844 ] ISIS-1579 : comment out the datanucleus theme, header-links, documentation table
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit c9e1890e5e333ea56c680d97598c8d5be6c86261 in isis's branch refs/heads/ISIS-1579 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=c9e1890 ]

        ISIS-1579: menu bar

        Show
        jira-bot ASF subversion and git services added a comment - Commit c9e1890e5e333ea56c680d97598c8d5be6c86261 in isis's branch refs/heads/ ISIS-1579 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=c9e1890 ] ISIS-1579 : menu bar
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 88f538a808097495679eb982ee246221add9b605 in isis's branch refs/heads/ISIS-1579 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=88f538a ]

        ISIS-1579: improving the search bar

        Show
        jira-bot ASF subversion and git services added a comment - Commit 88f538a808097495679eb982ee246221add9b605 in isis's branch refs/heads/ ISIS-1579 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=88f538a ] ISIS-1579 : improving the search bar
        Hide
        danhaywood Dan Haywood added a comment -

        Andy Jefferson - many thanks for taking the time for raising this and providing a possible solution ... will look to incorporate.

        Show
        danhaywood Dan Haywood added a comment - Andy Jefferson - many thanks for taking the time for raising this and providing a possible solution ... will look to incorporate.
        Hide
        andy Andy Jefferson added a comment -

        Re the first issue (accessibility of the "menu" button on small screens/mobile) whilst developing the DN site I managed to get a combination that works in this respect but I didn't track down what the precise incompatibility was between Bootstrap+asciidoc(tor)+TOC was (tried many different combos of jquery, bootstrap etc and most failed). I then went back to first principles, started with Bootstrap 3.3.7 on a basic page, then used the "bootstrap-toc" plugin (https://afeld.github.io/bootstrap-toc/#examples ) to get the dynamic TOC, and then added on an asciidoc CSS to give formatting; the result was a menu button working, the dynamic TOC like what you have, and the rest of bootstrap menu options fully usable. Code is under https://github.com/datanucleus/docs-accessplatform in case its of use.

        Show
        andy Andy Jefferson added a comment - Re the first issue (accessibility of the "menu" button on small screens/mobile) whilst developing the DN site I managed to get a combination that works in this respect but I didn't track down what the precise incompatibility was between Bootstrap+asciidoc(tor)+TOC was (tried many different combos of jquery, bootstrap etc and most failed). I then went back to first principles, started with Bootstrap 3.3.7 on a basic page, then used the "bootstrap-toc" plugin ( https://afeld.github.io/bootstrap-toc/#examples ) to get the dynamic TOC, and then added on an asciidoc CSS to give formatting; the result was a menu button working, the dynamic TOC like what you have, and the rest of bootstrap menu options fully usable. Code is under https://github.com/datanucleus/docs-accessplatform in case its of use.

          People

          • Assignee:
            danhaywood Dan Haywood
            Reporter:
            andy Andy Jefferson
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development