Uploaded image for project: 'Isis'
  1. Isis
  2. ISIS-1571

Should throw metamodel validation error if omit choices or autoComplete for parameter collection type.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.13.2.1
    • Fix Version/s: 1.14.0
    • Component/s: Core
    • Labels:
      None

      Description

      The current implementation of collection parameters (as per ISIS-785) requires that a choices or autoComplete facet is required for the parameter.

      This ticket is to check this requirement early using a metamodel validator.

        Activity

        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit e402f2311a776687ec653f5cf9270053fbd2f0bc in isis's branch refs/heads/maint-1.14.0 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=e402f23 ]

        ISIS-1571: checks that every action collection parameter has a supporting choices or autoComplete facet.

        Implementing this required moving the metamodel validation to be run within a session. This results in potentially more object specs to validate, and in particular resulted in a validation failure that java.lang.Object and FreeStandingList had the same object type. So this commit also incorporates a fix for that, by only comparing specs that are entities or view models.

        Show
        jira-bot ASF subversion and git services added a comment - Commit e402f2311a776687ec653f5cf9270053fbd2f0bc in isis's branch refs/heads/maint-1.14.0 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=e402f23 ] ISIS-1571 : checks that every action collection parameter has a supporting choices or autoComplete facet. Implementing this required moving the metamodel validation to be run within a session. This results in potentially more object specs to validate, and in particular resulted in a validation failure that java.lang.Object and FreeStandingList had the same object type. So this commit also incorporates a fix for that, by only comparing specs that are entities or view models.

          People

          • Assignee:
            danhaywood Dan Haywood
            Reporter:
            danhaywood Dan Haywood
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development