[CAUSEWAY-1562] Metamodel exception if @DomainObject(ENTITY) missing when @PersistenceCapable or @Entity

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Abandoned
• Affects Version/s: 1.13.2
• Component/s: Applib (programming model)
• Assignee: Unassigned
• Reporter: Daniel Keir Haywood
• Created: 31/Dec/16 09:33
• Updated: 29/Apr/22 15:42
• Resolved: 29/Apr/22 15:42

Description

Metamodel validator if forget to annotate...

 

Also, RepositoryService#persist(...) is a no-op if the domain object passed in is not an entity; this should probably fail-fast.

This was originally prompted by an obscure message being thrown in Memento#updateFieldsAndResolveState(...), as the result of an entity being treated as transient, because (a) the @PersistenceCapable annotation was accidentally omitted, and (b) a call to RepositoryService#persist(...) just did nothing.

So, this ticket would be a fail-fast for that scenario.

    private void updateFieldsAndResolveState(final ObjectAdapter objectAdapter, final Data data) {
        
        boolean dataIsTransient = data.getOid().isTransient();
        
        if (!dataIsTransient) {
           ...
        } else if (objectAdapter.isTransient() && dataIsTransient) {
           ...
            
        } else if (objectAdapter.isParentedCollection()) {
           ...
            
        } else {

           // THIS IS THE BRANCH THAT'S TRIGGERED IF @PersistenceCapable IS ACCIDENTALLY OMITTED.

            final ObjectData od = (ObjectData) data;
            if (od.containsField()) {
                throw new IsisException("Resolve state (for " + objectAdapter + ") inconsistent with fact that data exists for fields");
            }
        }
    }