Uploaded image for project: 'Isis'
  1. Isis
  2. ISIS-1557

Enhance EmailServiceDefault, to optionally throw exception if fail, and optionally allow overrides

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.13.2
    • Fix Version/s: 1.14.0
    • Component/s: Core
    • Labels:
      None

      Description

      Currently EmailServiceDefault simply logs any exceptions and returns a simple true/false to indicate if a failure. It would be better if it could instead throw an exception.

      Also, for testing it would be useful to allow the email to be "diverted" to some override location. That way, the entire setup of smtp server etc can be tested, but with the assurance that the email won't be sent out to some customer accidentally.

        Activity

        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit a942d1bea258f922d5e49c3de549213eb2b55b72 in isis's branch refs/heads/maint-1.13.3 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=a942d1b ]

        ISIS-1557: refactors EmailServiceDefault, tidying up only (no functional change)

        Show
        jira-bot ASF subversion and git services added a comment - Commit a942d1bea258f922d5e49c3de549213eb2b55b72 in isis's branch refs/heads/maint-1.13.3 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=a942d1b ] ISIS-1557 : refactors EmailServiceDefault, tidying up only (no functional change)
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 66ff503427afb40e091dc3e54b81a18628b95a9b in isis's branch refs/heads/maint-1.13.3 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=66ff503 ]

        ISIS-1557: adds the throwExceptionOnFail config property for EmailServiceDefault

        Show
        jira-bot ASF subversion and git services added a comment - Commit 66ff503427afb40e091dc3e54b81a18628b95a9b in isis's branch refs/heads/maint-1.13.3 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=66ff503 ] ISIS-1557 : adds the throwExceptionOnFail config property for EmailServiceDefault
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit ac2907dfe80a3a118bc096c35dece291d25dc6ce in isis's branch refs/heads/maint-1.13.3 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=ac2907d ]

        ISIS-1557: updates _rgcfg_configuring_core.adoc, each sentence to its own line.

        Show
        jira-bot ASF subversion and git services added a comment - Commit ac2907dfe80a3a118bc096c35dece291d25dc6ce in isis's branch refs/heads/maint-1.13.3 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=ac2907d ] ISIS-1557 : updates _rgcfg_configuring_core.adoc, each sentence to its own line.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 0e4f1ffa66547642fe89b82e2eb959544d3d8ea5 in isis's branch refs/heads/maint-1.13.3 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=0e4f1ff ]

        ISIS-1557: reorders configuration properties alphabetically.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 0e4f1ffa66547642fe89b82e2eb959544d3d8ea5 in isis's branch refs/heads/maint-1.13.3 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=0e4f1ff ] ISIS-1557 : reorders configuration properties alphabetically.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit a6959fa90f021d45e77650d120b5f5fa89291660 in isis's branch refs/heads/maint-1.13.3 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=a6959fa ]

        ISIS-1557: more reformatting, each sentence on its own line.

        Show
        jira-bot ASF subversion and git services added a comment - Commit a6959fa90f021d45e77650d120b5f5fa89291660 in isis's branch refs/heads/maint-1.13.3 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=a6959fa ] ISIS-1557 : more reformatting, each sentence on its own line.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 15b30aa0a2afd2ff0b6511e0980a6a4ceb0f0d04 in isis's branch refs/heads/maint-1.13.3 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=15b30aa ]

        ISIS-1557: adds docs for isis.service.email.throwExceptionOnFail

        Show
        jira-bot ASF subversion and git services added a comment - Commit 15b30aa0a2afd2ff0b6511e0980a6a4ceb0f0d04 in isis's branch refs/heads/maint-1.13.3 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=15b30aa ] ISIS-1557 : adds docs for isis.service.email.throwExceptionOnFail
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit c074b8b9afa6bacca505867eda8b50c0c2fe5e20 in isis's branch refs/heads/maint-1.13.3 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=c074b8b ]

        ISIS-1557: formats adoc, table of service config properties

        Show
        jira-bot ASF subversion and git services added a comment - Commit c074b8b9afa6bacca505867eda8b50c0c2fe5e20 in isis's branch refs/heads/maint-1.13.3 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=c074b8b ] ISIS-1557 : formats adoc, table of service config properties
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 07b0ecfa0544560b381d7f3483acdce699de7a06 in isis's branch refs/heads/maint-1.13.3 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=07b0ecf ]

        ISIS-1557: adds in configuration properties for email service to set socket timeout and socket connection timeout

        Show
        jira-bot ASF subversion and git services added a comment - Commit 07b0ecfa0544560b381d7f3483acdce699de7a06 in isis's branch refs/heads/maint-1.13.3 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=07b0ecf ] ISIS-1557 : adds in configuration properties for email service to set socket timeout and socket connection timeout
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 7c2ca9933e9200aee4f93b04f4e08c331575fece in isis's branch refs/heads/maint-1.13.3 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=7c2ca99 ]

        ISIS-1557: adds email configuration keys to allow the to, cc and bcc email addresses to be overridden.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 7c2ca9933e9200aee4f93b04f4e08c331575fece in isis's branch refs/heads/maint-1.13.3 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=7c2ca99 ] ISIS-1557 : adds email configuration keys to allow the to, cc and bcc email addresses to be overridden.

          People

          • Assignee:
            danhaywood Dan Haywood
            Reporter:
            danhaywood Dan Haywood
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development