Uploaded image for project: 'Isis'
  1. Isis
  2. ISIS-1546

Reduce logging (don't show stack traces) for invalid user/pass attempts

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.13.1
    • Fix Version/s: 1.13.2
    • Component/s: Core: Security: Shiro
    • Labels:
      None

      Description

      don't log exceptions if user mistypes their password

        Activity

        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 4078033097de2b75f1582e938c73f48958522b7a in isis's branch refs/heads/maint-1.13.2 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=4078033 ]

        ISIS-1546: reduces logging for the more common exceptions.

        UnknownAccountException:

        • was debug plus stack trace
        • now info message (showing user name)

        IncorrectCredentialsException

        • was debug plus stack trace
        • now info message (showing user name)

        CredentialsException

        • was debug plus stack trace
        • now error plus stack trace

        LockedAccountException

        • was info plus stack trace
        • now info message (showing user name)

        ExcessiveAttemptsException

        • was info plus stack trace
        • now info message (showing user name)
        Show
        jira-bot ASF subversion and git services added a comment - Commit 4078033097de2b75f1582e938c73f48958522b7a in isis's branch refs/heads/maint-1.13.2 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=4078033 ] ISIS-1546 : reduces logging for the more common exceptions. UnknownAccountException: was debug plus stack trace now info message (showing user name) IncorrectCredentialsException was debug plus stack trace now info message (showing user name) CredentialsException was debug plus stack trace now error plus stack trace LockedAccountException was info plus stack trace now info message (showing user name) ExcessiveAttemptsException was info plus stack trace now info message (showing user name)

          People

          • Assignee:
            danhaywood Dan Haywood
            Reporter:
            danhaywood Dan Haywood
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development