Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.13.0
    • Fix Version/s: 1.13.2
    • Component/s: Core
    • Labels:
      None

      Description

        Activity

        Hide
        danhaywood Dan Haywood added a comment -

        OK, so I've looked at this, and the short answer is that the MementoService (which is some rather old code that is used internally by ViewModel) was never updated to work with java.util.Date.

        Looking at the code, though, it seems to just do a toString() of the object to be added to the memento. For the data types that are supported, this is unambiguous, but I don't think it would be for a java.util.Date.

        Rather than fix/enhance, my suggestion is just to use @XmlRootElement instead. This will bring in the whole power of JAXB for serialization, so should be much more robust.

        Show
        danhaywood Dan Haywood added a comment - OK, so I've looked at this, and the short answer is that the MementoService (which is some rather old code that is used internally by ViewModel) was never updated to work with java.util.Date. Looking at the code, though, it seems to just do a toString() of the object to be added to the memento. For the data types that are supported, this is unambiguous, but I don't think it would be for a java.util.Date. Rather than fix/enhance, my suggestion is just to use @XmlRootElement instead. This will bring in the whole power of JAXB for serialization, so should be much more robust.
        Hide
        danhaywood Dan Haywood added a comment -

        See comment on ticket; use @XmlRootElement annotation instead.

        Show
        danhaywood Dan Haywood added a comment - See comment on ticket; use @XmlRootElement annotation instead.
        Hide
        danhaywood Dan Haywood added a comment -

        reopening because a PR has been provided to fix.

        Show
        danhaywood Dan Haywood added a comment - reopening because a PR has been provided to fix.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 42f36a5e78b74b6b229ea38c320bd0963bc9ec73 in isis's branch refs/heads/master from mwhesse
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=42f36a5 ]

        ISIS-1524: Dates not showing in view model

        Added support for java.util.Date to MementoService

        Show
        jira-bot ASF subversion and git services added a comment - Commit 42f36a5e78b74b6b229ea38c320bd0963bc9ec73 in isis's branch refs/heads/master from mwhesse [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=42f36a5 ] ISIS-1524 : Dates not showing in view model Added support for java.util.Date to MementoService
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 0d4a2f49c0cf6ed8d07cf5e11b0575d61844e168 in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=0d4a2f4 ]

        Merge branch 'ISIS-1524_pr-64'

        Show
        jira-bot ASF subversion and git services added a comment - Commit 0d4a2f49c0cf6ed8d07cf5e11b0575d61844e168 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=0d4a2f4 ] Merge branch ' ISIS-1524 _pr-64'
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 852c5772ec27004430a35d41b61141ff721ffa84 in isis's branch refs/heads/maint-1.13.2 from mwhesse
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=852c577 ]

        ISIS-1524: Dates not showing in view model

        Added support for java.util.Date to MementoService

        Show
        jira-bot ASF subversion and git services added a comment - Commit 852c5772ec27004430a35d41b61141ff721ffa84 in isis's branch refs/heads/maint-1.13.2 from mwhesse [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=852c577 ] ISIS-1524 : Dates not showing in view model Added support for java.util.Date to MementoService
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 8b70b192e0bede9329fb587ab650177cb69ae011 in isis's branch refs/heads/maint-1.13.2 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=8b70b19 ]

        Merge branch 'ISIS-1524' into maint-1.13.2

        Show
        jira-bot ASF subversion and git services added a comment - Commit 8b70b192e0bede9329fb587ab650177cb69ae011 in isis's branch refs/heads/maint-1.13.2 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=8b70b19 ] Merge branch ' ISIS-1524 ' into maint-1.13.2

          People

          • Assignee:
            danhaywood Dan Haywood
            Reporter:
            danhaywood Dan Haywood
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development