Uploaded image for project: 'Isis'
  1. Isis
  2. ISIS-1498

BackgroundCommandExecution does not handle exceptions correctly.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.13.0
    • Fix Version/s: 1.13.1
    • Component/s: Core
    • Labels:
      None

      Description

      Seen two separate issues.

      First, when there was a mismatch in arguments to parameters (see ISIS-1497), this resulted in an NPE in this line of the catch block:

      Exception unused = backgroundInteraction.getPriorExecution().getThrew();
      

      specifically, getPriorExecution() returned null.

      Then, when I worked around that issue so that the action could be invoked but when executed threw an exception, resulted in an NPE in this line of the catch block:

      backgroundInteraction.getCurrentExecution().setThrew(e);
      

      Here, getCurrentExecution() returned null.

        Activity

        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 06d95ab91a69e8f8e5513fef40fe086259f69a80 in isis's branch refs/heads/maint-1.13.1 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=06d95ab ]

        ISIS-1498: introduces new clearAbortCauseAndContinue() internal API for IsisTransaction, and leverage within BackgroundCommandExecution for the case where an action throws an exception (want to capture that, mark on the background Command, and persist).

        Show
        jira-bot ASF subversion and git services added a comment - Commit 06d95ab91a69e8f8e5513fef40fe086259f69a80 in isis's branch refs/heads/maint-1.13.1 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=06d95ab ] ISIS-1498 : introduces new clearAbortCauseAndContinue() internal API for IsisTransaction, and leverage within BackgroundCommandExecution for the case where an action throws an exception (want to capture that, mark on the background Command, and persist).
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 853405172c57ebbe6f4cbef98ab1e5c3e02a9aca in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=8534051 ]

        ISIS-1498: introduces new clearAbortCauseAndContinue() internal API for IsisTransaction, and leverage within BackgroundCommandExecution for the case where an action throws an exception (want to capture that, mark on the background Command, and persist).

        Show
        jira-bot ASF subversion and git services added a comment - Commit 853405172c57ebbe6f4cbef98ab1e5c3e02a9aca in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=8534051 ] ISIS-1498 : introduces new clearAbortCauseAndContinue() internal API for IsisTransaction, and leverage within BackgroundCommandExecution for the case where an action throws an exception (want to capture that, mark on the background Command, and persist).

          People

          • Assignee:
            danhaywood Dan Haywood
            Reporter:
            danhaywood Dan Haywood
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development