[CAUSEWAY-1498] BackgroundCommandExecution does not handle exceptions correctly.

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.13.0
• Fix Version/s: 1.13.1
• Component/s: Core
• Assignee: Daniel Keir Haywood
• Reporter: Daniel Keir Haywood
• Created: 27/Sep/16 09:24
• Updated: 27/Sep/16 16:52
• Resolved: 27/Sep/16 16:52

Description

Seen two separate issues.

First, when there was a mismatch in arguments to parameters (see ISIS-1497), this resulted in an NPE in this line of the catch block:

Exception unused = backgroundInteraction.getPriorExecution().getThrew();

specifically, getPriorExecution() returned null.

Then, when I worked around that issue so that the action could be invoked but when executed threw an exception, resulted in an NPE in this line of the catch block:

backgroundInteraction.getCurrentExecution().setThrew(e);

Here, getCurrentExecution() returned null.