Uploaded image for project: 'Isis'
  1. Isis
  2. ISIS-1494

EmailNotificationServiceDefault does not use overriding implementations of EmailService

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.12.0, 1.13.0
    • Fix Version/s: 1.13.1
    • Component/s: Core
    • Labels:
      None

      Description

      EmailNotificationServiceDefault:175 is hard coded to use EmailServiceDefault. This doesn't allow an overriding implementation of the EmailService interface to be used.

        Activity

        Hide
        mricheson Mitchell Richeson added a comment -

        This was identified while using self registration's RegistrationFormPanel to send the verification email. The overriding EmailService was not being used instead of EmailServiceDefault.

        Show
        mricheson Mitchell Richeson added a comment - This was identified while using self registration's RegistrationFormPanel to send the verification email. The overriding EmailService was not being used instead of EmailServiceDefault.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit aefce85d248eca654f94e625b62eaef721dab966 in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=aefce85 ]

        ISIS-1494: EmailNotificationServiceDefault now uses EmailService (interface) rather than the concrete default impl

        Show
        jira-bot ASF subversion and git services added a comment - Commit aefce85d248eca654f94e625b62eaef721dab966 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=aefce85 ] ISIS-1494 : EmailNotificationServiceDefault now uses EmailService (interface) rather than the concrete default impl
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit d532abc8c6f576521e683efde40ad5f1a8dcc4e0 in isis's branch refs/heads/maint-1.13.1 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d532abc ]

        ISIS-1494: EmailNotificationServiceDefault now uses EmailService (interface) rather than the concrete default impl

        Show
        jira-bot ASF subversion and git services added a comment - Commit d532abc8c6f576521e683efde40ad5f1a8dcc4e0 in isis's branch refs/heads/maint-1.13.1 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d532abc ] ISIS-1494 : EmailNotificationServiceDefault now uses EmailService (interface) rather than the concrete default impl

          People

          • Assignee:
            danhaywood Dan Haywood
            Reporter:
            mricheson Mitchell Richeson
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development