Uploaded image for project: 'Isis'
  1. Isis
  2. ISIS-1472

Any attempts to schedule a background job via the RO viewer fail, due to incomplete state. (In fact: actions with commands cannot be invoked via RO viewer).

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.13.0
    • Fix Version/s: 1.13.1
    • Component/s: Core
    • Labels:
      None

      Description

      The issue is that regular commands are not being persisted, at all, under the RO viewer.

      This is because I've made it the responsibility of the viewer to get hold of the current Command (using CommandContext#getCommand()) and to update the "Executor" of the Command to be "USER". This is done by the Wicket viewer. And, similarly, in BackgroundCommandExecution adapter the Executor gets set to "BACKGROUND".

      But in the RO viewer I've not updated this field, so it remains set to its default, "OTHER". This then causes the initialization of the Command (when the initial action is invoked) to be skipped, resulting in no memberIdentifier.

      So, the fix is just for RO viewer to set this field in DomainObjectResourceServerside and DomainServiceResourceServerside.

        Activity

        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 32e01615381e9a3721f61b3b08117d93605fcac6 in isis's branch refs/heads/maint-1.13.1 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=32e0161 ]

        ISIS-1472: set Command#Executor when invoking an action or editing a property.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 32e01615381e9a3721f61b3b08117d93605fcac6 in isis's branch refs/heads/maint-1.13.1 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=32e0161 ] ISIS-1472 : set Command#Executor when invoking an action or editing a property.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 501e890f90d535df43d73a90e14295fadc9f9b64 in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=501e890 ]

        ISIS-1472: set Command#Executor when invoking an action or editing a property.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 501e890f90d535df43d73a90e14295fadc9f9b64 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=501e890 ] ISIS-1472 : set Command#Executor when invoking an action or editing a property.

          People

          • Assignee:
            danhaywood Dan Haywood
            Reporter:
            danhaywood Dan Haywood
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development