Uploaded image for project: 'Isis'
  1. Isis
  2. ISIS-1461

More reliable fix to concurrency exception

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.12.2
    • Fix Version/s: 1.13.0
    • Component/s: Core: Viewer: Wicket
    • Labels:
      None

      Description

      The concurrency exception addressed in 1.12.x has reappeared.

      To reproduce:

      • https://github.com/danhaywood/ddd-london-20160601
      • dev_summer branch
      • create Presenter
      • click 'Create' (the contributed action to propose a session)
      • in the resultant Session, click on the "Other" tab (where the Presenter reference lives)
      • bam, concurrency exception.

      Suggest the fix instead is to postpone the EntityPage#buildGui into the onRender, so that reload all objects on the redirect. Have considered this in the past but had been able to make it work without resorting to this.

        Activity

        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 6dd1a9c497547cdd21325d9ce10a1b599d725138 in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=6dd1a9c ]

        ISIS-1461: defers the call to buildGui on EntityPage to the onRder

        Meaning that reload the objects, and recreate the adapters (and thus versions)
        on the subsequent request after redirect).

        Show
        jira-bot ASF subversion and git services added a comment - Commit 6dd1a9c497547cdd21325d9ce10a1b599d725138 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=6dd1a9c ] ISIS-1461 : defers the call to buildGui on EntityPage to the onRder Meaning that reload the objects, and recreate the adapters (and thus versions) on the subsequent request after redirect).
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 9f5eadda457edec6a68090424b3c91d13acf23a9 in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=9f5eadd ]

        Revert "ISIS-1461: defers the call to buildGui on EntityPage to the onRder"

        This reverts commit 6dd1a9c497547cdd21325d9ce10a1b599d725138.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 9f5eadda457edec6a68090424b3c91d13acf23a9 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=9f5eadd ] Revert " ISIS-1461 : defers the call to buildGui on EntityPage to the onRder" This reverts commit 6dd1a9c497547cdd21325d9ce10a1b599d725138.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 2f67917b59eff89c2fc4d790bb8468ae97af9517 in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=2f67917 ]

        ISIS-1461: alternative fix for concurrency exception when click on link.

        The solution is more localized; just disable concurrency checking when rendering a link.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 2f67917b59eff89c2fc4d790bb8468ae97af9517 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=2f67917 ] ISIS-1461 : alternative fix for concurrency exception when click on link. The solution is more localized; just disable concurrency checking when rendering a link.

          People

          • Assignee:
            danhaywood Dan Haywood
            Reporter:
            danhaywood Dan Haywood
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development