Uploaded image for project: 'Isis'
  1. Isis
  2. ISIS-1454

Hints for drop-downs in Wicket viewer not honoured.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.12.2
    • Fix Version/s: 1.13.0
    • Component/s: Core: Viewer: Wicket
    • Labels:
      None

      Activity

      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 0ab02c23a8028bb6e2507a4af9bae8c779fa00b2 in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=0ab02c2 ]

      ISIS-1454: fixes collection hints in the Wicket viewer.

      Various elements of each page - tab, page number, showAll and collection selector - can be set by hints taken from either the URL or from the session (via HintStore). The hint key is based on the (Wicket) component path plus additional qualifier, eg 'showAll'.

      This commit fixes an issue with the collection selector and the page number hints, which were not being honoured. The problem was down to passing in the incorrect component in some cases... now always passes in the CollectionSelectorPanel.

      Show
      jira-bot ASF subversion and git services added a comment - Commit 0ab02c23a8028bb6e2507a4af9bae8c779fa00b2 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=0ab02c2 ] ISIS-1454 : fixes collection hints in the Wicket viewer. Various elements of each page - tab, page number, showAll and collection selector - can be set by hints taken from either the URL or from the session (via HintStore). The hint key is based on the (Wicket) component path plus additional qualifier, eg 'showAll'. This commit fixes an issue with the collection selector and the page number hints, which were not being honoured. The problem was down to passing in the incorrect component in some cases... now always passes in the CollectionSelectorPanel.
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit f58e72ec2870cf19dca43b7c9443b8e31445877f in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=f58e72e ]

      ISIS-1454: fixes serialization issue

      The anonymous class implementation of Provider<Component> (to support lazy provision of the selectorDropDown) was not serializable, leading to the usual Wicket complaining.

      Show
      jira-bot ASF subversion and git services added a comment - Commit f58e72ec2870cf19dca43b7c9443b8e31445877f in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=f58e72e ] ISIS-1454 : fixes serialization issue The anonymous class implementation of Provider<Component> (to support lazy provision of the selectorDropDown) was not serializable, leading to the usual Wicket complaining.

        People

        • Assignee:
          danhaywood Dan Haywood
          Reporter:
          danhaywood Dan Haywood
        • Votes:
          0 Vote for this issue
          Watchers:
          2 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development