Uploaded image for project: 'Isis'
  1. Isis
  2. ISIS-1447

Avoid possible race-condition resulting in 500 errors under the Restful Objects viewer

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.12.2
    • Fix Version/s: 1.13.0
    • Component/s: Core: Security: Shiro
    • Labels:
      None

      Description

      As per http://markmail.org/message/hsjljwgkhhrzxbrm

      Instead, auto-logout if find that session is already authenticated.

      In case this new approach introduces more problems than it resolves, allow the the current (occasionally broken) behaviour to be re-enabled using a configuration parameter.

        Activity

        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 38291d7da6de894d16d7ee92e93a20fa0a545095 in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=38291d7 ]

        ISIS-1447: fixes tiny typo in docs for previous commit

        Show
        jira-bot ASF subversion and git services added a comment - Commit 38291d7da6de894d16d7ee92e93a20fa0a545095 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=38291d7 ] ISIS-1447 : fixes tiny typo in docs for previous commit
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 93773e69dadc4c64450b8483aba9ce6a55245734 in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=93773e6 ]

        ISIS-1447: disables behaviour that (we believe) may cause 500 errors for Restful Objects server (Shiro authentication).

        As per http://markmail.org/message/hsjljwgkhhrzxbrm, we believe that the auto-logout behaviour within the IsisSessionFilter for Restful Objects, if configured to use Shiro, may result in a 500 errors in certain race conditions. This commit removes this auto-logout behaviour (simply continue to use the existing Shiro credentials). The original behaviour can be reinstated using a new configuration parameter.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 93773e69dadc4c64450b8483aba9ce6a55245734 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=93773e6 ] ISIS-1447 : disables behaviour that (we believe) may cause 500 errors for Restful Objects server (Shiro authentication). As per http://markmail.org/message/hsjljwgkhhrzxbrm , we believe that the auto-logout behaviour within the IsisSessionFilter for Restful Objects, if configured to use Shiro, may result in a 500 errors in certain race conditions. This commit removes this auto-logout behaviour (simply continue to use the existing Shiro credentials). The original behaviour can be reinstated using a new configuration parameter.

          People

          • Assignee:
            danhaywood Dan Haywood
            Reporter:
            danhaywood Dan Haywood
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development