Uploaded image for project: 'Isis'
  1. Isis
  2. ISIS-1443

Refactor specloader so that specs for domain services are marked as a service from the get-go

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.12.2
    • Fix Version/s: 1.13.0
    • Component/s: Core
    • Labels:
      None

      Description

      ie pass in through the constructor.

      (Our previous design had the ObjectSpecification#markAsService method called later on, so this refactoring removes that method).

        Activity

        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 3dffc2d96e240982d16131d57d34fc8f54d1292c in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=3dffc2d ]

        ISIS-1443: deals with subclass domain services

        whereby the superclass is also a domain service but is only loaded
        implicitly by walking the type hierarchy. This commit ensures that
        if that superclass is annotated with @DomainService then it will
        correctly be created with a service ObjectSpec

        Show
        jira-bot ASF subversion and git services added a comment - Commit 3dffc2d96e240982d16131d57d34fc8f54d1292c in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=3dffc2d ] ISIS-1443 : deals with subclass domain services whereby the superclass is also a domain service but is only loaded implicitly by walking the type hierarchy. This commit ensures that if that superclass is annotated with @DomainService then it will correctly be created with a service ObjectSpec
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 25149b05411fd2d88c4b02f6b8b9f13fb7850b1c in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=25149b0 ]

        ISIS-1443: removes markAsService from ObjectSpecification, instead specify through the constructor.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 25149b05411fd2d88c4b02f6b8b9f13fb7850b1c in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=25149b0 ] ISIS-1443 : removes markAsService from ObjectSpecification, instead specify through the constructor.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 3dffc2d96e240982d16131d57d34fc8f54d1292c in isis's branch refs/heads/ISIS-1427 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=3dffc2d ]

        ISIS-1443: deals with subclass domain services

        whereby the superclass is also a domain service but is only loaded
        implicitly by walking the type hierarchy. This commit ensures that
        if that superclass is annotated with @DomainService then it will
        correctly be created with a service ObjectSpec

        Show
        jira-bot ASF subversion and git services added a comment - Commit 3dffc2d96e240982d16131d57d34fc8f54d1292c in isis's branch refs/heads/ ISIS-1427 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=3dffc2d ] ISIS-1443 : deals with subclass domain services whereby the superclass is also a domain service but is only loaded implicitly by walking the type hierarchy. This commit ensures that if that superclass is annotated with @DomainService then it will correctly be created with a service ObjectSpec
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 25149b05411fd2d88c4b02f6b8b9f13fb7850b1c in isis's branch refs/heads/ISIS-1427 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=25149b0 ]

        ISIS-1443: removes markAsService from ObjectSpecification, instead specify through the constructor.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 25149b05411fd2d88c4b02f6b8b9f13fb7850b1c in isis's branch refs/heads/ ISIS-1427 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=25149b0 ] ISIS-1443 : removes markAsService from ObjectSpecification, instead specify through the constructor.

          People

          • Assignee:
            danhaywood Dan Haywood
            Reporter:
            danhaywood Dan Haywood
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development