Uploaded image for project: 'Isis'
  1. Isis
  2. ISIS-1441

Remove subclass of AuthenticationManagerStandard in isis-core-runtime.

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.12.2
    • Fix Version/s: 1.13.0
    • Component/s: Core
    • Labels:
      None

      Description

      Simplifying the codebase; with a small amount of refactoring, can move the classes to isis-core-metamodel and reduce the class hierarchy.

        Activity

        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 364e5b9b64d6e831fecaec559ef649029c746ede in isis's branch refs/heads/ISIS-1427 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=364e5b9 ]

        ISIS-1441: removes AuthenticationManagerStandardForDfltRuntime, instead use AuthenticationManagerStandard.

        The supporting classes move from isis-core-runtime to isis-core-metamodel. Because the Authenticator subclasses relied on DeploymentType (only available in the isis-core-runtime), these instead depend on DeploymentCategory (in isis-core-metamodel).

        This also includes a minor refactoring in the closeSession stuff... previously we called closeSession on AuthenticationManagerStandardForDfltRuntime, that in turn called IsisSessionFactory#closeSession() in order to clear the threadlocal holding the current session. However, IsisSessionFactory is part of isis-core-runtime so this design doesn't work. However, there is only one caller of closeSession, namely UserResourceServerside (the RO viewer). The refactoring is therefore easy enough... just have UserResourceServerside make the call to IsisSessionFactory.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 364e5b9b64d6e831fecaec559ef649029c746ede in isis's branch refs/heads/ ISIS-1427 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=364e5b9 ] ISIS-1441 : removes AuthenticationManagerStandardForDfltRuntime, instead use AuthenticationManagerStandard. The supporting classes move from isis-core-runtime to isis-core-metamodel. Because the Authenticator subclasses relied on DeploymentType (only available in the isis-core-runtime), these instead depend on DeploymentCategory (in isis-core-metamodel). This also includes a minor refactoring in the closeSession stuff... previously we called closeSession on AuthenticationManagerStandardForDfltRuntime, that in turn called IsisSessionFactory#closeSession() in order to clear the threadlocal holding the current session. However, IsisSessionFactory is part of isis-core-runtime so this design doesn't work. However, there is only one caller of closeSession, namely UserResourceServerside (the RO viewer). The refactoring is therefore easy enough... just have UserResourceServerside make the call to IsisSessionFactory.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit ed318639be47e243cf2e7628065f967dd386e0c1 in isis's branch refs/heads/ISIS-1427 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=ed31863 ]

        ISIS-1441: fixes unit tests

        Show
        jira-bot ASF subversion and git services added a comment - Commit ed318639be47e243cf2e7628065f967dd386e0c1 in isis's branch refs/heads/ ISIS-1427 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=ed31863 ] ISIS-1441 : fixes unit tests
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 364e5b9b64d6e831fecaec559ef649029c746ede in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=364e5b9 ]

        ISIS-1441: removes AuthenticationManagerStandardForDfltRuntime, instead use AuthenticationManagerStandard.

        The supporting classes move from isis-core-runtime to isis-core-metamodel. Because the Authenticator subclasses relied on DeploymentType (only available in the isis-core-runtime), these instead depend on DeploymentCategory (in isis-core-metamodel).

        This also includes a minor refactoring in the closeSession stuff... previously we called closeSession on AuthenticationManagerStandardForDfltRuntime, that in turn called IsisSessionFactory#closeSession() in order to clear the threadlocal holding the current session. However, IsisSessionFactory is part of isis-core-runtime so this design doesn't work. However, there is only one caller of closeSession, namely UserResourceServerside (the RO viewer). The refactoring is therefore easy enough... just have UserResourceServerside make the call to IsisSessionFactory.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 364e5b9b64d6e831fecaec559ef649029c746ede in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=364e5b9 ] ISIS-1441 : removes AuthenticationManagerStandardForDfltRuntime, instead use AuthenticationManagerStandard. The supporting classes move from isis-core-runtime to isis-core-metamodel. Because the Authenticator subclasses relied on DeploymentType (only available in the isis-core-runtime), these instead depend on DeploymentCategory (in isis-core-metamodel). This also includes a minor refactoring in the closeSession stuff... previously we called closeSession on AuthenticationManagerStandardForDfltRuntime, that in turn called IsisSessionFactory#closeSession() in order to clear the threadlocal holding the current session. However, IsisSessionFactory is part of isis-core-runtime so this design doesn't work. However, there is only one caller of closeSession, namely UserResourceServerside (the RO viewer). The refactoring is therefore easy enough... just have UserResourceServerside make the call to IsisSessionFactory.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit ed318639be47e243cf2e7628065f967dd386e0c1 in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=ed31863 ]

        ISIS-1441: fixes unit tests

        Show
        jira-bot ASF subversion and git services added a comment - Commit ed318639be47e243cf2e7628065f967dd386e0c1 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=ed31863 ] ISIS-1441 : fixes unit tests

          People

          • Assignee:
            danhaywood Dan Haywood
            Reporter:
            danhaywood Dan Haywood
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development