Uploaded image for project: 'Isis'
  1. Isis
  2. ISIS-1428

Remove unnecessary 'synchronized' modifiers

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.12.1
    • Fix Version/s: 1.13.0
    • Component/s: Core
    • Labels:
      None

      Activity

      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit ccfcfe79cda641dfbdbcbfadb4a940a1d45ca186 in isis's branch refs/heads/ISIS-1427 from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=ccfcfe7 ]

      ISIS-1428: rationalizing and simplifying IsisComponentProvider hierarchy. Removing ability to override services and installable fixtures within IsisSystemForTest.Builder. Making AppManifest mandatory.

      Show
      jira-bot ASF subversion and git services added a comment - Commit ccfcfe79cda641dfbdbcbfadb4a940a1d45ca186 in isis's branch refs/heads/ ISIS-1427 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=ccfcfe7 ] ISIS-1428 : rationalizing and simplifying IsisComponentProvider hierarchy. Removing ability to override services and installable fixtures within IsisSystemForTest.Builder. Making AppManifest mandatory.
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 698493f6ce80a45ee4e23a9406380385787c8b66 in isis's branch refs/heads/ISIS-1427 from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=698493f ]

      ISIS-1428: removing the ability to override services in IsisSystemForTest (instead, use AppManifest).

      Show
      jira-bot ASF subversion and git services added a comment - Commit 698493f6ce80a45ee4e23a9406380385787c8b66 in isis's branch refs/heads/ ISIS-1427 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=698493f ] ISIS-1428 : removing the ability to override services in IsisSystemForTest (instead, use AppManifest).
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 7ac476c7c8f453cbb8b041f0d88bd62d28f497e1 in isis's branch refs/heads/ISIS-1427 from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=7ac476c ]

      ISIS-1428: removed JavaReflectorInstaller, removing the duplicated code in IsisComponentProviderDefault2. NB: removed ability to override MetaModelValidator.

      Show
      jira-bot ASF subversion and git services added a comment - Commit 7ac476c7c8f453cbb8b041f0d88bd62d28f497e1 in isis's branch refs/heads/ ISIS-1427 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=7ac476c ] ISIS-1428 : removed JavaReflectorInstaller, removing the duplicated code in IsisComponentProviderDefault2. NB: removed ability to override MetaModelValidator.
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 8d4acc559b78587cd907caa62f8bfc187c6e637a in isis's branch refs/heads/ISIS-1427 from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=8d4acc5 ]

      ISIS-1428: removing SpecificationLoaderInstaller, just use the JavaReflectorInstaller directly; JavaReflectorInstaller no longer inherit from InstallerAbstract

      Show
      jira-bot ASF subversion and git services added a comment - Commit 8d4acc559b78587cd907caa62f8bfc187c6e637a in isis's branch refs/heads/ ISIS-1427 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=8d4acc5 ] ISIS-1428 : removing SpecificationLoaderInstaller, just use the JavaReflectorInstaller directly; JavaReflectorInstaller no longer inherit from InstallerAbstract
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit f6bf4ea38bf53f60d9cdbe6e4cbff2d3e5426fe0 in isis's branch refs/heads/ISIS-1427 from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=f6bf4ea ]

      ISIS-1428: removing Installer#getType(), since not used.

      Show
      jira-bot ASF subversion and git services added a comment - Commit f6bf4ea38bf53f60d9cdbe6e4cbff2d3e5426fe0 in isis's branch refs/heads/ ISIS-1427 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=f6bf4ea ] ISIS-1428 : removing Installer#getType(), since not used.
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit bcb5bc61db02a14056d6b023db6317c736eaceb7 in isis's branch refs/heads/ISIS-1427 from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=bcb5bc6 ]

      ISIS-1428: removing PersistenceMechanismInstaller and implementation, inlining code

      Show
      jira-bot ASF subversion and git services added a comment - Commit bcb5bc61db02a14056d6b023db6317c736eaceb7 in isis's branch refs/heads/ ISIS-1427 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=bcb5bc6 ] ISIS-1428 : removing PersistenceMechanismInstaller and implementation, inlining code
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit a639d0f46d760b59e7c20adaaf7a79cc65e99df6 in isis's branch refs/heads/ISIS-1427 from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=a639d0f ]

      ISIS-1428: removing Splash (unused enum) and OptionHandlerNoSplash.

      Show
      jira-bot ASF subversion and git services added a comment - Commit a639d0f46d760b59e7c20adaaf7a79cc65e99df6 in isis's branch refs/heads/ ISIS-1427 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=a639d0f ] ISIS-1428 : removing Splash (unused enum) and OptionHandlerNoSplash.
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit b8dcd68e7431dd3f1da9564bc6fcae364779ac9e in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=b8dcd68 ]

      ISIS-1428: refactoring/renaming for synchronized statusFor(...) method.

      Show
      jira-bot ASF subversion and git services added a comment - Commit b8dcd68e7431dd3f1da9564bc6fcae364779ac9e in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=b8dcd68 ] ISIS-1428 : refactoring/renaming for synchronized statusFor(...) method.
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 9c86bb5c8b042a59a295643e5a5ee3678fb3a89b in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=9c86bb5 ]

      ISIS-1428: SpecificationLoader, don't call synchronized method if no need.

      Show
      jira-bot ASF subversion and git services added a comment - Commit 9c86bb5c8b042a59a295643e5a5ee3678fb3a89b in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=9c86bb5 ] ISIS-1428 : SpecificationLoader, don't call synchronized method if no need.
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 549c60754efcce09318d5d0beee359f245b74c7c in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=549c607 ]

      ISIS-1428: SpecificationLoader, synchronize using syncrhonized modifier rather than using synchronize keyword.

      Show
      jira-bot ASF subversion and git services added a comment - Commit 549c60754efcce09318d5d0beee359f245b74c7c in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=549c607 ] ISIS-1428 : SpecificationLoader, synchronize using syncrhonized modifier rather than using synchronize keyword.
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 842af23d145a9c56196a06c02e0899abf733fa5e in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=842af23 ]

      ISIS-1428: SpecificationLoader, synchronize on field.

      Show
      jira-bot ASF subversion and git services added a comment - Commit 842af23d145a9c56196a06c02e0899abf733fa5e in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=842af23 ] ISIS-1428 : SpecificationLoader, synchronize on field.
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 8399564bcfb4fe9c97f1ea82c31b31f7c91be73f in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=8399564 ]

      ISIS-1428: removing unnecessary 'synchronized' modified for IsisConfigurationBuilder - this is only ever called by a single thread at startup.

      Show
      jira-bot ASF subversion and git services added a comment - Commit 8399564bcfb4fe9c97f1ea82c31b31f7c91be73f in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=8399564 ] ISIS-1428 : removing unnecessary 'synchronized' modified for IsisConfigurationBuilder - this is only ever called by a single thread at startup.

        People

        • Assignee:
          danhaywood Dan Haywood
          Reporter:
          danhaywood Dan Haywood
        • Votes:
          0 Vote for this issue
          Watchers:
          2 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development