Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.12.2
    • Fix Version/s: 1.13.0
    • Component/s: Core
    • Labels:
      None

      Description

      simplify and rationalize IsisSystem, IsisContext, IsisSessionFactory, IsisComponentProvider

      Also only allow AppManifest to be used to bootstrap integration tests.

        Activity

        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit b6b1bca602c1cd9baf51fc74d7477907ac77d4e1 in isis's branch refs/heads/ISIS-1427 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=b6b1bca ]

        ISIS-1427: minor refactoring of IsisConfigurationForJdoIntegTests to allow reuse within custom AppManifests in integration tests

        Show
        jira-bot ASF subversion and git services added a comment - Commit b6b1bca602c1cd9baf51fc74d7477907ac77d4e1 in isis's branch refs/heads/ ISIS-1427 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=b6b1bca ] ISIS-1427 : minor refactoring of IsisConfigurationForJdoIntegTests to allow reuse within custom AppManifests in integration tests
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit c88f44ffd33c7c38917969a198b26c02224be13f in isis's branch refs/heads/ISIS-1427 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=c88f44f ]

        ISIS-1427: reinstating IsisSystemForTest#setUpSystem to avoid too many unnecessary breakages.

        Show
        jira-bot ASF subversion and git services added a comment - Commit c88f44ffd33c7c38917969a198b26c02224be13f in isis's branch refs/heads/ ISIS-1427 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=c88f44f ] ISIS-1427 : reinstating IsisSystemForTest#setUpSystem to avoid too many unnecessary breakages.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 95c3ecc1144d9093dc71088a173480ab7a64cfcb in isis's branch refs/heads/ISIS-1427 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=95c3ecc ]

        ISIS-1427: completes rationalization for minimizing calls to IsisContext#getIsisSessionFactory static.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 95c3ecc1144d9093dc71088a173480ab7a64cfcb in isis's branch refs/heads/ ISIS-1427 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=95c3ecc ] ISIS-1427 : completes rationalization for minimizing calls to IsisContext#getIsisSessionFactory static.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 69b4859f27ce857e9af75b7d1ef0ae7b42e5cc2c in isis's branch refs/heads/ISIS-1427 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=69b4859 ]

        ISIS-1427: consolidating to only necessary calls to IsisContext#getIsisSessionFactory; also fully qualify @Inject (as either javax or com.google) throughout.

        The rationale is to use dependency injection where possible, and where have all code that requires components to do so through IsisContext#getIsisSessionFactory (and nowhere else).

        Show
        jira-bot ASF subversion and git services added a comment - Commit 69b4859f27ce857e9af75b7d1ef0ae7b42e5cc2c in isis's branch refs/heads/ ISIS-1427 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=69b4859 ] ISIS-1427 : consolidating to only necessary calls to IsisContext#getIsisSessionFactory; also fully qualify @Inject (as either javax or com.google) throughout. The rationale is to use dependency injection where possible, and where have all code that requires components to do so through IsisContext#getIsisSessionFactory (and nowhere else).
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1032ada1f2a7ffd04e0252b240a3c6bca04d4877 in isis's branch refs/heads/ISIS-1427 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=1032ada ]

        ISIS-1427: removes use of IsisContext within domain services.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1032ada1f2a7ffd04e0252b240a3c6bca04d4877 in isis's branch refs/heads/ ISIS-1427 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=1032ada ] ISIS-1427 : removes use of IsisContext within domain services.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 346a153407029766b30c132b0b40298fb6b6acd2 in isis's branch refs/heads/ISIS-1427 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=346a153 ]

        ISIS-1427: renames methods in IsisSystemForTest, rationalizes functionality between IsisSystem and IsisSessionFactory

        The intent being that IsisSystem is just a builder for IsisSessionFactory. The responsibility for calling @PostConstruct and @PreDestroy was held by IsisSystem, meaning that it was necessary to call both shutdown on IsisSessionFactory and then on IsisSystem. Moving the responsibility for services initialization/destroy into IsisSessionFactory therefore simplifies the callers; there is no need to hold onto the IsisSystem, just use the IsisSessionFactory.

        As part of this the DeploymentCategoryProviderDefault is now a fallback service, added into ServicesInjector prior to init'ing the guice IsisInjectModel (which creates the IsisSystem and thence IsisSessionFactory).

        Show
        jira-bot ASF subversion and git services added a comment - Commit 346a153407029766b30c132b0b40298fb6b6acd2 in isis's branch refs/heads/ ISIS-1427 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=346a153 ] ISIS-1427 : renames methods in IsisSystemForTest, rationalizes functionality between IsisSystem and IsisSessionFactory The intent being that IsisSystem is just a builder for IsisSessionFactory. The responsibility for calling @PostConstruct and @PreDestroy was held by IsisSystem, meaning that it was necessary to call both shutdown on IsisSessionFactory and then on IsisSystem. Moving the responsibility for services initialization/destroy into IsisSessionFactory therefore simplifies the callers; there is no need to hold onto the IsisSystem, just use the IsisSessionFactory. As part of this the DeploymentCategoryProviderDefault is now a fallback service, added into ServicesInjector prior to init'ing the guice IsisInjectModel (which creates the IsisSystem and thence IsisSessionFactory).
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit eb6d4a8c92e923078779fe4794e238ff50223d22 in isis's branch refs/heads/ISIS-1427 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=eb6d4a8 ]

        ISIS-1427: fix up unit tests that are failing...

        ... per the preceding deletion of Localization and also the IsisContext refactoring

        Show
        jira-bot ASF subversion and git services added a comment - Commit eb6d4a8c92e923078779fe4794e238ff50223d22 in isis's branch refs/heads/ ISIS-1427 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=eb6d4a8 ] ISIS-1427 : fix up unit tests that are failing... ... per the preceding deletion of Localization and also the IsisContext refactoring
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 83de0dc05be52525a01ce50f211bffe2aa513488 in isis's branch refs/heads/ISIS-1427 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=83de0dc ]

        ISIS-1427: simplifying IsisContext and minimizing calls to it; also removed Localization (unused)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 83de0dc05be52525a01ce50f211bffe2aa513488 in isis's branch refs/heads/ ISIS-1427 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=83de0dc ] ISIS-1427 : simplifying IsisContext and minimizing calls to it; also removed Localization (unused)
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit d02540d9b2af2f48ed9597163f35a06315ce48c2 in isis's branch refs/heads/ISIS-1427 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d02540d ]

        ISIS-1427: use DeploymentCategory rather than DeploymentType throughout (except in very initial bootstrapping).

        Also:

        • no need for IsisInjectModel to expose DeploymentType or IsisConfiguration as @Provides @Singleton
        • remove DeploymentType from IsisComponentProvider classes (plays no part), just pass to IsisSystem directly.
        • allow IsisSystem to be created from a non-null AppManifest (internally creates a default IsisComponentProviderDefault2)
        Show
        jira-bot ASF subversion and git services added a comment - Commit d02540d9b2af2f48ed9597163f35a06315ce48c2 in isis's branch refs/heads/ ISIS-1427 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d02540d ] ISIS-1427 : use DeploymentCategory rather than DeploymentType throughout (except in very initial bootstrapping). Also: no need for IsisInjectModel to expose DeploymentType or IsisConfiguration as @Provides @Singleton remove DeploymentType from IsisComponentProvider classes (plays no part), just pass to IsisSystem directly. allow IsisSystem to be created from a non-null AppManifest (internally creates a default IsisComponentProviderDefault2)
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 63178f54a303aae3b6a79d571e33168394bfc0d8 in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=63178f54 ]

        ISIS-1427: AuthenticationSession eagerly creates its MessageBroker (rather than have IsisTransactionManager set it lazily).

        Ratonale:

        • simpler code, also removes a 'synchronized'
        Show
        jira-bot ASF subversion and git services added a comment - Commit 63178f54a303aae3b6a79d571e33168394bfc0d8 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=63178f54 ] ISIS-1427 : AuthenticationSession eagerly creates its MessageBroker (rather than have IsisTransactionManager set it lazily). Ratonale: simpler code, also removes a 'synchronized'

          People

          • Assignee:
            danhaywood Dan Haywood
            Reporter:
            danhaywood Dan Haywood
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development