Uploaded image for project: 'Isis'
  1. Isis
  2. ISIS-1422

Autocomplete publishes events to the event bus.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.12.1
    • Fix Version/s: 1.13.0
    • Component/s: None
    • Labels:
      None

      Activity

      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit a322518276504ab788b46a7a777b30230727f909 in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=a322518 ]

      ISIS-1422: use PublishingServiceInternal's withPublishingSuppressed wormhole to stop publishing when invoke an action for autoComplete.

      Show
      jira-bot ASF subversion and git services added a comment - Commit a322518276504ab788b46a7a777b30230727f909 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=a322518 ] ISIS-1422 : use PublishingServiceInternal's withPublishingSuppressed wormhole to stop publishing when invoke an action for autoComplete.
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 0f5508038f7090bb3c1eed5a9e7fb09aa02e6311 in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=0f55080 ]

      ISIS-1422: fixing unit tests.

      Show
      jira-bot ASF subversion and git services added a comment - Commit 0f5508038f7090bb3c1eed5a9e7fb09aa02e6311 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=0f55080 ] ISIS-1422 : fixing unit tests.
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 935a5d947149544e3c15b44291676d0fa46eeed8 in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=935a5d9 ]

      ISIS-1422: refactoring (no functional change) - looking up components from ServicesInjector rather than pass them in.

      for misc facets (ActionInvocationFacet, MaxLengthFacet, Encodable, RegEx, MultiLine)

      Show
      jira-bot ASF subversion and git services added a comment - Commit 935a5d947149544e3c15b44291676d0fa46eeed8 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=935a5d9 ] ISIS-1422 : refactoring (no functional change) - looking up components from ServicesInjector rather than pass them in. for misc facets (ActionInvocationFacet, MaxLengthFacet, Encodable, RegEx, MultiLine)
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 28bd6dd52f37ace0bf10f97f0af7af8b9132f1f6 in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=28bd6dd ]

      ISIS-1422: refactoring (no functional change) - completely eliminated ValueSemanticsProviderContext, just use ServicesInjector throughout, and don't pass IsisConfiguration to VSP either, since derivable from ServicesInjector.

      Also:

      • made ConfigurationServiceInternal extend from IsisConfiguration (IsisConfigurationDefault is the only impl anyway)
      • removed unnecessary casts to IsisConfiguration
      • removed components passed into AutoCompleteFacetAbstract, since all derivable from ServicesInjector.
      Show
      jira-bot ASF subversion and git services added a comment - Commit 28bd6dd52f37ace0bf10f97f0af7af8b9132f1f6 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=28bd6dd ] ISIS-1422 : refactoring (no functional change) - completely eliminated ValueSemanticsProviderContext, just use ServicesInjector throughout, and don't pass IsisConfiguration to VSP either, since derivable from ServicesInjector. Also: made ConfigurationServiceInternal extend from IsisConfiguration (IsisConfigurationDefault is the only impl anyway) removed unnecessary casts to IsisConfiguration removed components passed into AutoCompleteFacetAbstract, since all derivable from ServicesInjector.
      Hide
      danhaywood Dan Haywood added a comment -

      After annotating with @Action(semantics=Semantics.SAFE) it is fixed. Question is would we exclude autocomplete altogether or should we annotate with @Action(semantics=Semantics.SAFE)

      Show
      danhaywood Dan Haywood added a comment - After annotating with @Action(semantics=Semantics.SAFE) it is fixed. Question is would we exclude autocomplete altogether or should we annotate with @Action(semantics=Semantics.SAFE)

        People

        • Assignee:
          danhaywood Dan Haywood
          Reporter:
          danhaywood Dan Haywood
        • Votes:
          0 Vote for this issue
          Watchers:
          2 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development