Uploaded image for project: 'Isis'
  1. Isis
  2. ISIS-1406

Refactor IsisConfigurationDefault and the metamodel.ConfigurationService into an internal domain service

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.12.1
    • Fix Version/s: 1.13.0
    • Component/s: Core
    • Labels:
      None

      Description

      Moving towards CDI-style injection, removing our home-grown stuff.

        Activity

        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit dcaab8ead2a2bf2fd64d1e55ca69dc43c3a7297e in isis's branch refs/heads/ISIS-1406 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=dcaab8e ]

        ISIS-1406: refactoring IsisConfigurationBuilder and IsisConfiguration (WIP)

        Show
        jira-bot ASF subversion and git services added a comment - Commit dcaab8ead2a2bf2fd64d1e55ca69dc43c3a7297e in isis's branch refs/heads/ ISIS-1406 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=dcaab8e ] ISIS-1406 : refactoring IsisConfigurationBuilder and IsisConfiguration (WIP)
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 7456588834a18ff4b47e59af93e1ccaa29912457 in isis's branch refs/heads/ISIS-1406 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=7456588 ]

        ISIS-1406: lots more refactoring around IsisConfiguration and IsisConfigurationBuilder.

        specifically:

        • simplified IsisConfigurationBuilder, now a single class (rather than an interface with 4 different impls, only 2 of which were used).
        • removed IsisRunner, so that the command line options are now a responsibility of the IsisConfigurationBuilder
        • IsisConfigurationBuilder is passed from o.a.i.WebServer to IsisWicketApplication (not just the "primers"
        • removed OptionValidator, wasn't being used
        • FacetFactoryAbstract responsible for providing IsisConfiguration to all subclass impls
        • InstallerLookup simplified, no longer responsible for appending to the IsisConfigurationBuilder
        • InstallerAbstract impls now all have the IsisConfiguration injected into them (constructor injection).
        • removed duplication between IsisWebAppBootstrapper and IsisWicketApplication

        As of this commit the app runs, but the fixtures are not being automatically installed.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 7456588834a18ff4b47e59af93e1ccaa29912457 in isis's branch refs/heads/ ISIS-1406 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=7456588 ] ISIS-1406 : lots more refactoring around IsisConfiguration and IsisConfigurationBuilder. specifically: simplified IsisConfigurationBuilder, now a single class (rather than an interface with 4 different impls, only 2 of which were used). removed IsisRunner, so that the command line options are now a responsibility of the IsisConfigurationBuilder IsisConfigurationBuilder is passed from o.a.i.WebServer to IsisWicketApplication (not just the "primers" removed OptionValidator, wasn't being used FacetFactoryAbstract responsible for providing IsisConfiguration to all subclass impls InstallerLookup simplified, no longer responsible for appending to the IsisConfigurationBuilder InstallerAbstract impls now all have the IsisConfiguration injected into them (constructor injection). removed duplication between IsisWebAppBootstrapper and IsisWicketApplication As of this commit the app runs, but the fixtures are not being automatically installed.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit ddd0cf4fb6bd93a3af73064e1ed2d858cccc0390 in isis's branch refs/heads/ISIS-1406 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=ddd0cf4 ]

        ISIS-1406: unit tests now passing for isis-core-metamodel.

        Show
        jira-bot ASF subversion and git services added a comment - Commit ddd0cf4fb6bd93a3af73064e1ed2d858cccc0390 in isis's branch refs/heads/ ISIS-1406 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=ddd0cf4 ] ISIS-1406 : unit tests now passing for isis-core-metamodel.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit d262830f060d0a7b279e79adfead4ecb580ba13b in isis's branch refs/heads/ISIS-1406 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d262830 ]

        ISIS-1406: simpleapp integ tests also now running

        Show
        jira-bot ASF subversion and git services added a comment - Commit d262830f060d0a7b279e79adfead4ecb580ba13b in isis's branch refs/heads/ ISIS-1406 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d262830 ] ISIS-1406 : simpleapp integ tests also now running
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 874e8bad162255c644f133f4e48eeb00d7c4adc9 in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=874e8ba ]

        ISIS-1406: fixing regression... isis.config.dir override was not being picked up.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 874e8bad162255c644f133f4e48eeb00d7c4adc9 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=874e8ba ] ISIS-1406 : fixing regression... isis.config.dir override was not being picked up.

          People

          • Assignee:
            danhaywood Dan Haywood
            Reporter:
            danhaywood Dan Haywood
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development