Uploaded image for project: 'Isis'
  1. Isis
  2. ISIS-1398

Refactor PropertySetterFacet to follow the pattern for ActionInvocationFacet.

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.12.1
    • Fix Version/s: 1.13.0
    • Component/s: Core
    • Labels:

      Description

      In particular with respect to setting up commands.

        Activity

        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 22497648fbc6a28a980eff46363474ad2496ee95 in isis's branch refs/heads/ISIS-1291 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=2249764 ]

        ISIS-1398: inlining/simplifying PropertySetterOfClearFacet so that only emit events when InteractionContext is setup.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 22497648fbc6a28a980eff46363474ad2496ee95 in isis's branch refs/heads/ ISIS-1291 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=2249764 ] ISIS-1398 : inlining/simplifying PropertySetterOfClearFacet so that only emit events when InteractionContext is setup.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit bb54a109f1269c7e67ebc254117a47d163a5b2f5 in isis's branch refs/heads/ISIS-1291 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=bb54a10 ]

        ISIS-1398: removing duplication in the PropertySetterFacet and PropertyClearFacet hierarchies.

        Specifically:

        • removed PropertyClearFacetForDomainEventAbstract
        • generalized the equivalent setter abstract to delegate to either an underlying setterFacet or clearFacet
        Show
        jira-bot ASF subversion and git services added a comment - Commit bb54a109f1269c7e67ebc254117a47d163a5b2f5 in isis's branch refs/heads/ ISIS-1291 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=bb54a10 ] ISIS-1398 : removing duplication in the PropertySetterFacet and PropertyClearFacet hierarchies. Specifically: removed PropertyClearFacetForDomainEventAbstract generalized the equivalent setter abstract to delegate to either an underlying setterFacet or clearFacet
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 6341730eae555bb069b80ee8fa84abfb65771476 in isis's branch refs/heads/ISIS-1291 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=6341730 ]

        ISIS-1398: moving the command stuff to PropertySetter/ClearFacetForDomainEventAbstract, and out of the wrapped original PropertySetterFacet or PropertyClearFacet.

        Also:

        • remove DomainEventHelper#hasEventBusService() since will always return true
        Show
        jira-bot ASF subversion and git services added a comment - Commit 6341730eae555bb069b80ee8fa84abfb65771476 in isis's branch refs/heads/ ISIS-1291 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=6341730 ] ISIS-1398 : moving the command stuff to PropertySetter/ClearFacetForDomainEventAbstract, and out of the wrapped original PropertySetterFacet or PropertyClearFacet. Also: remove DomainEventHelper#hasEventBusService() since will always return true

          People

          • Assignee:
            danhaywood Dan Haywood
            Reporter:
            danhaywood Dan Haywood
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development