Uploaded image for project: 'Isis'
  1. Isis
  2. ISIS-1390

Provide a default CommandService, to return CommandDefault.

    Details

    • Type: New Feature
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.12.1
    • Fix Version/s: 1.13.0
    • Component/s: Core
    • Labels:

      Description

      This will simplify implementation wherever the CommandService is looked up. Currently we require null guards.

        Activity

        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 2f3b107282f5bb38b1bdddf1bd1af3020459aa2e in isis's branch refs/heads/ISIS-1291 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=2f3b107 ]

        ISIS-1390: minor refactorings (inlining of methods), now easy to track usage of the CommandService

        Show
        jira-bot ASF subversion and git services added a comment - Commit 2f3b107282f5bb38b1bdddf1bd1af3020459aa2e in isis's branch refs/heads/ ISIS-1291 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=2f3b107 ] ISIS-1390 : minor refactorings (inlining of methods), now easy to track usage of the CommandService
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 98a0c2f8032f49178e9a048d4139e4d0af66c594 in isis's branch refs/heads/ISIS-1291 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=98a0c2f ]

        ISIS-1390: default CommandServiceDefault. Also simplifying the relationship between IsisTransaction and Command, and how the Command object is initialized.

        Also:
        ... deprecating CommandService#startTransaction(...), make it the responsibility of IsisTransactionManager to populate the transactionId of the Command in all cases.
        ... simplifying logic in IsisTransaction; the Command is only just created, so will never have a transactionId to reuse. The design is now simply for the IsisTransactionManager to create a new UUID and set on both the Command and also pass into IsisTransaction.
        ... extend IsisTranscationManager's executeWithTransaction to allow an existing Command to be passed in; leverage this from BackgroundCommandExecution.

        Also:
        ... use ClockService to obtain the time, rather than Clock singleton (for Command#setTimestamp, also Command#setStartedAt,
        ... make lookup of mandatory services fail-fast if not present (PropertySetterFacet, ActionInvocationFacet, IsisTransactionManager, IsisTransaction)
        ... minor alterations to visibility of DomainObjectJdoAbstract properties in tables.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 98a0c2f8032f49178e9a048d4139e4d0af66c594 in isis's branch refs/heads/ ISIS-1291 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=98a0c2f ] ISIS-1390 : default CommandServiceDefault. Also simplifying the relationship between IsisTransaction and Command, and how the Command object is initialized. Also: ... deprecating CommandService#startTransaction(...), make it the responsibility of IsisTransactionManager to populate the transactionId of the Command in all cases. ... simplifying logic in IsisTransaction; the Command is only just created, so will never have a transactionId to reuse. The design is now simply for the IsisTransactionManager to create a new UUID and set on both the Command and also pass into IsisTransaction. ... extend IsisTranscationManager's executeWithTransaction to allow an existing Command to be passed in; leverage this from BackgroundCommandExecution. Also: ... use ClockService to obtain the time, rather than Clock singleton (for Command#setTimestamp, also Command#setStartedAt, ... make lookup of mandatory services fail-fast if not present (PropertySetterFacet, ActionInvocationFacet, IsisTransactionManager, IsisTransaction) ... minor alterations to visibility of DomainObjectJdoAbstract properties in tables.

          People

          • Assignee:
            danhaywood Dan Haywood
            Reporter:
            danhaywood Dan Haywood
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development