Uploaded image for project: 'Isis'
  1. Isis
  2. ISIS-1370

New PublisherService to simplify and replace PublishingService.

    Details

    • Type: New Feature
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.12.0
    • Fix Version/s: 1.13.0
    • Component/s: Core
    • Labels:
      None

      Description

      Most PublishingService implementations (to date) only require the metadata (action invocation or domain object identity) to publish their events; the notion of the payload (to eagerly assemble information for the downstream subscribers) seems less useful.

      This ticket is therefore to deprecate the PublishingService#publish(EventMetadata, EventPayload), and replace with PublishingService2#publish(EventMetadata).

      This also means that @DomainObject#publishingPayloadFactory() and @Action#publishingPayloadFactory() attributes are deprecated.

      ~~~
      In its place, will have a new PublisherService with a simplified API.

        Activity

        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit fec5e920899df6f95146a21b3fb4ef7b92180b7b in isis's branch refs/heads/ISIS-1291 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=fec5e92 ]

        ISIS-1370: removing concept of payload factories from PublishingService.

        Show
        jira-bot ASF subversion and git services added a comment - Commit fec5e920899df6f95146a21b3fb4ef7b92180b7b in isis's branch refs/heads/ ISIS-1291 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=fec5e92 ] ISIS-1370 : removing concept of payload factories from PublishingService.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit b1b3dc52db25a32100b6e1cbf0676baac0c91bf7 in isis's branch refs/heads/ISIS-1291 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=b1b3dc5 ]

        ISIS-1370: tidying up other unused code related to payload factories for publishing service. Also use the PublishingService2 API if present.

        Show
        jira-bot ASF subversion and git services added a comment - Commit b1b3dc52db25a32100b6e1cbf0676baac0c91bf7 in isis's branch refs/heads/ ISIS-1291 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=b1b3dc5 ] ISIS-1370 : tidying up other unused code related to payload factories for publishing service. Also use the PublishingService2 API if present.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 08d87c03163b41cc5d04d534b33cb6e35dc8383e in isis's branch refs/heads/ISIS-1291 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=08d87c0 ]

        ISIS-1370: moving publishObjects from IsisTransaction to PublishingServiceInternal; inline methods; DomainObjectInvocationHandler calls PublishingServiceInternal rather than IsisTransaction.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 08d87c03163b41cc5d04d534b33cb6e35dc8383e in isis's branch refs/heads/ ISIS-1291 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=08d87c0 ] ISIS-1370 : moving publishObjects from IsisTransaction to PublishingServiceInternal; inline methods; DomainObjectInvocationHandler calls PublishingServiceInternal rather than IsisTransaction.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 144aefa2dfd89bc2ab7a69a173635db2ea76dea8 in isis's branch refs/heads/ISIS-1291 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=144aefa ]

        ISIS-1370: removing unused code from IsisTransaction

        Show
        jira-bot ASF subversion and git services added a comment - Commit 144aefa2dfd89bc2ab7a69a173635db2ea76dea8 in isis's branch refs/heads/ ISIS-1291 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=144aefa ] ISIS-1370 : removing unused code from IsisTransaction
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit ddc95891f95459019f09a0c1569124a7367e9a86 in isis's branch refs/heads/ISIS-1291 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=ddc9589 ]

        ISIS-1370: removing unused local vars, is all.

        Show
        jira-bot ASF subversion and git services added a comment - Commit ddc95891f95459019f09a0c1569124a7367e9a86 in isis's branch refs/heads/ ISIS-1291 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=ddc9589 ] ISIS-1370 : removing unused local vars, is all.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit ce533253f8540cf990746260acdd99dc2e574805 in isis's branch refs/heads/ISIS-1291 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=ce53325 ]

        ISIS-1370: move responsibility for publishing actions into the ActionInvocationFacet (instead of in IsisTransaction and DomainObjectInvocationHandler)

        To this end, extract interface for PublishingServiceInternal, move to metamodel module (out from runtime).
        Also minor refactoring wihin PublishingServiceInternal(Default) itself.

        Show
        jira-bot ASF subversion and git services added a comment - Commit ce533253f8540cf990746260acdd99dc2e574805 in isis's branch refs/heads/ ISIS-1291 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=ce53325 ] ISIS-1370 : move responsibility for publishing actions into the ActionInvocationFacet (instead of in IsisTransaction and DomainObjectInvocationHandler) To this end, extract interface for PublishingServiceInternal, move to metamodel module (out from runtime). Also minor refactoring wihin PublishingServiceInternal(Default) itself.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit a204d749277ef5e54bb26c03a2f479b3d4ad61e2 in isis's branch refs/heads/ISIS-1291 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=a204d74 ]

        ISIS-1370: working towards removing the ActioninvocationFacet#currentInvocation threadlocal.

        Show
        jira-bot ASF subversion and git services added a comment - Commit a204d749277ef5e54bb26c03a2f479b3d4ad61e2 in isis's branch refs/heads/ ISIS-1291 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=a204d74 ] ISIS-1370 : working towards removing the ActioninvocationFacet#currentInvocation threadlocal.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit eee234c03f44f8720f9c1378dbb466d90f83da0d in isis's branch refs/heads/ISIS-1291 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=eee234c ]

        ISIS-1370: removed the ActionInvocationFacet#currentInvocation thread-local.

        Show
        jira-bot ASF subversion and git services added a comment - Commit eee234c03f44f8720f9c1378dbb466d90f83da0d in isis's branch refs/heads/ ISIS-1291 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=eee234c ] ISIS-1370 : removed the ActionInvocationFacet#currentInvocation thread-local.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 9d8847fc3838c84c14d3c847798b974b11e2e0e0 in isis's branch refs/heads/ISIS-1291 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=9d8847f ]

        ISIS-1370: getting build to pass (moving PublishingServiceInternalDefault to package where it will be picked up as a domain service).

        Also removing unused code in DomainObjectInvocationHandler.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 9d8847fc3838c84c14d3c847798b974b11e2e0e0 in isis's branch refs/heads/ ISIS-1291 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=9d8847f ] ISIS-1370 : getting build to pass (moving PublishingServiceInternalDefault to package where it will be picked up as a domain service). Also removing unused code in DomainObjectInvocationHandler.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 5870f6a5973fd65af8d054ffe872f24b80fbdefc in isis's branch refs/heads/ISIS-1291 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=5870f6a ]

        ISIS-1370: factored out AuditingServiceInternal as wrapper around AuditingService3 (similar design to PublshingServiceInternal wrapping PublishingService).

        Show
        jira-bot ASF subversion and git services added a comment - Commit 5870f6a5973fd65af8d054ffe872f24b80fbdefc in isis's branch refs/heads/ ISIS-1291 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=5870f6a ] ISIS-1370 : factored out AuditingServiceInternal as wrapper around AuditingService3 (similar design to PublshingServiceInternal wrapping PublishingService).
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit e2fb62e65eebd8f9930947333d72cb73144fdce2 in isis's branch refs/heads/ISIS-1291 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=e2fb62e ]

        ISIS-1370: moved AuditingServiceInternal to an auditing package.

        Show
        jira-bot ASF subversion and git services added a comment - Commit e2fb62e65eebd8f9930947333d72cb73144fdce2 in isis's branch refs/heads/ ISIS-1291 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=e2fb62e ] ISIS-1370 : moved AuditingServiceInternal to an auditing package.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit ad43cad3fc029d2b9f90232d7fc270bbbe30eb7e in isis's branch refs/heads/ISIS-1291 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=ad43cad ]

        ISIS-1370: factored out EnlistedObjectsServiceInternal from IsisTransaction; used by AuditingServiceInternal and PublishingServiceInternal(Default).

        Show
        jira-bot ASF subversion and git services added a comment - Commit ad43cad3fc029d2b9f90232d7fc270bbbe30eb7e in isis's branch refs/heads/ ISIS-1291 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=ad43cad ] ISIS-1370 : factored out EnlistedObjectsServiceInternal from IsisTransaction; used by AuditingServiceInternal and PublishingServiceInternal(Default).
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 07342da5a1956fcd3a8ce52e752222be4340d5c4 in isis's branch refs/heads/ISIS-1291 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=07342da ]

        ISIS-1370: construct the aimDto before calling PublisherService. Also refactoring property setter facet and OneToOneAssociation to follow the same general structure as for action invocations, in particular for the set up of Command objects.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 07342da5a1956fcd3a8ce52e752222be4340d5c4 in isis's branch refs/heads/ ISIS-1291 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=07342da ] ISIS-1370 : construct the aimDto before calling PublisherService. Also refactoring property setter facet and OneToOneAssociation to follow the same general structure as for action invocations, in particular for the set up of Command objects.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit d50731ca4aa53933a93cef9ed04678717cb8fdca in isis's branch refs/heads/ISIS-1291 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d50731c ]

        ISIS-1370: changing the API for PublisherService, adding default Logging implementation. Adding support for deep XML graphs within InteractionDto.

        Show
        jira-bot ASF subversion and git services added a comment - Commit d50731ca4aa53933a93cef9ed04678717cb8fdca in isis's branch refs/heads/ ISIS-1291 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d50731c ] ISIS-1370 : changing the API for PublisherService, adding default Logging implementation. Adding support for deep XML graphs within InteractionDto.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 7dab5d61b4bed132b7202a3cc7a95dd443f3c015 in isis's branch refs/heads/ISIS-1291 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=7dab5d6 ]

        ISIS-1370: @Property#publishing= and also @Property#command=...

        Also deprecated Command.ACTION_IDENTIFIER_FOR_EDIT, since no longer used (and removed stale code in ObjectMemberAbstract).

        Show
        jira-bot ASF subversion and git services added a comment - Commit 7dab5d61b4bed132b7202a3cc7a95dd443f3c015 in isis's branch refs/heads/ ISIS-1291 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=7dab5d6 ] ISIS-1370 : @Property#publishing= and also @Property#command=... Also deprecated Command.ACTION_IDENTIFIER_FOR_EDIT, since no longer used (and removed stale code in ObjectMemberAbstract).
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit b01781b0507e5f49a770f8079b4d477a156201fa in isis's branch refs/heads/ISIS-1291 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=b01781b ]

        ISIS-1370: now supports publishing of objects.

        Show
        jira-bot ASF subversion and git services added a comment - Commit b01781b0507e5f49a770f8079b4d477a156201fa in isis's branch refs/heads/ ISIS-1291 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=b01781b ] ISIS-1370 : now supports publishing of objects.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit cd370c597a5c1724695a54bc87a0c78cd3044bfe in isis's branch refs/heads/ISIS-1291 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=cd370c5 ]

        ISIS-1370: adding a new JdoColumnLength constant for status messages (for publishmq impl to reference).

        Show
        jira-bot ASF subversion and git services added a comment - Commit cd370c597a5c1724695a54bc87a0c78cd3044bfe in isis's branch refs/heads/ ISIS-1291 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=cd370c5 ] ISIS-1370 : adding a new JdoColumnLength constant for status messages (for publishmq impl to reference).
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 72705aceee671e2c13b4d132b61b4a181aa50e85 in isis's branch refs/heads/ISIS-1291 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=72705ac ]

        ISIS-1370: improve syntax of comparator static methods in DomainChangeJdoAbstract

        Show
        jira-bot ASF subversion and git services added a comment - Commit 72705aceee671e2c13b4d132b61b4a181aa50e85 in isis's branch refs/heads/ ISIS-1291 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=72705ac ] ISIS-1370 : improve syntax of comparator static methods in DomainChangeJdoAbstract
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 138dc57a082982672f75de629635672f54217c53 in isis's branch refs/heads/ISIS-1291 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=138dc57 ]

        ISIS-1370: adding some additional standard column lengths to applib's JdoColumnLength

        Show
        jira-bot ASF subversion and git services added a comment - Commit 138dc57a082982672f75de629635672f54217c53 in isis's branch refs/heads/ ISIS-1291 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=138dc57 ] ISIS-1370 : adding some additional standard column lengths to applib's JdoColumnLength
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit b01781b0507e5f49a770f8079b4d477a156201fa in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=b01781b ]

        ISIS-1370: now supports publishing of objects.

        Show
        jira-bot ASF subversion and git services added a comment - Commit b01781b0507e5f49a770f8079b4d477a156201fa in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=b01781b ] ISIS-1370 : now supports publishing of objects.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 2a89182879e3d472842958054e5087ba4f2bbc6b in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=2a89182 ]

        ISIS-1370: cleaning up the API to PublisherService, renaming EnlistedObjectsService to ChangedObjectsService etc.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 2a89182879e3d472842958054e5087ba4f2bbc6b in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=2a89182 ] ISIS-1370 : cleaning up the API to PublisherService, renaming EnlistedObjectsService to ChangedObjectsService etc.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit ea7c1904429e327647def9a3f5cd7d95a804c9ab in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=ea7c190 ]

        ISIS-1370: refining the API for PublisherService.

        Show
        jira-bot ASF subversion and git services added a comment - Commit ea7c1904429e327647def9a3f5cd7d95a804c9ab in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=ea7c190 ] ISIS-1370 : refining the API for PublisherService.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit b87fc37756f8e14ed74ea42fbec555dc0eed2047 in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=b87fc37 ]

        ISIS-1370: provide wormhole to allow mixin properties/collections to disable publishing of actions.

        Show
        jira-bot ASF subversion and git services added a comment - Commit b87fc37756f8e14ed74ea42fbec555dc0eed2047 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=b87fc37 ] ISIS-1370 : provide wormhole to allow mixin properties/collections to disable publishing of actions.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit cd370c597a5c1724695a54bc87a0c78cd3044bfe in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=cd370c5 ]

        ISIS-1370: adding a new JdoColumnLength constant for status messages (for publishmq impl to reference).

        Show
        jira-bot ASF subversion and git services added a comment - Commit cd370c597a5c1724695a54bc87a0c78cd3044bfe in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=cd370c5 ] ISIS-1370 : adding a new JdoColumnLength constant for status messages (for publishmq impl to reference).
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 72705aceee671e2c13b4d132b61b4a181aa50e85 in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=72705ac ]

        ISIS-1370: improve syntax of comparator static methods in DomainChangeJdoAbstract

        Show
        jira-bot ASF subversion and git services added a comment - Commit 72705aceee671e2c13b4d132b61b4a181aa50e85 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=72705ac ] ISIS-1370 : improve syntax of comparator static methods in DomainChangeJdoAbstract
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 138dc57a082982672f75de629635672f54217c53 in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=138dc57 ]

        ISIS-1370: adding some additional standard column lengths to applib's JdoColumnLength

        Show
        jira-bot ASF subversion and git services added a comment - Commit 138dc57a082982672f75de629635672f54217c53 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=138dc57 ] ISIS-1370 : adding some additional standard column lengths to applib's JdoColumnLength

          People

          • Assignee:
            danhaywood Dan Haywood
            Reporter:
            danhaywood Dan Haywood
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development