Uploaded image for project: 'Isis'
  1. Isis
  2. ISIS-1343

Properly handle domain events from mixins, exposing the underlying "mixedIn" domain object.

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.10.0
    • Fix Version/s: 1.13.0
    • Component/s: Core
    • Labels:

      Description

      Following on from ISIS-1340, this is to properly expose the mixin on the ActionDomainEvent, and to have it set correctly by the XxxMixin impl.

      Think that this is also required for property and collection mixins, also.

        Activity

        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 0689936cd0d9accf032ca3cf4a96139fba4b4128 in isis's branch refs/heads/ISIS-1343 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=0689936 ]

        ISIS-1343: extend ActionI invocation to take the targetAdapter, mixedInAdapter (can be null) and arg array.

        In addition, always pass in the ObjectAction (rather than merely IdentifiedHolder = FacetedMethod) to the DomainEventHelper#postEventForAction(...); this ensures that the domain event's param names and param types are correctly populated in all cases.

        Update the HideMixinsForHomePage subscriber to use the new API.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 0689936cd0d9accf032ca3cf4a96139fba4b4128 in isis's branch refs/heads/ ISIS-1343 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=0689936 ] ISIS-1343 : extend ActionI invocation to take the targetAdapter, mixedInAdapter (can be null) and arg array. In addition, always pass in the ObjectAction (rather than merely IdentifiedHolder = FacetedMethod) to the DomainEventHelper#postEventForAction(...); this ensures that the domain event's param names and param types are correctly populated in all cases. Update the HideMixinsForHomePage subscriber to use the new API.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 0689936cd0d9accf032ca3cf4a96139fba4b4128 in isis's branch refs/heads/ISIS-1291 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=0689936 ]

        ISIS-1343: extend ActionI invocation to take the targetAdapter, mixedInAdapter (can be null) and arg array.

        In addition, always pass in the ObjectAction (rather than merely IdentifiedHolder = FacetedMethod) to the DomainEventHelper#postEventForAction(...); this ensures that the domain event's param names and param types are correctly populated in all cases.

        Update the HideMixinsForHomePage subscriber to use the new API.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 0689936cd0d9accf032ca3cf4a96139fba4b4128 in isis's branch refs/heads/ ISIS-1291 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=0689936 ] ISIS-1343 : extend ActionI invocation to take the targetAdapter, mixedInAdapter (can be null) and arg array. In addition, always pass in the ObjectAction (rather than merely IdentifiedHolder = FacetedMethod) to the DomainEventHelper#postEventForAction(...); this ensures that the domain event's param names and param types are correctly populated in all cases. Update the HideMixinsForHomePage subscriber to use the new API.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 02dd0ee5936b8d1b0cedbd52ab4e9e63ffc3bd73 in isis's branch refs/heads/ISIS-1291 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=02dd0ee ]

        ISIS-1343: ActionDomainEvent now has a getMixedIn(),populated for mixin actions. Corresponding changes to the rest of the metamodel.

        Merging remote-tracking branch 'origin/ISIS-1343' into ISIS-1291

        1. Conflicts:
        2. core/metamodel/src/main/java/org/apache/isis/core/metamodel/specloader/specimpl/ObjectActionContributee.java
        3. core/metamodel/src/main/java/org/apache/isis/core/metamodel/specloader/specimpl/ObjectActionDefault.java
        4. core/metamodel/src/main/java/org/apache/isis/core/metamodel/specloader/specimpl/ObjectActionMixedIn.java
        5. core/runtime/src/main/java/org/apache/isis/core/runtime/services/background/BackgroundCommandExecution.java
        6. core/runtime/src/main/java/org/apache/isis/core/runtime/transaction/facets/ActionInvocationFacetWrapTransaction.java
        Show
        jira-bot ASF subversion and git services added a comment - Commit 02dd0ee5936b8d1b0cedbd52ab4e9e63ffc3bd73 in isis's branch refs/heads/ ISIS-1291 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=02dd0ee ] ISIS-1343 : ActionDomainEvent now has a getMixedIn(),populated for mixin actions. Corresponding changes to the rest of the metamodel. Merging remote-tracking branch 'origin/ ISIS-1343 ' into ISIS-1291 Conflicts: core/metamodel/src/main/java/org/apache/isis/core/metamodel/specloader/specimpl/ObjectActionContributee.java core/metamodel/src/main/java/org/apache/isis/core/metamodel/specloader/specimpl/ObjectActionDefault.java core/metamodel/src/main/java/org/apache/isis/core/metamodel/specloader/specimpl/ObjectActionMixedIn.java core/runtime/src/main/java/org/apache/isis/core/runtime/services/background/BackgroundCommandExecution.java core/runtime/src/main/java/org/apache/isis/core/runtime/transaction/facets/ActionInvocationFacetWrapTransaction.java
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 02dd0ee5936b8d1b0cedbd52ab4e9e63ffc3bd73 in isis's branch refs/heads/ISIS-1291 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=02dd0ee ]

        ISIS-1343: ActionDomainEvent now has a getMixedIn(),populated for mixin actions. Corresponding changes to the rest of the metamodel.

        Merging remote-tracking branch 'origin/ISIS-1343' into ISIS-1291

        1. Conflicts:
        2. core/metamodel/src/main/java/org/apache/isis/core/metamodel/specloader/specimpl/ObjectActionContributee.java
        3. core/metamodel/src/main/java/org/apache/isis/core/metamodel/specloader/specimpl/ObjectActionDefault.java
        4. core/metamodel/src/main/java/org/apache/isis/core/metamodel/specloader/specimpl/ObjectActionMixedIn.java
        5. core/runtime/src/main/java/org/apache/isis/core/runtime/services/background/BackgroundCommandExecution.java
        6. core/runtime/src/main/java/org/apache/isis/core/runtime/transaction/facets/ActionInvocationFacetWrapTransaction.java
        Show
        jira-bot ASF subversion and git services added a comment - Commit 02dd0ee5936b8d1b0cedbd52ab4e9e63ffc3bd73 in isis's branch refs/heads/ ISIS-1291 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=02dd0ee ] ISIS-1343 : ActionDomainEvent now has a getMixedIn(),populated for mixin actions. Corresponding changes to the rest of the metamodel. Merging remote-tracking branch 'origin/ ISIS-1343 ' into ISIS-1291 Conflicts: core/metamodel/src/main/java/org/apache/isis/core/metamodel/specloader/specimpl/ObjectActionContributee.java core/metamodel/src/main/java/org/apache/isis/core/metamodel/specloader/specimpl/ObjectActionDefault.java core/metamodel/src/main/java/org/apache/isis/core/metamodel/specloader/specimpl/ObjectActionMixedIn.java core/runtime/src/main/java/org/apache/isis/core/runtime/services/background/BackgroundCommandExecution.java core/runtime/src/main/java/org/apache/isis/core/runtime/transaction/facets/ActionInvocationFacetWrapTransaction.java

          People

          • Assignee:
            danhaywood Dan Haywood
            Reporter:
            danhaywood Dan Haywood
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development