Uploaded image for project: 'Isis'
  1. Isis
  2. ISIS-1328

Bookmark hints are not being honoured

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.11.1
    • Fix Version/s: 1.12.0
    • Component/s: None
    • Labels:
      None

      Activity

      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 4672aefa73db3b10612c52c8d8c6fd7a117398d2 in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=4672aef ]

      ISIS-1239, ISIS-1324, ISIS-1328: multi-select for standalone collections was broken, now fixed.

      Issue was that earlier work moved entire responsibility for being the "UiHintContainer" onto the EntityModel, on the basis that only entities can store hints over time. However, the selector drop-down for standalone collections also was storying the hint on the UiHintContainer, which previously was also supported by (standalone) EntityCollectionModel. This meant that the hint got lost. Fix for that is to allow the IsisUiHintEvent to also directly hold the hint info.

      In addition, the algorithm for selecting the default view was broken for standalone collections; should default to "table" if a standalone and there is no other metadata available.

      Show
      jira-bot ASF subversion and git services added a comment - Commit 4672aefa73db3b10612c52c8d8c6fd7a117398d2 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=4672aef ] ISIS-1239 , ISIS-1324 , ISIS-1328 : multi-select for standalone collections was broken, now fixed. Issue was that earlier work moved entire responsibility for being the "UiHintContainer" onto the EntityModel, on the basis that only entities can store hints over time. However, the selector drop-down for standalone collections also was storying the hint on the UiHintContainer, which previously was also supported by (standalone) EntityCollectionModel. This meant that the hint got lost. Fix for that is to allow the IsisUiHintEvent to also directly hold the hint info. In addition, the algorithm for selecting the default view was broken for standalone collections; should default to "table" if a standalone and there is no other metadata available.
      Hide
      danhaywood Dan Haywood added a comment -

      done as part of ISIS-1239, also ISIS-1324

      Show
      danhaywood Dan Haywood added a comment - done as part of ISIS-1239 , also ISIS-1324

        People

        • Assignee:
          danhaywood Dan Haywood
          Reporter:
          danhaywood Dan Haywood
        • Votes:
          0 Vote for this issue
          Watchers:
          2 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development