Uploaded image for project: 'Isis'
  1. Isis
  2. ISIS-1324

Allow multiple different views of same collection in a layout

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.12.0
    • Component/s: Core
    • Labels:
      None

      Activity

      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 4672aefa73db3b10612c52c8d8c6fd7a117398d2 in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=4672aef ]

      ISIS-1239, ISIS-1324, ISIS-1328: multi-select for standalone collections was broken, now fixed.

      Issue was that earlier work moved entire responsibility for being the "UiHintContainer" onto the EntityModel, on the basis that only entities can store hints over time. However, the selector drop-down for standalone collections also was storying the hint on the UiHintContainer, which previously was also supported by (standalone) EntityCollectionModel. This meant that the hint got lost. Fix for that is to allow the IsisUiHintEvent to also directly hold the hint info.

      In addition, the algorithm for selecting the default view was broken for standalone collections; should default to "table" if a standalone and there is no other metadata available.

      Show
      jira-bot ASF subversion and git services added a comment - Commit 4672aefa73db3b10612c52c8d8c6fd7a117398d2 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=4672aef ] ISIS-1239 , ISIS-1324 , ISIS-1328 : multi-select for standalone collections was broken, now fixed. Issue was that earlier work moved entire responsibility for being the "UiHintContainer" onto the EntityModel, on the basis that only entities can store hints over time. However, the selector drop-down for standalone collections also was storying the hint on the UiHintContainer, which previously was also supported by (standalone) EntityCollectionModel. This meant that the hint got lost. Fix for that is to allow the IsisUiHintEvent to also directly hold the hint info. In addition, the algorithm for selecting the default view was broken for standalone collections; should default to "table" if a standalone and there is no other metadata available.
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit eadc9ccbcedbecf7e5adbdba159e32ad4f4989e6 in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=eadc9cc ]

      ISIS-1324: updating docs to describe multiple collections on same page. Also discussion of custom CSS on page

      Show
      jira-bot ASF subversion and git services added a comment - Commit eadc9ccbcedbecf7e5adbdba159e32ad4f4989e6 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=eadc9cc ] ISIS-1324 : updating docs to describe multiple collections on same page. Also discussion of custom CSS on page
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 12d6c717cb44497a6c8cd0d6ec2a0e16a83c58b0 in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=12d6c71 ]

      ISIS-1324: further small refactorings of EntityModel hints.

      Show
      jira-bot ASF subversion and git services added a comment - Commit 12d6c717cb44497a6c8cd0d6ec2a0e16a83c58b0 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=12d6c71 ] ISIS-1324 : further small refactorings of EntityModel hints.
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit be5b3384ec03e316342f79c40250a61590345fdd in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=be5b338 ]

      ISIS-1324: have EntityCollectionModel hold a reference to EntityModel (if it is parented)... the idea being that we will associate hints only with EntityModels.

      Show
      jira-bot ASF subversion and git services added a comment - Commit be5b3384ec03e316342f79c40250a61590345fdd in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=be5b338 ] ISIS-1324 : have EntityCollectionModel hold a reference to EntityModel (if it is parented)... the idea being that we will associate hints only with EntityModels.
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit daf7ad7140c4c182522cef55d30fdb15c5138dd6 in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=daf7ad7 ]

      ISIS-1324: refactoring usage of ScopedSessionAttribute: removing duplication between EntityCollectionModel and ModelAbstract.

      Show
      jira-bot ASF subversion and git services added a comment - Commit daf7ad7140c4c182522cef55d30fdb15c5138dd6 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=daf7ad7 ] ISIS-1324 : refactoring usage of ScopedSessionAttribute: removing duplication between EntityCollectionModel and ModelAbstract.
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 84b682d5c91c20242fd6e99bd30830d83b3dbcf2 in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=84b682d ]

      ISIS-1324: fixing the standalone table panel, was not displaying any rows due to defaulting to an invalid view name.

      Show
      jira-bot ASF subversion and git services added a comment - Commit 84b682d5c91c20242fd6e99bd30830d83b3dbcf2 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=84b682d ] ISIS-1324 : fixing the standalone table panel, was not displaying any rows due to defaulting to an invalid view name.
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit b0e59bae0f3511361fd18d5c304680b25e3eb336 in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=b0e59ba ]

      ISIS-1324: now using the CollectionLayoutData on the EntityCollectionModel (if available) to default the views. Thereafter the existing hint stuff is working ok.

      Show
      jira-bot ASF subversion and git services added a comment - Commit b0e59bae0f3511361fd18d5c304680b25e3eb336 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=b0e59ba ] ISIS-1324 : now using the CollectionLayoutData on the EntityCollectionModel (if available) to default the views. Thereafter the existing hint stuff is working ok.

        People

        • Assignee:
          danhaywood Dan Haywood
          Reporter:
          danhaywood Dan Haywood
        • Votes:
          0 Vote for this issue
          Watchers:
          2 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development