Uploaded image for project: 'Isis'
  1. Isis
  2. ISIS-1309

Disabled no-arg "are you sure" actions still show the prompt to be shown..

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.11.1
    • Fix Version/s: 1.12.0
    • Component/s: None
    • Labels:
      None

      Activity

      Hide
      danhaywood Dan Haywood added a comment -

      to reproduce:

      
      
          @Inject
          MessageService messageService;
      
          @Action(
                  semantics = SemanticsOf.IDEMPOTENT_ARE_YOU_SURE
          )
          public void areYouSureNoArg() {
              messageService.informUser("areYouSureNoArg");
          }
      
          public String disableAreYouSureNoArg() {
              return "disabled";
          }
      
          @Action(
                  semantics = SemanticsOf.IDEMPOTENT_ARE_YOU_SURE
          )
          public void areYouSureOneArg(int a) {
              messageService.informUser("areYouSureOneArg");
          }
      
          public String disableAreYouSureOneArg() {
              return "disabled";
          }
      
      
      
      Show
      danhaywood Dan Haywood added a comment - to reproduce: @Inject MessageService messageService; @Action( semantics = SemanticsOf.IDEMPOTENT_ARE_YOU_SURE ) public void areYouSureNoArg() { messageService.informUser( "areYouSureNoArg" ); } public String disableAreYouSureNoArg() { return "disabled" ; } @Action( semantics = SemanticsOf.IDEMPOTENT_ARE_YOU_SURE ) public void areYouSureOneArg( int a) { messageService.informUser( "areYouSureOneArg" ); } public String disableAreYouSureOneArg() { return "disabled" ; }
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 2936d1d98bca84ec871b6cca25eb854da5653c9b in isis's branch refs/heads/master from Dan Haywood
      [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=2936d1d ]

      ISIS-1309: only add the "are you sure" prompt if action is not disabled.

      Show
      jira-bot ASF subversion and git services added a comment - Commit 2936d1d98bca84ec871b6cca25eb854da5653c9b in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=2936d1d ] ISIS-1309 : only add the "are you sure" prompt if action is not disabled.

        People

        • Assignee:
          danhaywood Dan Haywood
          Reporter:
          danhaywood Dan Haywood
        • Votes:
          0 Vote for this issue
          Watchers:
          2 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development