Uploaded image for project: 'Isis'
  1. Isis
  2. ISIS-1291

Define new DTO (XSD) as the memento for Command#setMemento

    Details

    • Type: New Feature
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.11.0
    • Fix Version/s: 1.13.0
    • Component/s: Core
    • Labels:

      Description

      A command is NOT an action invocation, it is an INTENTION to invoke an action. Generally that intention is carried out immediately, hence a foreground command. Sometimes though it is carried out in the background, so is a deferred intention.

      What this implies is that a command should not contain details of the action's results. (If that information is available from reified ActionDomainEvents, then they can be contributed/mixed in)

      A command should cope with the concept of being invoked on more than one object, ie having a list of targets. nb: this implies that our current terminology of "bulk actions" is actually wrong, we ought to be talking about "bulk commands".

      We can envisage (at least) two different user intentions when performing a bulk command:
      a) perform the operation on as many as possible, or
      b) perform the operation on all of them, or none at all.

      The former suggests that each action is wrapped in its own command: the user intends to operate on each object, one after the other. The latter suggests that all the actions live in a single command.

      Dan's view is that a command is one:one with a (DB) transaction.

      ~~~

      the original version of this ticket was to change the Command#setMemento to use the ActionInvocationMementoDto. However, that now seems to be incorrect:

      • an AimDto is a record of an action being invoked (past tense, if you will), not the intention to invoke an action
      • as such an AimDto holds a return value, but that is strictly irrelevant to a Command
      • an AimDto relates only to a single target, whereas a Command could have multiple targets ("perform this action on all of em, or none of em")

      So, instead, this ticket is to define a new XSD just as the reified form of Commands. It needs to be able to handle mxins, and bulk actions. It shouldn't have action results.

      ~~~
      Note that this will also require some data migration scripts for anyone that has used this feature.

        Activity

        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 2df011a62b1a205b8056a8ca444836012639c5e9 in isis's branch refs/heads/ISIS-1291 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=2df011a ]

        ISIS-1291: whitespace/comments only

        Show
        jira-bot ASF subversion and git services added a comment - Commit 2df011a62b1a205b8056a8ca444836012639c5e9 in isis's branch refs/heads/ ISIS-1291 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=2df011a ] ISIS-1291 : whitespace/comments only
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 8fb9dc4bda56f1573bba282646a5f31204865985 in isis's branch refs/heads/ISIS-1291 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=8fb9dc4 ]

        ISIS-1291: introduce enum for sequenceName (for newEventMetadata); minor moving around of methods/extract methods refactoring of newEventMetadata within IsisTransaction.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 8fb9dc4bda56f1573bba282646a5f31204865985 in isis's branch refs/heads/ ISIS-1291 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=8fb9dc4 ] ISIS-1291 : introduce enum for sequenceName (for newEventMetadata); minor moving around of methods/extract methods refactoring of newEventMetadata within IsisTransaction.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit d4c9875df22e2b865a433f0ff6ba32eb78d5bb40 in isis's branch refs/heads/ISIS-1291 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d4c9875 ]

        ISIS-1291: added guard in CommandMementoServiceDefault, can only create for commands that represent actions (not property edits).

        Show
        jira-bot ASF subversion and git services added a comment - Commit d4c9875df22e2b865a433f0ff6ba32eb78d5bb40 in isis's branch refs/heads/ ISIS-1291 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d4c9875 ] ISIS-1291 : added guard in CommandMementoServiceDefault, can only create for commands that represent actions (not property edits).
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 93932127bf6888f38ecb1d7ce3d5c45d8a9c05fa in isis's branch refs/heads/ISIS-1291 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=9393212 ]

        ISIS-1291: adding spreadsheet to analyse duplicated functionality across commands, ActionDomainEvent, AIMs, publishing.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 93932127bf6888f38ecb1d7ce3d5c45d8a9c05fa in isis's branch refs/heads/ ISIS-1291 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=9393212 ] ISIS-1291 : adding spreadsheet to analyse duplicated functionality across commands, ActionDomainEvent, AIMs, publishing.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit f251de1d35e187ffd4cd299904f86d92850eb45e in isis's branch refs/heads/ISIS-1291 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=f251de1 ]

        ISIS-1291: partially reverting the introduction of a SequenceName... no need after all to add to EventMetadata, because there is only one reason for subactions to occur. Also moved the SequenceName enum out from EventMetadata and into Command interface.

        Show
        jira-bot ASF subversion and git services added a comment - Commit f251de1d35e187ffd4cd299904f86d92850eb45e in isis's branch refs/heads/ ISIS-1291 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=f251de1 ] ISIS-1291 : partially reverting the introduction of a SequenceName... no need after all to add to EventMetadata, because there is only one reason for subactions to occur. Also moved the SequenceName enum out from EventMetadata and into Command interface.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 76cbd9601948ad14d94dcba5c3b3335e0a216a60 in isis's branch refs/heads/ISIS-1291 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=76cbd96 ]

        ISIS-1291: updated documentation in the aim.xsd (v1.1). Also copied to website..

        Show
        jira-bot ASF subversion and git services added a comment - Commit 76cbd9601948ad14d94dcba5c3b3335e0a216a60 in isis's branch refs/heads/ ISIS-1291 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=76cbd96 ] ISIS-1291 : updated documentation in the aim.xsd (v1.1). Also copied to website..
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 6b62b45bd2af860444f4f44fd2f767aead0beef2 in isis's branch refs/heads/ISIS-1291 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=6b62b45 ]

        ISIS-1291: updating the website with latest version of aim.xsd (for v1.1).

        Show
        jira-bot ASF subversion and git services added a comment - Commit 6b62b45bd2af860444f4f44fd2f767aead0beef2 in isis's branch refs/heads/ ISIS-1291 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=6b62b45 ] ISIS-1291 : updating the website with latest version of aim.xsd (for v1.1).
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 45d306811965cf8c54d406b84d18bd85739d8122 in isis's branch refs/heads/ISIS-1291 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=45d3068 ]

        ISIS-1291: cmd.xsd and aim.xsd

        Show
        jira-bot ASF subversion and git services added a comment - Commit 45d306811965cf8c54d406b84d18bd85739d8122 in isis's branch refs/heads/ ISIS-1291 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=45d3068 ] ISIS-1291 : cmd.xsd and aim.xsd
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 18469933eabbfd1ccf0d492ed751e50554425469 in isis's branch refs/heads/ISIS-1291 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=1846993 ]

        ISIS-1291: adding design doc

        Show
        jira-bot ASF subversion and git services added a comment - Commit 18469933eabbfd1ccf0d492ed751e50554425469 in isis's branch refs/heads/ ISIS-1291 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=1846993 ] ISIS-1291 : adding design doc
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 0264ec60582fa39d312e3ae79b0bb534f0ff9afc in isis's branch refs/heads/ISIS-1291 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=0264ec6 ]

        ISIS-1291: memento xsd schemas + utils; new command memento DTO for Command#memento, updated background service, background execution; new PublisherService

        specifically:

        • deleted aim-1.0.xsd, added in aim-2.0.xsd, also cmd-1.0.xsd and updated common-1.0.xsd.
        • Updated ActionMementoDtoUtils new CommandMementoDtoUtils and CommandDtoUtils
        • moved CommandMementoService to internal SPI, added asCommandMemento, depends on ObjectAction (in order to handle mixin types) and also works on lists of objects (for bulk command/actions)
        • ActionInvocationFacet populates the Command#setMemento using CommandMementoDto (legacy behaviour preserved)
        Show
        jira-bot ASF subversion and git services added a comment - Commit 0264ec60582fa39d312e3ae79b0bb534f0ff9afc in isis's branch refs/heads/ ISIS-1291 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=0264ec6 ] ISIS-1291 : memento xsd schemas + utils; new command memento DTO for Command#memento, updated background service, background execution; new PublisherService specifically: deleted aim-1.0.xsd, added in aim-2.0.xsd, also cmd-1.0.xsd and updated common-1.0.xsd. Updated ActionMementoDtoUtils new CommandMementoDtoUtils and CommandDtoUtils moved CommandMementoService to internal SPI, added asCommandMemento, depends on ObjectAction (in order to handle mixin types) and also works on lists of objects (for bulk command/actions) ActionInvocationFacet populates the Command#setMemento using CommandMementoDto (legacy behaviour preserved)
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 69cd797c6a9b510c0a67f436ca0c8e22d8b1f10e in isis's branch refs/heads/ISIS-1291 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=69cd797 ]

        ISIS-1291: small fixes while manually testing command module.

        specifically:

        • fixing aim-2.0.xsd and cmd-1.0.xsd to have an @XmlRootElement
        • simplifying cmd-1.0.xsd
        • saving result and exception - after all - for commands executed in background
        • fixing bug (missing @Inject) for BackgroundService
        Show
        jira-bot ASF subversion and git services added a comment - Commit 69cd797c6a9b510c0a67f436ca0c8e22d8b1f10e in isis's branch refs/heads/ ISIS-1291 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=69cd797 ] ISIS-1291 : small fixes while manually testing command module. specifically: fixing aim-2.0.xsd and cmd-1.0.xsd to have an @XmlRootElement simplifying cmd-1.0.xsd saving result and exception - after all - for commands executed in background fixing bug (missing @Inject) for BackgroundService
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 0aa50c1bf96f95188ae50037023e7cac56784fb2 in isis's branch refs/heads/ISIS-1291 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=0aa50c1 ]

        Merge branch 'master' into ISIS-1291

        Show
        jira-bot ASF subversion and git services added a comment - Commit 0aa50c1bf96f95188ae50037023e7cac56784fb2 in isis's branch refs/heads/ ISIS-1291 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=0aa50c1 ] Merge branch 'master' into ISIS-1291
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 43e919eb987c2a42e430c1b58ae0d9389b9db5ae in isis's branch refs/heads/ISIS-1291 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=43e919e ]

        Merge branch 'master' into ISIS-1291

        Show
        jira-bot ASF subversion and git services added a comment - Commit 43e919eb987c2a42e430c1b58ae0d9389b9db5ae in isis's branch refs/heads/ ISIS-1291 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=43e919e ] Merge branch 'master' into ISIS-1291
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit a5f3ec11772086ded0828f225d1c36fa70ec1d61 in isis's branch refs/heads/ISIS-1291 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=a5f3ec1 ]

        ISIS-1291: using wormhole pattern so that bulk actions are persisted as list of adapters on command memento. Note sure I like this, though...

        Show
        jira-bot ASF subversion and git services added a comment - Commit a5f3ec11772086ded0828f225d1c36fa70ec1d61 in isis's branch refs/heads/ ISIS-1291 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=a5f3ec1 ] ISIS-1291 : using wormhole pattern so that bulk actions are persisted as list of adapters on command memento. Note sure I like this, though...
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit d2b3f6c3c62160614724e2a48996fcab0d5434ee in isis's branch refs/heads/ISIS-1291 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d2b3f6c ]

        ISIS-1291: re-implementing BulkActionsLink so that each action is in its own transaction (with its own command).

        Show
        jira-bot ASF subversion and git services added a comment - Commit d2b3f6c3c62160614724e2a48996fcab0d5434ee in isis's branch refs/heads/ ISIS-1291 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d2b3f6c ] ISIS-1291 : re-implementing BulkActionsLink so that each action is in its own transaction (with its own command).
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 2d43907faeab61cf731c50ab064528078cfc7c05 in isis's branch refs/heads/ISIS-1291 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=2d43907 ]

        ISIS-1291: extending common.xsd to support enums.

        Also ensuring all the XSD files are consistent.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 2d43907faeab61cf731c50ab064528078cfc7c05 in isis's branch refs/heads/ ISIS-1291 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=2d43907 ] ISIS-1291 : extending common.xsd to support enums. Also ensuring all the XSD files are consistent.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 497e7626106143fcbe07a71449529560e6d0571a in isis's branch refs/heads/ISIS-1291 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=497e762 ]

        Merge branch 'master' into ISIS-1291

        Show
        jira-bot ASF subversion and git services added a comment - Commit 497e7626106143fcbe07a71449529560e6d0571a in isis's branch refs/heads/ ISIS-1291 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=497e762 ] Merge branch 'master' into ISIS-1291
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 02dd0ee5936b8d1b0cedbd52ab4e9e63ffc3bd73 in isis's branch refs/heads/ISIS-1291 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=02dd0ee ]

        ISIS-1343: ActionDomainEvent now has a getMixedIn(),populated for mixin actions. Corresponding changes to the rest of the metamodel.

        Merging remote-tracking branch 'origin/ISIS-1343' into ISIS-1291

        1. Conflicts:
        2. core/metamodel/src/main/java/org/apache/isis/core/metamodel/specloader/specimpl/ObjectActionContributee.java
        3. core/metamodel/src/main/java/org/apache/isis/core/metamodel/specloader/specimpl/ObjectActionDefault.java
        4. core/metamodel/src/main/java/org/apache/isis/core/metamodel/specloader/specimpl/ObjectActionMixedIn.java
        5. core/runtime/src/main/java/org/apache/isis/core/runtime/services/background/BackgroundCommandExecution.java
        6. core/runtime/src/main/java/org/apache/isis/core/runtime/transaction/facets/ActionInvocationFacetWrapTransaction.java
        Show
        jira-bot ASF subversion and git services added a comment - Commit 02dd0ee5936b8d1b0cedbd52ab4e9e63ffc3bd73 in isis's branch refs/heads/ ISIS-1291 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=02dd0ee ] ISIS-1343 : ActionDomainEvent now has a getMixedIn(),populated for mixin actions. Corresponding changes to the rest of the metamodel. Merging remote-tracking branch 'origin/ ISIS-1343 ' into ISIS-1291 Conflicts: core/metamodel/src/main/java/org/apache/isis/core/metamodel/specloader/specimpl/ObjectActionContributee.java core/metamodel/src/main/java/org/apache/isis/core/metamodel/specloader/specimpl/ObjectActionDefault.java core/metamodel/src/main/java/org/apache/isis/core/metamodel/specloader/specimpl/ObjectActionMixedIn.java core/runtime/src/main/java/org/apache/isis/core/runtime/services/background/BackgroundCommandExecution.java core/runtime/src/main/java/org/apache/isis/core/runtime/transaction/facets/ActionInvocationFacetWrapTransaction.java
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit e85f405341fc847feae7a2ade3a165e03433e8c3 in isis's branch refs/heads/ISIS-1291 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=e85f405 ]

        ISIS-1291: app now running again...

        Show
        jira-bot ASF subversion and git services added a comment - Commit e85f405341fc847feae7a2ade3a165e03433e8c3 in isis's branch refs/heads/ ISIS-1291 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=e85f405 ] ISIS-1291 : app now running again...
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 64d2fe66a6af6e6baa8c891432f5e7cfd0ae67cd in isis's branch refs/heads/ISIS-1291 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=64d2fe6 ]

        ISIS-1291: documentation - updating the ixn, cmd and common XSDs, all of which were out of date.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 64d2fe66a6af6e6baa8c891432f5e7cfd0ae67cd in isis's branch refs/heads/ ISIS-1291 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=64d2fe6 ] ISIS-1291 : documentation - updating the ixn, cmd and common XSDs, all of which were out of date.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 52ca80d2e53241553e883192d08296e046e5f8d8 in isis's branch refs/heads/ISIS-1291 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=52ca80d ]

        ISIS-1291: simplifying OidDto, also use 'com' rather than 'common' as namespace prefix for common.xsd

        Show
        jira-bot ASF subversion and git services added a comment - Commit 52ca80d2e53241553e883192d08296e046e5f8d8 in isis's branch refs/heads/ ISIS-1291 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=52ca80d ] ISIS-1291 : simplifying OidDto, also use 'com' rather than 'common' as namespace prefix for common.xsd
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 7ebbb70c115636f872d13bb1c367916febc961c3 in isis's branch refs/heads/ISIS-1291 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=7ebbb70 ]

        ISIS-1291: documentation on command and events.

        Also:

        • adding missing schemas in adocs documentation (for hosting on the web).
        • updating bad links to @Xxx_aaa in multiple files
        • deprecating some methods in applib API.
        Show
        jira-bot ASF subversion and git services added a comment - Commit 7ebbb70c115636f872d13bb1c367916febc961c3 in isis's branch refs/heads/ ISIS-1291 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=7ebbb70 ] ISIS-1291 : documentation on command and events. Also: adding missing schemas in adocs documentation (for hosting on the web). updating bad links to @Xxx_aaa in multiple files deprecating some methods in applib API.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 55d3029a6265524ec3dbf65b2365d8569a42f61d in isis's branch refs/heads/ISIS-1291 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=55d3029 ]

        ISIS-1291: further documentation. Slight extension to the PublishedObjects API

        Show
        jira-bot ASF subversion and git services added a comment - Commit 55d3029a6265524ec3dbf65b2365d8569a42f61d in isis's branch refs/heads/ ISIS-1291 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=55d3029 ] ISIS-1291 : further documentation. Slight extension to the PublishedObjects API
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 7ebbb70c115636f872d13bb1c367916febc961c3 in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=7ebbb70 ]

        ISIS-1291: documentation on command and events.

        Also:

        • adding missing schemas in adocs documentation (for hosting on the web).
        • updating bad links to @Xxx_aaa in multiple files
        • deprecating some methods in applib API.
        Show
        jira-bot ASF subversion and git services added a comment - Commit 7ebbb70c115636f872d13bb1c367916febc961c3 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=7ebbb70 ] ISIS-1291 : documentation on command and events. Also: adding missing schemas in adocs documentation (for hosting on the web). updating bad links to @Xxx_aaa in multiple files deprecating some methods in applib API.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 55d3029a6265524ec3dbf65b2365d8569a42f61d in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=55d3029 ]

        ISIS-1291: further documentation. Slight extension to the PublishedObjects API

        Show
        jira-bot ASF subversion and git services added a comment - Commit 55d3029a6265524ec3dbf65b2365d8569a42f61d in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=55d3029 ] ISIS-1291 : further documentation. Slight extension to the PublishedObjects API
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit e74c7a9abd5380af93802cfaeb70ab41a4ee1f6d in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=e74c7a9 ]

        ISIS-1291: updating docs for new services. Also IsisTransaction now to clears the changed object properties rather than AuditingService, otherwise PublisherService would mis-report the metric of number of changed object properties.

        Show
        jira-bot ASF subversion and git services added a comment - Commit e74c7a9abd5380af93802cfaeb70ab41a4ee1f6d in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=e74c7a9 ] ISIS-1291 : updating docs for new services. Also IsisTransaction now to clears the changed object properties rather than AuditingService, otherwise PublisherService would mis-report the metric of number of changed object properties.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 0e5a55abd0b81319f75341524e18235043a69520 in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=0e5a55a ]

        ISIS-1291: moved internal framework services into its own guide

        Show
        jira-bot ASF subversion and git services added a comment - Commit 0e5a55abd0b81319f75341524e18235043a69520 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=0e5a55a ] ISIS-1291 : moved internal framework services into its own guide
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 8d179f5f673b165e748f39e3dd53f412dd1dffbd in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=8d179f5 ]

        ISIS-1291: updating documentation for schemas.

        Minor alterations to schemas themselves, just changing the order of members

        Show
        jira-bot ASF subversion and git services added a comment - Commit 8d179f5f673b165e748f39e3dd53f412dd1dffbd in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=8d179f5 ] ISIS-1291 : updating documentation for schemas. Minor alterations to schemas themselves, just changing the order of members
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit b319973f1fca979917ab3ab0fbd713dbfd9f806a in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=b319973 ]

        ISIS-1291: removed InstallerLookupAware and other unused code, simplified InstallerLookup and removed installer-registry.properties

        Namely:

        • AboutIsis, ComponentDetails, IsisInstallerRegistry, InstallerVersion, OptionHandlerDiagnostics, OptionHandlerVersion

        Also:

        • renamed PersistenceSessionInternal back to PersistenceSession, to avoid unnecessary breakage (this class isn't an internal domain service, anyway)
        Show
        jira-bot ASF subversion and git services added a comment - Commit b319973f1fca979917ab3ab0fbd713dbfd9f806a in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=b319973 ] ISIS-1291 : removed InstallerLookupAware and other unused code, simplified InstallerLookup and removed installer-registry.properties Namely: AboutIsis, ComponentDetails, IsisInstallerRegistry, InstallerVersion, OptionHandlerDiagnostics, OptionHandlerVersion Also: renamed PersistenceSessionInternal back to PersistenceSession, to avoid unnecessary breakage (this class isn't an internal domain service, anyway)
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit da4c9c5e1b8133ed012384760a1d261efe06698d in isis's branch refs/heads/master from Jeroen van der Wal
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=da4c9c5 ]

        ISIS-1291: Fixes for auditing

        Show
        jira-bot ASF subversion and git services added a comment - Commit da4c9c5e1b8133ed012384760a1d261efe06698d in isis's branch refs/heads/master from Jeroen van der Wal [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=da4c9c5 ] ISIS-1291 : Fixes for auditing
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 11097b763336598193017e370d11bdd2f2215a82 in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=11097b7 ]

        ISIS-1291: moved ConfigurationServiceInternal.

        also debated whether to move SpecificationLoader and ServicesInjector back to orig location, decided not to.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 11097b763336598193017e370d11bdd2f2215a82 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=11097b7 ] ISIS-1291 : moved ConfigurationServiceInternal. also debated whether to move SpecificationLoader and ServicesInjector back to orig location, decided not to.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 68968850cb62ba5513360025bda4bf369c06c4c4 in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=6896885 ]

        ISIS-1291: mixed-in interactions were showing the mixin as the target rather than the mixed-in. Also the action was shown as blank.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 68968850cb62ba5513360025bda4bf369c06c4c4 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=6896885 ] ISIS-1291 : mixed-in interactions were showing the mixin as the target rather than the mixed-in. Also the action was shown as blank.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 17c99b08f365855856c24c875c9b87fdb069a742 in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=17c99b0 ]

        ISIS-1291: adding null guard to create DTO for enum.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 17c99b08f365855856c24c875c9b87fdb069a742 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=17c99b0 ] ISIS-1291 : adding null guard to create DTO for enum.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit e2e206c3e5e4e21a9c19864bef7417aacfe58945 in isis's branch refs/heads/ISIS-1427 from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=e2e206c ]

        ISIS-1291: adds @Programmatic where necessary for new and internal domain services

        ... so that this stuff isn't unnecessarily loaded into themetamodel.

        In a similar vein, aAlso change IsisConfiguration so that it doesn't implement Iterable, because otherwise the default interface methods (spliterator, forEach) show up in the metamodel. Instead, extend to provide an "asIterable()" method.

        Show
        jira-bot ASF subversion and git services added a comment - Commit e2e206c3e5e4e21a9c19864bef7417aacfe58945 in isis's branch refs/heads/ ISIS-1427 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=e2e206c ] ISIS-1291 : adds @Programmatic where necessary for new and internal domain services ... so that this stuff isn't unnecessarily loaded into themetamodel. In a similar vein, aAlso change IsisConfiguration so that it doesn't implement Iterable, because otherwise the default interface methods (spliterator, forEach) show up in the metamodel. Instead, extend to provide an "asIterable()" method.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit e2e206c3e5e4e21a9c19864bef7417aacfe58945 in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=e2e206c ]

        ISIS-1291: adds @Programmatic where necessary for new and internal domain services

        ... so that this stuff isn't unnecessarily loaded into themetamodel.

        In a similar vein, aAlso change IsisConfiguration so that it doesn't implement Iterable, because otherwise the default interface methods (spliterator, forEach) show up in the metamodel. Instead, extend to provide an "asIterable()" method.

        Show
        jira-bot ASF subversion and git services added a comment - Commit e2e206c3e5e4e21a9c19864bef7417aacfe58945 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=e2e206c ] ISIS-1291 : adds @Programmatic where necessary for new and internal domain services ... so that this stuff isn't unnecessarily loaded into themetamodel. In a similar vein, aAlso change IsisConfiguration so that it doesn't implement Iterable, because otherwise the default interface methods (spliterator, forEach) show up in the metamodel. Instead, extend to provide an "asIterable()" method.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit dba0d51eb79488319e1dd1e9fe5029e0b1f39eef in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=dba0d51 ]

        ISIS-1452: reinstates logic to abort transaction if an exception is thrown.

        Previously (1.12.x) this was done using transaction facet decorators, but the work done under ISIS-1291 and others for this release removed those classes, without moving the responsibility elsewhere.

        This commit reintroduces the handling, with the ActionInvocationFacet and PropertySetterOrClearFacet using the looked-up PersistenceSessionServiceInternal to executeWithinTransaction; this is basically the same place in the call stack that the decorator facets would have been.

        The *Default impl of this - as used in runtime - delegates to the IsisTransactionManager#executeWithinTransaction(...).

        Show
        jira-bot ASF subversion and git services added a comment - Commit dba0d51eb79488319e1dd1e9fe5029e0b1f39eef in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=dba0d51 ] ISIS-1452 : reinstates logic to abort transaction if an exception is thrown. Previously (1.12.x) this was done using transaction facet decorators, but the work done under ISIS-1291 and others for this release removed those classes, without moving the responsibility elsewhere. This commit reintroduces the handling, with the ActionInvocationFacet and PropertySetterOrClearFacet using the looked-up PersistenceSessionServiceInternal to executeWithinTransaction; this is basically the same place in the call stack that the decorator facets would have been. The *Default impl of this - as used in runtime - delegates to the IsisTransactionManager#executeWithinTransaction(...).
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 2e33a1f05eff5525f7438f95fe0dd2700832bcf3 in isis's branch refs/heads/master from Dan Haywood
        [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=2e33a1f ]

        ISIS-1291: fixes Bookmark to handle OidDto with a null object state (assumes persistent).

        Show
        jira-bot ASF subversion and git services added a comment - Commit 2e33a1f05eff5525f7438f95fe0dd2700832bcf3 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=2e33a1f ] ISIS-1291 : fixes Bookmark to handle OidDto with a null object state (assumes persistent).

          People

          • Assignee:
            danhaywood Dan Haywood
            Reporter:
            danhaywood Dan Haywood
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development