[CAUSEWAY-1269] Deleting an object from a list can cause NPE when that list is re-rendered.

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.10.0
• Fix Version/s: 1.11.0
• Component/s: Core
• Assignee: Unassigned
• Reporter: Daniel Keir Haywood
• Created: 26/Nov/15 14:09
• Updated: 02/Jan/16 05:53
• Resolved: 26/Nov/15 14:20

Description

For example, in the todoapp the home page displays all the todo items, not yet completed vs completed.

If select "Buy Milk" (when not complete) and delete it, then the NPE is thrown.

This is ultimately because the list returned from ToDoItem#delete() is stale:

    public List<ToDoItem> delete() {

        // obtain title first, because cannot reference object after deleted
        final String title = container.titleOf(this);

        final List<ToDoItem> returnList = actionInvocationContext.isLast() ? toDoItems.notYetComplete() : null;

        container.removeIfNotAlready(this);

        container.informUser(
                TranslatableString.tr("Deleted {title}", "title", title), this.getClass(), "delete");

        return returnList;
    }

It ought not to return the current object about to be deleted.

Even so, we can handle this application programming error easily enough, by filtering out any null objects.