Uploaded image for project: 'Isis'
  1. Isis
  2. ISIS-1239

For wicket ui, use a cookie or similar to remember the hint from last time.

        Details

        • Type: Improvement
        • Status: Closed
        • Priority: Minor
        • Resolution: Fixed
        • Affects Version/s: 1.9.0
        • Fix Version/s: 1.12.0
        • Component/s: Core
        • Labels:
          None

          Description

          A nice to have, but would improve usability of fullcalendar2, gmap3 etc.

            Activity

            Descending order - Click to sort in ascending order
            Hide
            Permalink
            jira-bot ASF subversion and git services added a comment -

            Commit 4672aefa73db3b10612c52c8d8c6fd7a117398d2 in isis's branch refs/heads/master from Dan Haywood
            [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=4672aef ]

            ISIS-1239, ISIS-1324, ISIS-1328: multi-select for standalone collections was broken, now fixed.

            Issue was that earlier work moved entire responsibility for being the "UiHintContainer" onto the EntityModel, on the basis that only entities can store hints over time. However, the selector drop-down for standalone collections also was storying the hint on the UiHintContainer, which previously was also supported by (standalone) EntityCollectionModel. This meant that the hint got lost. Fix for that is to allow the IsisUiHintEvent to also directly hold the hint info.

            In addition, the algorithm for selecting the default view was broken for standalone collections; should default to "table" if a standalone and there is no other metadata available.

            Show
            jira-bot ASF subversion and git services added a comment - Commit 4672aefa73db3b10612c52c8d8c6fd7a117398d2 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=4672aef ] ISIS-1239 , ISIS-1324 , ISIS-1328 : multi-select for standalone collections was broken, now fixed. Issue was that earlier work moved entire responsibility for being the "UiHintContainer" onto the EntityModel, on the basis that only entities can store hints over time. However, the selector drop-down for standalone collections also was storying the hint on the UiHintContainer, which previously was also supported by (standalone) EntityCollectionModel. This meant that the hint got lost. Fix for that is to allow the IsisUiHintEvent to also directly hold the hint info. In addition, the algorithm for selecting the default view was broken for standalone collections; should default to "table" if a standalone and there is no other metadata available.
            Hide
            Permalink
            jira-bot ASF subversion and git services added a comment -

            Commit ca94ac6edebb6c7c6a517b09e7c560b31df0579e in isis's branch refs/heads/master from Dan Haywood
            [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=ca94ac6 ]

            ISIS-1239: refactored hints, now correctly serialized into session (once more), and can grab as a copy. This also includes the remembering of state when revisit page (even if no hints explicitly grabbed).

            Show
            jira-bot ASF subversion and git services added a comment - Commit ca94ac6edebb6c7c6a517b09e7c560b31df0579e in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=ca94ac6 ] ISIS-1239 : refactored hints, now correctly serialized into session (once more), and can grab as a copy. This also includes the remembering of state when revisit page (even if no hints explicitly grabbed).
            Hide
            Permalink
            danhaywood Dan Haywood added a comment -

            Since this ticket was raised, the @CollectionLayout has been enhanced so can specify the default view. So the problem is less of an issue than previously.

            Show
            danhaywood Dan Haywood added a comment - Since this ticket was raised, the @CollectionLayout has been enhanced so can specify the default view. So the problem is less of an issue than previously.
            Hide
            Permalink
            mgrigorov Martin Grigorov added a comment -

            See https://github.com/apache/isis/blob/master/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/widgets/themepicker/ThemeChooser.java#L112-L123 for inspiration.

            Show
            mgrigorov Martin Grigorov added a comment - See https://github.com/apache/isis/blob/master/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/widgets/themepicker/ThemeChooser.java#L112-L123 for inspiration.

              People

              • Assignee:
                danhaywood Dan Haywood
                Reporter:
                danhaywood Dan Haywood
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development