Details

    • Type: Dependency upgrade
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.9.0
    • Fix Version/s: 1.15.0
    • Component/s: Core
    • Labels:
      None

      Description

      to keep up to date, and as a prereq for ISIS-1224.

        Issue Links

          Activity

          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit dc976bcddfb59d0d34b267bee21f02d6a56a0e3c in isis's branch refs/heads/ISIS-1223-upgrade-to-wicket-7 from Martin Grigorov
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=dc976bc ]

          ISIS-1223 Upgrade Wicket to 7.x

          Show
          jira-bot ASF subversion and git services added a comment - Commit dc976bcddfb59d0d34b267bee21f02d6a56a0e3c in isis's branch refs/heads/ ISIS-1223 -upgrade-to-wicket-7 from Martin Grigorov [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=dc976bc ] ISIS-1223 Upgrade Wicket to 7.x
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 8eab4577340e0b15b0b5db5454ed1f10e89ba5b7 in isis's branch refs/heads/ISIS-1223-upgrade-to-wicket-7 from Martin Grigorov
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=8eab457 ]

          ISIS-1223 Upgrade Wicket to 7.x

          Fix Maven dependency convergences.
          Fix indents.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 8eab4577340e0b15b0b5db5454ed1f10e89ba5b7 in isis's branch refs/heads/ ISIS-1223 -upgrade-to-wicket-7 from Martin Grigorov [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=8eab457 ] ISIS-1223 Upgrade Wicket to 7.x Fix Maven dependency convergences. Fix indents.
          Hide
          mgrigorov Martin Grigorov added a comment -

          I've upgraded Isis to Wicket 7 in branch "ISIS-1223-upgrade-to-wicket-7".
          Unfortunately I've found a bug (WICKET-6020) that will break the application unless all Guice dependencies have non-null values. I see no easy way to work it around. The only way I see
          is to copy temporarily the complete GuiceFieldValueFactory and fix it in Isis until Wicket 7.2.0 is released. I'll try it now.

          Show
          mgrigorov Martin Grigorov added a comment - I've upgraded Isis to Wicket 7 in branch " ISIS-1223 -upgrade-to-wicket-7". Unfortunately I've found a bug ( WICKET-6020 ) that will break the application unless all Guice dependencies have non-null values. I see no easy way to work it around. The only way I see is to copy temporarily the complete GuiceFieldValueFactory and fix it in Isis until Wicket 7.2.0 is released. I'll try it now.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 5625c6c4cec59c57e00cffa0159a89795b46addc in isis's branch refs/heads/ISIS-1223-upgrade-to-wicket-7 from Martin Grigorov
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=5625c6c ]

          ISIS-1223 Upgrade Wicket to 7.x

          Copy temporarily Wicket's Guice classes to workaround issue https://issues.apache.org/jira/browse/WICKET-6020.
          Once Wicket 7.2.0 is released these classes should be removed!

          Show
          jira-bot ASF subversion and git services added a comment - Commit 5625c6c4cec59c57e00cffa0159a89795b46addc in isis's branch refs/heads/ ISIS-1223 -upgrade-to-wicket-7 from Martin Grigorov [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=5625c6c ] ISIS-1223 Upgrade Wicket to 7.x Copy temporarily Wicket's Guice classes to workaround issue https://issues.apache.org/jira/browse/WICKET-6020 . Once Wicket 7.2.0 is released these classes should be removed!
          Hide
          mgrigorov Martin Grigorov added a comment -

          It worked!
          The classes in org.apache.isis.viewer.wicket.viewer.guice package should be removed once Wicket 7.2.0 is in use.

          Show
          mgrigorov Martin Grigorov added a comment - It worked! The classes in org.apache.isis.viewer.wicket.viewer.guice package should be removed once Wicket 7.2.0 is in use.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit d483b2c6eca16ff53b0e963e2bf308666fc92f6f in isis's branch refs/heads/ISIS-1223-upgrade-to-wicket-7 from Martin Grigorov
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d483b2c ]

          ISIS-1223 Upgrade Wicket to 7.x

          Change the id of the rememberMe parent.
          Changed in Wicket with: https://github.com/apache/wicket/commit/e0b105e5bcee89917d04c3a2164440d0ed2fc738

          Show
          jira-bot ASF subversion and git services added a comment - Commit d483b2c6eca16ff53b0e963e2bf308666fc92f6f in isis's branch refs/heads/ ISIS-1223 -upgrade-to-wicket-7 from Martin Grigorov [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d483b2c ] ISIS-1223 Upgrade Wicket to 7.x Change the id of the rememberMe parent. Changed in Wicket with: https://github.com/apache/wicket/commit/e0b105e5bcee89917d04c3a2164440d0ed2fc738
          Hide
          danhaywood Dan Haywood added a comment -

          hitting an issue in Wicket when rendering collections; see https://issues.apache.org/jira/browse/WICKET-6021

          Show
          danhaywood Dan Haywood added a comment - hitting an issue in Wicket when rendering collections; see https://issues.apache.org/jira/browse/WICKET-6021
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit a6fe41c3ab4f22052af1f826a1f48b885e2cb874 in isis's branch refs/heads/ISIS-1224-select2-v4 from Martin Grigorov
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=a6fe41c ]

          ISIS-1223 Use Wicket 7.0.0 until 7.1.0+ is released (due to WICKET-6021)

          Show
          jira-bot ASF subversion and git services added a comment - Commit a6fe41c3ab4f22052af1f826a1f48b885e2cb874 in isis's branch refs/heads/ ISIS-1224 -select2-v4 from Martin Grigorov [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=a6fe41c ] ISIS-1223 Use Wicket 7.0.0 until 7.1.0+ is released (due to WICKET-6021 )
          Hide
          danhaywood Dan Haywood added a comment -

          blocked by WICKET-6021, scheduled to be fixed in 7.2.0.

          Martin's workaround is to go back to Wicket 7.0.0, but I'd rather not do that since it has known O(n^2) issues for rendering which might be significant for some Isis apps.

          Show
          danhaywood Dan Haywood added a comment - blocked by WICKET-6021 , scheduled to be fixed in 7.2.0. Martin's workaround is to go back to Wicket 7.0.0, but I'd rather not do that since it has known O(n^2) issues for rendering which might be significant for some Isis apps.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 803fbc14c825de91204d2ba5a73712c963f56322 in isis's branch refs/heads/ISIS-1223-upgrade-to-wicket-7 from Martin Grigorov
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=803fbc1 ]

          Merge branch 'master' into ISIS-1223-upgrade-to-wicket-7

          Show
          jira-bot ASF subversion and git services added a comment - Commit 803fbc14c825de91204d2ba5a73712c963f56322 in isis's branch refs/heads/ ISIS-1223 -upgrade-to-wicket-7 from Martin Grigorov [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=803fbc1 ] Merge branch 'master' into ISIS-1223 -upgrade-to-wicket-7
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 803fbc14c825de91204d2ba5a73712c963f56322 in isis's branch refs/heads/ISIS-1224-select2-v4 from Martin Grigorov
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=803fbc1 ]

          Merge branch 'master' into ISIS-1223-upgrade-to-wicket-7

          Show
          jira-bot ASF subversion and git services added a comment - Commit 803fbc14c825de91204d2ba5a73712c963f56322 in isis's branch refs/heads/ ISIS-1224 -select2-v4 from Martin Grigorov [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=803fbc1 ] Merge branch 'master' into ISIS-1223 -upgrade-to-wicket-7
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 17d7159fa58871c64bc70be3b467a139d7464a90 in isis's branch refs/heads/ISIS-1224-select2-v4 from Martin Grigorov
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=17d7159 ]

          Merge branch 'ISIS-1223-upgrade-to-wicket-7' into ISIS-1224-select2-v4

          Show
          jira-bot ASF subversion and git services added a comment - Commit 17d7159fa58871c64bc70be3b467a139d7464a90 in isis's branch refs/heads/ ISIS-1224 -select2-v4 from Martin Grigorov [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=17d7159 ] Merge branch ' ISIS-1223 -upgrade-to-wicket-7' into ISIS-1224 -select2-v4
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 82a392435399f4893ba22f8b4495040c32f0a017 in isis's branch refs/heads/ISIS-1223-upgrade-to-wicket-7 from Martin Grigorov
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=82a3924 ]

          Merge branch 'master' into ISIS-1223-upgrade-to-wicket-7

          Show
          jira-bot ASF subversion and git services added a comment - Commit 82a392435399f4893ba22f8b4495040c32f0a017 in isis's branch refs/heads/ ISIS-1223 -upgrade-to-wicket-7 from Martin Grigorov [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=82a3924 ] Merge branch 'master' into ISIS-1223 -upgrade-to-wicket-7
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit f4697c617e82a8516e921ace9d6852d013c52c07 in isis's branch refs/heads/ISIS-1223-upgrade-to-wicket-7 from Martin Grigorov
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=f4697c6 ]

          Merge branch 'master' into ISIS-1223-upgrade-to-wicket-7

          Show
          jira-bot ASF subversion and git services added a comment - Commit f4697c617e82a8516e921ace9d6852d013c52c07 in isis's branch refs/heads/ ISIS-1223 -upgrade-to-wicket-7 from Martin Grigorov [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=f4697c6 ] Merge branch 'master' into ISIS-1223 -upgrade-to-wicket-7
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit f4697c617e82a8516e921ace9d6852d013c52c07 in isis's branch refs/heads/ISIS-1224-select2-v4 from Martin Grigorov
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=f4697c6 ]

          Merge branch 'master' into ISIS-1223-upgrade-to-wicket-7

          Show
          jira-bot ASF subversion and git services added a comment - Commit f4697c617e82a8516e921ace9d6852d013c52c07 in isis's branch refs/heads/ ISIS-1224 -select2-v4 from Martin Grigorov [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=f4697c6 ] Merge branch 'master' into ISIS-1223 -upgrade-to-wicket-7
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 5576387731bc74affcc34c5c39899a67c7d71676 in isis's branch refs/heads/ISIS-1224-select2-v4 from Martin Grigorov
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=5576387 ]

          Merge branch 'ISIS-1223-upgrade-to-wicket-7' into ISIS-1224-select2-v4

          Show
          jira-bot ASF subversion and git services added a comment - Commit 5576387731bc74affcc34c5c39899a67c7d71676 in isis's branch refs/heads/ ISIS-1224 -select2-v4 from Martin Grigorov [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=5576387 ] Merge branch ' ISIS-1223 -upgrade-to-wicket-7' into ISIS-1224 -select2-v4
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 17d7159fa58871c64bc70be3b467a139d7464a90 in isis's branch refs/heads/master from Martin Grigorov
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=17d7159 ]

          Merge branch 'ISIS-1223-upgrade-to-wicket-7' into ISIS-1224-select2-v4

          Show
          jira-bot ASF subversion and git services added a comment - Commit 17d7159fa58871c64bc70be3b467a139d7464a90 in isis's branch refs/heads/master from Martin Grigorov [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=17d7159 ] Merge branch ' ISIS-1223 -upgrade-to-wicket-7' into ISIS-1224 -select2-v4
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 82a392435399f4893ba22f8b4495040c32f0a017 in isis's branch refs/heads/master from Martin Grigorov
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=82a3924 ]

          Merge branch 'master' into ISIS-1223-upgrade-to-wicket-7

          Show
          jira-bot ASF subversion and git services added a comment - Commit 82a392435399f4893ba22f8b4495040c32f0a017 in isis's branch refs/heads/master from Martin Grigorov [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=82a3924 ] Merge branch 'master' into ISIS-1223 -upgrade-to-wicket-7
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit f4697c617e82a8516e921ace9d6852d013c52c07 in isis's branch refs/heads/master from Martin Grigorov
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=f4697c6 ]

          Merge branch 'master' into ISIS-1223-upgrade-to-wicket-7

          Show
          jira-bot ASF subversion and git services added a comment - Commit f4697c617e82a8516e921ace9d6852d013c52c07 in isis's branch refs/heads/master from Martin Grigorov [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=f4697c6 ] Merge branch 'master' into ISIS-1223 -upgrade-to-wicket-7
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 5576387731bc74affcc34c5c39899a67c7d71676 in isis's branch refs/heads/master from Martin Grigorov
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=5576387 ]

          Merge branch 'ISIS-1223-upgrade-to-wicket-7' into ISIS-1224-select2-v4

          Show
          jira-bot ASF subversion and git services added a comment - Commit 5576387731bc74affcc34c5c39899a67c7d71676 in isis's branch refs/heads/master from Martin Grigorov [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=5576387 ] Merge branch ' ISIS-1223 -upgrade-to-wicket-7' into ISIS-1224 -select2-v4
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 04d8842f8a162e60a94d303296dc2c0218071348 in isis's branch refs/heads/master from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=04d8842 ]

          ISIS-1223: merges remote-tracking branch 'origin/ISIS-1223-upgrade-to-wicket-7'

          1. Fixed conflicts:
          2. core/pom.xml
          3. core/viewer-wicket-impl/src/main/java/org/apache/isis/viewer/wicket/viewer/IsisWicketApplication.java
          4. core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/pages/mmverror/MmvErrorPage.java
          5. core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/panels/FormAbstract.java
          6. core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/panels/PanelAbstract.java
          Show
          jira-bot ASF subversion and git services added a comment - Commit 04d8842f8a162e60a94d303296dc2c0218071348 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=04d8842 ] ISIS-1223 : merges remote-tracking branch 'origin/ ISIS-1223 -upgrade-to-wicket-7' Fixed conflicts: core/pom.xml core/viewer-wicket-impl/src/main/java/org/apache/isis/viewer/wicket/viewer/IsisWicketApplication.java core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/pages/mmverror/MmvErrorPage.java core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/panels/FormAbstract.java core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/panels/PanelAbstract.java
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 04d8842f8a162e60a94d303296dc2c0218071348 in isis's branch refs/heads/master from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=04d8842 ]

          ISIS-1223: merges remote-tracking branch 'origin/ISIS-1223-upgrade-to-wicket-7'

          1. Fixed conflicts:
          2. core/pom.xml
          3. core/viewer-wicket-impl/src/main/java/org/apache/isis/viewer/wicket/viewer/IsisWicketApplication.java
          4. core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/pages/mmverror/MmvErrorPage.java
          5. core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/panels/FormAbstract.java
          6. core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/panels/PanelAbstract.java
          Show
          jira-bot ASF subversion and git services added a comment - Commit 04d8842f8a162e60a94d303296dc2c0218071348 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=04d8842 ] ISIS-1223 : merges remote-tracking branch 'origin/ ISIS-1223 -upgrade-to-wicket-7' Fixed conflicts: core/pom.xml core/viewer-wicket-impl/src/main/java/org/apache/isis/viewer/wicket/viewer/IsisWicketApplication.java core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/pages/mmverror/MmvErrorPage.java core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/panels/FormAbstract.java core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/panels/PanelAbstract.java
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 8bf0cc73d81c67ca2f5a77efb83f539f45c4e1b7 in isis's branch refs/heads/master from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=8bf0cc7 ]

          ISIS-1223: fixes merge errors; bumps dependency on wicket.bootstrap from 0.10.7 to 0.10.10

          Show
          jira-bot ASF subversion and git services added a comment - Commit 8bf0cc73d81c67ca2f5a77efb83f539f45c4e1b7 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=8bf0cc7 ] ISIS-1223 : fixes merge errors; bumps dependency on wicket.bootstrap from 0.10.7 to 0.10.10
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit f6f10e349e984a33b4e7033e9c459c9d564e9fbf in isis's branch refs/heads/master from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=f6f10e3 ]

          ISIS-1223: fixes remaining issues with merging in of branch; also bumps simpleapp to run against 1.14.0-SNAPSHOT

          Show
          jira-bot ASF subversion and git services added a comment - Commit f6f10e349e984a33b4e7033e9c459c9d564e9fbf in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=f6f10e3 ] ISIS-1223 : fixes remaining issues with merging in of branch; also bumps simpleapp to run against 1.14.0-SNAPSHOT
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit ac7b458b6921e6e2036bd82f8c52f832ec609728 in isis's branch refs/heads/master from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=ac7b458 ]

          ISIS-1223: updates to Wicket 7.5.0

          Show
          jira-bot ASF subversion and git services added a comment - Commit ac7b458b6921e6e2036bd82f8c52f832ec609728 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=ac7b458 ] ISIS-1223 : updates to Wicket 7.5.0
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit d37fa6a47181e4b644da23823b27a6dbbda73a66 in isis's branch refs/heads/master from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d37fa6a ]

          ISIS-1223: adds missing i18n resources that seem to be mandatory in Wicket 7

          Show
          jira-bot ASF subversion and git services added a comment - Commit d37fa6a47181e4b644da23823b27a6dbbda73a66 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d37fa6a ] ISIS-1223 : adds missing i18n resources that seem to be mandatory in Wicket 7
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 0ff91f9c8d3df7c3987e4787ec80f05a93ce0cb9 in isis's branch refs/heads/master from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=0ff91f9 ]

          ISIS-1223: fixes issue with select2 and bootstrap.

          Also:

          • bump to wicket 7.6.0, select2 4.0.3, wicket-bootstrap 1.10.12
            -
          Show
          jira-bot ASF subversion and git services added a comment - Commit 0ff91f9c8d3df7c3987e4787ec80f05a93ce0cb9 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=0ff91f9 ] ISIS-1223 : fixes issue with select2 and bootstrap. Also: bump to wicket 7.6.0, select2 4.0.3, wicket-bootstrap 1.10.12 -
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 530d5550bc3da40118956c8f88bd074becc24d03 in isis's branch refs/heads/master from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=530d555 ]

          ISIS-1223: further fix for select2 and bootstrap (focus issue)

          Show
          jira-bot ASF subversion and git services added a comment - Commit 530d5550bc3da40118956c8f88bd074becc24d03 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=530d555 ] ISIS-1223 : further fix for select2 and bootstrap (focus issue)

            People

            • Assignee:
              mgrigorov Martin Grigorov
              Reporter:
              danhaywood Dan Haywood
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development