[CAUSEWAY-1172] Logo in wicket viewer should be calculated relative to context root

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.9.0
• Fix Version/s: 2.0.0-M1
• Component/s: Viewer Wicket
• Assignee: Andi Huber
• Reporter: Jörg Rade
• Created: 10/Jul/15 08:56
• Updated: 14/Mar/18 16:49
• Resolved: 03/Mar/18 10:26

Description

bind(String.class).annotatedWith(Names.named("brandLogoHeader"))
.toInstance("/images/knife-logo-header.png");

doesn't work for me. I had to specify "/sdm-webapp/images/knife-logo-header.png".

Tried. using "images/knife-logo-header.png"
Compared generated the simple app from the maven archetype and diffed my web.xml against the generated and adopted my web.xml to match my SimpleApplication package name.

Analysis by Martin:
Wicket automatically calculates the context relative path for plain HTML <img> elements in your markup.
In the current case the <img> element is connected to a Java component, i.e. it has wicket:id attribute, and that's why Wicket doesn't apply any special logic on it.
IMO we should improve Isis to always calculate context relative path for the logo url.