Uploaded image for project: 'Isis'
  1. Isis
  2. ISIS-1060

An exception is logged when the provided credentials are invalid

    Details

    • Type: Wish
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: core-1.8.0
    • Fix Version/s: 1.9.0
    • Component/s: Core
    • Labels:
      None

      Description

      If trying to authenticate with wrong credentials Isis Shiro integration logs an ERROR with its complete stacktrace.
      This is not an error in the application so I think it should be logged with lower level, e.g. WARN (but even WARN looks too much to me for this normal use case).
      The second change that I'd recommend is to not dump the stacktrace.
      Instead of:
      LOG.error("Unable to authenticate", ae);
      do:
      LOG.error("Unable to authenticate. Reason: " + ae.getMessage());

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              mgrigorov Martin Grigorov
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: