[IOTDB-3402] Abuse of ScheduledExecutorService.scheduleWithFixedDelay

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: master branch
• Component/s: Core/Compaction, Core/WAL
• Labels: pull-request-available
• Assignee: Eric Pai
• Reporter: Eric Pai
• Created: 06/Jun/22 10:00
• Updated: 07/Jun/22 02:05
• Resolved: 06/Jun/22 15:20

Description

The Java doc of ScheduledExecutorService.scheduleWithFixedDelay describes as the below:

Creates and executes a periodic action that becomes enabled first after the given initial delay, and subsequently with the given delay between the termination of one execution and the commencement of the next. If any execution of the task encounters an exception, subsequent executions are suppressed. Otherwise, the task will only terminate via cancellation or termination of the executor.

So in IoTDB there're some important schedule tasks but without exception protection, which may be the risk of unexcepted non-schedule of them. We should fix it.

 

Note that WrappedSingleThreadScheduledExecutor and WrappedScheduledExecutorService should be unchanged as they are just the implementations of ScheduledExecutorService and should obey the interface definition.

Issue Links

• is related to: IOTDB-3407 Forbid use scheduleAtFixRate directly
• links to: GitHub Pull Request #6172