[IOTDB-1678] client-cpp session bug: can cause connection leak.

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.13.0, 0.12.3
• Component/s: Client/Others
• Labels: pull-request-available
• Assignee: Bo Zhang
• Reporter: Bo Zhang
• Created: 14/Sep/21 12:39
• Updated: 22/Sep/21 07:24
• Resolved: 16/Sep/21 08:45

Description

in file Session.h and Session.cpp

========================================

class Session

{    ...    std::shared_ptr <apache::thrift::transport::TSocket> transport; }

 

void Session::open(bool enableRPCCompression, int connectionTimeoutInMs)

{    ...    shared_ptr <TTransport> transport(new TFramedTransport(socket));  //here, wrongly create 1 new variable transport, and no code will call this local variable transport->close() to release connection }

 

void Session::close() {
   if (transport != NULL)

{  //here, use Session.transport       transport->close();    }

}

 

Issue Links

• links to: GitHub Pull Request #3962
• links to: GitHub Pull Request #3973